-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HDInsight] Update swagger to support private link feature #9659
Conversation
[Staging] Swagger Validation Report
❌ |
Rule | Message |
---|---|
1041 - AddedPropertyInResponse |
The new version has a new property 'networkSettings' in response that was not found in the old version. New: Microsoft.HDInsight/preview/2015-03-01-preview/cluster.json#L1108:7 Old: Microsoft.HDInsight/preview/2015-03-01-preview/cluster.json#L1072:7 |
1041 - AddedPropertyInResponse |
The new version has a new property 'networkSettings' in response that was not found in the old version. New: Microsoft.HDInsight/stable/2018-06-01-preview/cluster.json#L1108:7 Old: Microsoft.HDInsight/stable/2018-06-01-preview/cluster.json#L1072:7 |
️️✔️
LintDiff [Detail]
️✔️
Validation passes for LintDiff.
️️✔️
Avocado [Detail]
️✔️
Validation passes for Avocado.
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
Can one of the admins verify this patch? |
0de64aa
to
fbfd358
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in the GET part is breaking changes as per the guidelines. Please update the API version or follow Azure Breaking changes approval request form as defined @ Breaking Change Process
Thanks your comments. I have sent email by following the wiki. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Removing ARM Feedback label since ARM review board will not be reviewing property level changes going forward. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking changes should be OK since it is a preview API
/openapi pipeline |
Unrecognized OpenAPI bot command (pipeline). |
2 similar comments
Unrecognized OpenAPI bot command (pipeline). |
Unrecognized OpenAPI bot command (pipeline). |
* Update swagger to support network isolation options * Fix prettier check failure * Update network feature Co-authored-by: Zhenyu Zhou <[email protected]>
Update swagger to support network isolation options
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.