Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Security to add version stable/2019-08-01 #9653

Merged
merged 42 commits into from
Jun 28, 2020

Conversation

liranc
Copy link
Contributor

@liranc liranc commented May 31, 2020

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 31, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented May 31, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented May 31, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from a9ed504 with merge commit c8ab856. SDK Automation 13.0.17.20200619.4
  • ️✔️@azure/arm-security [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/securityCenter.js → ./dist/arm-security.js...
    [npmPack] created ./dist/arm-security.js in 1s
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 4.7kB   esm/operations/adaptiveApplicationControls.js                          
    [npmPack] npm notice 601B    esm/models/adaptiveApplicationControlsMappers.js                       
    [npmPack] npm notice 7.9kB   esm/operations/adaptiveNetworkHardenings.js                            
    [npmPack] npm notice 3.0kB   esm/models/adaptiveNetworkHardeningsMappers.js                         
    [npmPack] npm notice 3.0kB   esm/operations/advancedThreatProtection.js                             
    [npmPack] npm notice 2.9kB   esm/models/advancedThreatProtectionMappers.js                          
    [npmPack] npm notice 13.7kB  esm/operations/alerts.js                                               
    [npmPack] npm notice 2.9kB   esm/models/alertsMappers.js                                            
    [npmPack] npm notice 5.5kB   esm/operations/alertsSuppressionRules.js                               
    [npmPack] npm notice 3.0kB   esm/models/alertsSuppressionRulesMappers.js                            
    [npmPack] npm notice 5.0kB   esm/operations/allowedConnections.js                                   
    [npmPack] npm notice 521B    esm/models/allowedConnectionsMappers.js                                
    [npmPack] npm notice 672.2kB dist/arm-security.js                                                   
    [npmPack] npm notice 262.2kB dist/arm-security.min.js                                               
    [npmPack] npm notice 5.3kB   esm/operations/assessments.js                                          
    [npmPack] npm notice 3.0kB   esm/models/assessmentsMappers.js                                       
    [npmPack] npm notice 7.7kB   esm/operations/assessmentsMetadata.js                                  
    [npmPack] npm notice 3.0kB   esm/models/assessmentsMetadataMappers.js                               
    [npmPack] npm notice 8.3kB   esm/operations/automations.js                                          
    [npmPack] npm notice 672B    esm/models/automationsMappers.js                                       
    [npmPack] npm notice 4.4kB   esm/operations/autoProvisioningSettings.js                             
    [npmPack] npm notice 3.0kB   esm/models/autoProvisioningSettingsMappers.js                          
    [npmPack] npm notice 3.3kB   esm/operations/complianceResults.js                                    
    [npmPack] npm notice 3.0kB   esm/models/complianceResultsMappers.js                                 
    [npmPack] npm notice 3.2kB   esm/operations/compliances.js                                          
    [npmPack] npm notice 2.9kB   esm/models/compliancesMappers.js                                       
    [npmPack] npm notice 5.1kB   esm/operations/connectors.js                                           
    [npmPack] npm notice 3.0kB   esm/models/connectorsMappers.js                                        
    [npmPack] npm notice 5.6kB   esm/operations/deviceSecurityGroups.js                                 
    [npmPack] npm notice 3.0kB   esm/models/deviceSecurityGroupsMappers.js                              
    [npmPack] npm notice 5.3kB   esm/operations/discoveredSecuritySolutions.js                          
    [npmPack] npm notice 498B    esm/models/discoveredSecuritySolutionsMappers.js                       
    [npmPack] npm notice 5.3kB   esm/operations/externalSecuritySolutions.js                            
    [npmPack] npm notice 704B    esm/models/externalSecuritySolutionsMappers.js                         
    [npmPack] npm notice 345B    esm/models/index.js                                                    
    [npmPack] npm notice 1.9kB   esm/operations/index.js                                                
    [npmPack] npm notice 4.9kB   esm/operations/informationProtectionPolicies.js                        
    [npmPack] npm notice 3.0kB   esm/models/informationProtectionPoliciesMappers.js                     
    [npmPack] npm notice 3.8kB   esm/operations/iotAlerts.js                                            
    [npmPack] npm notice 444B    esm/models/iotAlertsMappers.js                                         
    [npmPack] npm notice 3.0kB   esm/operations/iotAlertTypes.js                                        
    [npmPack] npm notice 3.0kB   esm/models/iotAlertTypesMappers.js                                     
    [npmPack] npm notice 8.9kB   esm/operations/iotSecuritySolution.js                                  
    [npmPack] npm notice 3.1kB   esm/operations/iotSecuritySolutionAnalytics.js                         
    [npmPack] npm notice 3.0kB   esm/models/iotSecuritySolutionAnalyticsMappers.js                      
    [npmPack] npm notice 598B    esm/models/iotSecuritySolutionMappers.js                               
    [npmPack] npm notice 5.3kB   esm/operations/iotSecuritySolutionsAnalyticsAggregatedAlert.js         
    [npmPack] npm notice 571B    esm/models/iotSecuritySolutionsAnalyticsAggregatedAlertMappers.js      
    [npmPack] npm notice 4.3kB   esm/operations/iotSecuritySolutionsAnalyticsRecommendation.js          
    [npmPack] npm notice 532B    esm/models/iotSecuritySolutionsAnalyticsRecommendationMappers.js       
    [npmPack] npm notice 12.6kB  esm/operations/jitNetworkAccessPolicies.js                             
    [npmPack] npm notice 767B    esm/models/jitNetworkAccessPoliciesMappers.js                          
    [npmPack] npm notice 3.1kB   esm/operations/locations.js                                            
    [npmPack] npm notice 2.9kB   esm/models/locationsMappers.js                                         
    [npmPack] npm notice 197.0kB esm/models/mappers.js                                                  
    [npmPack] npm notice 2.2kB   esm/operations/operations.js                                           
    [npmPack] npm notice 465B    esm/models/operationsMappers.js                                        
    [npmPack] npm notice 16.5kB  esm/models/parameters.js                                               
    [npmPack] npm notice 3.4kB   esm/operations/pricings.js                                             
    [npmPack] npm notice 2.9kB   esm/models/pricingsMappers.js                                          
    [npmPack] npm notice 4.5kB   esm/operations/regulatoryComplianceAssessments.js                      
    [npmPack] npm notice 3.0kB   esm/models/regulatoryComplianceAssessmentsMappers.js                   
    [npmPack] npm notice 4.0kB   esm/operations/regulatoryComplianceControls.js                         
    [npmPack] npm notice 3.0kB   esm/models/regulatoryComplianceControlsMappers.js                      
    [npmPack] npm notice 3.6kB   esm/operations/regulatoryComplianceStandards.js                        
    [npmPack] npm notice 3.0kB   esm/models/regulatoryComplianceStandardsMappers.js                     
    [npmPack] npm notice 976B    rollup.config.js                                                       
    [npmPack] npm notice 4.1kB   esm/operations/secureScoreControlDefinitions.js                        
    [npmPack] npm notice 3.0kB   esm/models/secureScoreControlDefinitionsMappers.js                     
    [npmPack] npm notice 4.2kB   esm/operations/secureScoreControls.js                                  
    [npmPack] npm notice 3.0kB   esm/models/secureScoreControlsMappers.js                               
    [npmPack] npm notice 3.2kB   esm/operations/secureScores.js                                         
    [npmPack] npm notice 3.0kB   esm/models/secureScoresMappers.js                                      
    [npmPack] npm notice 4.7kB   esm/securityCenter.js                                                  
    [npmPack] npm notice 2.7kB   esm/securityCenterContext.js                                           
    [npmPack] npm notice 6.3kB   esm/operations/securityContacts.js                                     
    [npmPack] npm notice 3.0kB   esm/models/securityContactsMappers.js                                  
    [npmPack] npm notice 6.5kB   esm/operations/serverVulnerabilityAssessmentOperations.js              
    [npmPack] npm notice 3.0kB   esm/models/serverVulnerabilityAssessmentOperationsMappers.js           
    [npmPack] npm notice 4.1kB   esm/operations/settings.js                                             
    [npmPack] npm notice 2.9kB   esm/models/settingsMappers.js                                          
    [npmPack] npm notice 5.0kB   esm/operations/subAssessments.js                                       
    [npmPack] npm notice 3.0kB   esm/models/subAssessmentsMappers.js                                    
    [npmPack] npm notice 9.7kB   esm/operations/tasks.js                                                
    [npmPack] npm notice 2.9kB   esm/models/tasksMappers.js                                             
    [npmPack] npm notice 4.9kB   esm/operations/topology.js                                             
    [npmPack] npm notice 534B    esm/models/topologyMappers.js                                          

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 9, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 11, 2020
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed off from ARM side.

@PhoenixHe-NV
Copy link
Contributor

@liranc Ready to merge?

@liranc
Copy link
Contributor Author

liranc commented Jun 12, 2020

@liranc Ready to merge?

@nullmdr not quite yet (these changes aren't deployed yet).
Will ping you once we're ready.

Thanks!

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liranc liranc removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 24, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liranc
Copy link
Contributor Author

liranc commented Jun 24, 2020

@NullMDR we're ready now. Could you please merge the PR?

@PhoenixHe-NV PhoenixHe-NV merged commit c8ab856 into Azure:master Jun 28, 2020
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
…stable/2019-08-01 (Azure#9653)

* iotAlertType

* alert type example

* add alertType to readme

* Autorest warnings

* Autorest warnings (2)

* fix description

* iotAlert

* examples

* autorest warnings

* added to readme

* update example

* removed vendor

* fix example types

* Updates

* remove vendor

* fix def reference

* updates

* limit and properties property

* Remove alert type list

* extended properties vs entities

* Description

* entities

* Ran prettier

* format

* Added totalCount, fixed nextLink example

* Update types

* move examples

* List alert types

* example paths

* Update tags

* warnings

* fix example

* prettier

* case sensitive

* Example name

Co-authored-by: Liran Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants