Changes for the new GA api-version (2020-07-31) #9509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix R2016 by making PATCH body properties optional. Suppress the remaining 4 violations that are confirmed as false positives.
…Prop Added dataStringComparisonBehavior parameter to reference data put/update spec
…onKeyProperty Adding partitionKeyProperty to EnvironmentCreate and EnvironmentGet request.
…lingAsString changing modelAsString for partitionKeyPRoperties
…heritance from TrackedResource.
Introduce longterm environment to TSI resource hierarchy
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yeskarthik
changed the title
yeskarthik
changed the title
|
@jhendrixMSFT can you please review it? |
|
@yeskarthik sure I will review shortly. Has this been reviewed by the API review board? |
|
@jhendrixMSFT we are in the process of reviewing with the board, I thought this could go in parallel and I can fix anything if found early on. |
|
@yeskarthik usually the SDK review happens once the board has completed their review and any/all changes they've requested have been made; this way we don't do an SDK review on a moving target. |
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
@jhendrixMSFT we got it approved from the API review board, can you proceed reviewing this PR and merging it? Thanks. |
yeskarthik
changed the title
...esinsights/data-plane/Microsoft.TimeSeriesInsights/stable/2020-07-31/timeseriesinsights.json
Outdated
Show resolved
Hide resolved
...esinsights/data-plane/Microsoft.TimeSeriesInsights/stable/2020-07-31/timeseriesinsights.json
Outdated
Show resolved
Hide resolved
...esinsights/data-plane/Microsoft.TimeSeriesInsights/stable/2020-07-31/timeseriesinsights.json
Outdated
Show resolved
Hide resolved
jhendrixMSFT
requested changes
Jun 26, 2020
|
Officially we plan to release on July 13. The service deployment with these changes are almost complete, most of its already live but not documented. |
…e : _Get to _List.
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jhendrixMSFT
approved these changes
Jun 29, 2020
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* Fix or suppress spec violations Fix R2016 by making PATCH body properties optional. Suppress the remaining 4 violations that are confirmed as false positives. * Try removing 2nd top-level heading, which _may_ have been causing a linter warning. * Fix extra indention which prevented linter from running. * Added dataStringComparisonBehavior parameter to reference data put/update spec. * Fixed grammar. * adding partitionkeyProperty to environmentInfo * changing property name * changing modelAsString * Initial checkin of spec. Unchanged from GA release other than version. * Remove .orig files * Fix validation error by removing IoTHub ES from List ES example response * Add extra example that was missing from preview spec. * Add long-term environment to resource hierarchy, and update examples. * Switch to model-as-string for enums. Restore EnvironmentResource's inheritance from TrackedResource. * Upsate sku description * Add new TSI preview api-version to readme.md. * Add suppressions for false-positive linter failures. * Test suppression failures * Adding preview package tag to several other places in readme.md * Add preview package to the readme.go.md file * Remove invalid required property from EnvironmentCreateOrUpdateParameters * Initial version of data plane swagger spec for PAYG (Preview) SKU. * Added missing Readme.md * Fixed name of readme * Fixed path to swagger json * Attempt to fix readme * Apply suggestions from code review Co-Authored-By: dmdenmsft <[email protected]> * Update timeseriesinsights.json * Update timeseriesinsights.json * Added link to oav issue * Added new GA data plane API version. * Update readme.md * updated readme to contain preview version. * Fix bug in file reference. * Replace Guid with string for hierarchy and type ID (remove uuid restriction) * Fixes as per PR comments. Instances, Types, Heirarchies operation name : _Get to _List. * Fix hierarchies file names. Co-authored-by: Eric Dettinger <[email protected]> Co-authored-by: Ravi Kumar Suresh Babu <[email protected]> Co-authored-by: ravikumarsureshbabu <[email protected]> Co-authored-by: Dmitry Denisov <[email protected]> Co-authored-by: Nick Schonning <[email protected]> Co-authored-by: Ric Serradas <[email protected]> Co-authored-by: Richard Wydrowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.