-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add V2020-02-02-Preview ShortTermRetention API Specification of SQL DB #9407
Add V2020-02-02-Preview ShortTermRetention API Specification of SQL DB #9407
Conversation
…preview to version 2020-02-02-preview
…-02-preview version, copied and edited from 2017-10-01-preview version
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-net - Release
|
azure-sdk-for-trenton
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Can one of the admins verify this patch? |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Pull request contains merge conflicts. |
…https://github.com/lululilliancoding/azure-rest-api-specs into dev/lillian/dev-sql-Microsoft.Sql-2020-02-02-preview
No commit pushedDate could be found for PR 9407 in repo Azure/azure-rest-api-specs |
@xccc-msft Hi Chuang, please start review. |
Azure Pipelines successfully started running 1 pipeline(s). |
@xccc-msft Do you know why the PR is still blocked of merging? What further action can I provide? |
@lululilliancoding ARM review is required. I'm not sure why no update from ARM end... |
@xccc-msft Are you from ARM reviewers group? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delta from 2017-10-01-preview
on this API looks good to me. Signed off from ARM side.
Why the merging is still blocked? |
Only the SDK team has permissions to merge a PR. @xccc-msft is the assigned reviewer from that team and can help with merging. |
Oh I see. @xccc-msft Hi Chuang, could you please merge? Thanks. |
Yes, for quickest response it's best to at the on-call person. |
ACK. Thank you for the info. |
If you are a MSFT employee you can view your work branch via this link.
Contribution checklist:
fix https://github.com/Azure/azure-rest-api-specs-pr/issues/9769