Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SKU name to PrivateCloud for AVS 2019-08-09-preview #9290

Closed
wants to merge 1 commit into from
Closed

add SKU name to PrivateCloud for AVS 2019-08-09-preview #9290

wants to merge 1 commit into from

Conversation

ctaggart
Copy link
Contributor

@ctaggart ctaggart commented Apr 30, 2020 •
edited
Loading

SKU is already supported by the API. This ads it to the spec. This This is already supported by the az vmware extension in Azure/az-vmware-cli#17.

Should I $ref the common type instead, even through only name is supported?
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/common-types/resource-management/v1/types.json#L177-L215

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 30, 2020 •
edited
Loading

azure-sdk-for-net

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 8e80bb9 with merge commit a4fa333ab13ae998093e220a710ac9175ff7c8bd. SDK Automation 13.0.17.20200424.4 
    Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/AzureVMwareSolutionbyVirtustreamAPIClient.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/AzureVMwareSolutionbyVirtustreamAPIClientExtensions.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/ClustersOperations.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/ClustersOperationsExtensions.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/IAzureVMwareSolutionbyVirtustreamAPIClient.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/IClustersOperations.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/IOperations.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/IPrivateCloudsOperations.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/AdminCredentials.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/ApiError.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/ApiErrorBase.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/ApiErrorException.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/Circuit.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/Cluster.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/ClusterProperties.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/ClusterProvisioningState.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/DefaultClusterProperties.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/Endpoints.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/ExpressRouteAuthorization.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/IdentitySource.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/InternetEnum.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/Operation.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/OperationDisplay.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/Page.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/PrivateCloud.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/PrivateCloudProperties.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/PrivateCloudProvisioningState.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/Quota.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/QuotaEnabled.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/Resource.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/Sku.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/SslEnum.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Models/TrackedResource.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/Operations.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/OperationsExtensions.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/PrivateCloudsOperations.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/PrivateCloudsOperationsExtensions.cs
/z/work/azure-sdk-for-net/sdk/VMwareVirtustream/Management.VMwareVirtustream/Generated/SdkInfo_AzureVMwareSolutionbyVirtustreamAPI.cs

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 30, 2020 •
edited
Loading

azure-sdk-for-python

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 8e80bb9 with merge commit a4fa333ab13ae998093e220a710ac9175ff7c8bd. SDK Automation 13.0.17.20200424.4
  • ⚠️azure-mgmt-vmwarevirtustream [Logs]  [Preview SDK Changes] 
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-vmwarevirtustream
[build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-vmwarevirtustream
[build_conf] INFO:packaging_tools:Template done azure-mgmt-vmwarevirtustream
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
Not exact 2 reports found:
code_reports/latest/report.json
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 30, 2020 •
edited
Loading

azure-cli-extensions

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 30, 2020 •
edited
Loading

azure-sdk-for-go

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 30, 2020 •
edited
Loading

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 30, 2020 •
edited
Loading

azure-sdk-for-trenton

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 30, 2020 •
edited
Loading

azure-sdk-for-java

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

This was referenced Apr 30, 2020
Open
Open
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@ctaggart ctaggart closed this May 1, 2020
@ctaggart ctaggart mentioned this pull request May 1, 2020
Merged
5 tasks
@ctaggart ctaggart deleted the 2019-08-09-preview-sku branch October 19, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@allenjzhang allenjzhang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ctaggart @azuresdkci @allenjzhang @cataggar