Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add config for managementgroup #9174

Closed
wants to merge 3 commits into from
Closed

add config for managementgroup #9174

wants to merge 3 commits into from

Conversation

RodgeFu
Copy link
Member

@RodgeFu RodgeFu commented Apr 22, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@RodgeFu RodgeFu requested a review from qiaozha April 22, 2020 08:30
@RodgeFu RodgeFu assigned qiaozha and unassigned erich-wang Apr 22, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 22, 2020 •
edited
Loading

azure-sdk-for-go

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 22, 2020 •
edited
Loading

azure-cli-extensions

❌ failed [Logs] [Expand Details]
  • ❌ Generate from 3210edf with merge commit 1a4f3a28fa99d34c45826e3b83fa353cac71421f. SDK Automation 13.0.17.20200416.2 
    [AutoRest] 
[AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
[AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
[AutoRest] --------------------------------------------------------
[AutoRest]   test-scenario:
[AutoRest]     - name: /Entities/post/GetEntities
[AutoRest]     - name: /HierarchySettings/put/GetGroupSettings
[AutoRest]     - name: /HierarchySettings/get/GetGroupSettings
[AutoRest]     - name: /HierarchySettings/get/ListGroupSettings
[AutoRest]     - name: /HierarchySettings/patch/GetGroupSettings
[AutoRest]     - name: /ManagementGroupSubscriptions/put/AddSubscriptionToManagementGroup
[AutoRest]     - name: /ManagementGroups/put/PutManagementGroup
[AutoRest]     - name: /ManagementGroups/get/GetDescendants
[AutoRest]     - name: /ManagementGroups/get/GetManagementGroup
[AutoRest]     - name: /ManagementGroups/get/GetManagementGroupWithExpand
[AutoRest]     - name: /ManagementGroups/get/GetManagementGroupsWithExpandAndRecurse
[AutoRest]     - name: /ManagementGroups/get/ListManagementGroups
[AutoRest]     - name: /ManagementGroups/patch/PatchManagementGroup
[AutoRest]     - name: /managementgroup /post/StartTenantBackfill
[AutoRest]     - name: /managementgroup /post/TenantBackfillStatus
[AutoRest]     - name: /HierarchySettings/delete/GetGroupSettings
[AutoRest]     - name: /ManagementGroupSubscriptions/delete/DeleteSubscriptionFromManagementGroup
[AutoRest]     - name: /ManagementGroups/delete/DeleteManagementGroup
[AutoRest] --------------------------------------------------------
[AutoRest] ERROR: [main.Process:51] Python generator raised an exception
[AutoRest] Traceback (most recent call last):
[AutoRest]   File "/root/.autorest/@[email protected]/node_modules/@autorest/python/autorest/jsonrpc/server.py", line 49, in Process
[AutoRest]     return plugin.process()
[AutoRest]   File "/root/.autorest/@[email protected]/node_modules/@autorest/python/autorest/codegen/init.py", line 177, in process
[AutoRest]     options = self._build_code_model_options()
[AutoRest]   File "/root/.autorest/@[email protected]/node_modules/@autorest/python/autorest/codegen/init.py", line 157, in _build_code_model_options
[AutoRest]     raise ValueError("--basic-setup-py must be used with --package-version")
[AutoRest] ValueError: --basic-setup-py must be used with --package-version
[AutoRest]   Error: Plugin codegen reported failure.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/z/work/azure-cli-extensions /z/work/azure-rest-api-specs/specification/managementgroups/resource-manager/readme.md 
NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
--------------------------------------------------------
  test-scenario:
    - name: /Entities/post/GetEntities
    - name: /HierarchySettings/put/GetGroupSettings
    - name: /HierarchySettings/get/GetGroupSettings
    - name: /HierarchySettings/get/ListGroupSettings
    - name: /HierarchySettings/patch/GetGroupSettings
    - name: /ManagementGroupSubscriptions/put/AddSubscriptionToManagementGroup
    - name: /ManagementGroups/put/PutManagementGroup
    - name: /ManagementGroups/get/GetDescendants
    - name: /ManagementGroups/get/GetManagementGroup
    - name: /ManagementGroups/get/GetManagementGroupWithExpand
    - name: /ManagementGroups/get/GetManagementGroupsWithExpandAndRecurse
    - name: /ManagementGroups/get/ListManagementGroups
    - name: /ManagementGroups/patch/PatchManagementGroup
    - name: /managementgroup /post/StartTenantBackfill
    - name: /managementgroup /post/TenantBackfillStatus
    - name: /HierarchySettings/delete/GetGroupSettings
    - name: /ManagementGroupSubscriptions/delete/DeleteSubscriptionFromManagementGroup
    - name: /ManagementGroups/delete/DeleteManagementGroup
--------------------------------------------------------
ERROR: [main.Process:51] Python generator raised an exception
Traceback (most recent call last):
  File "/root/.autorest/@[email protected]/node_modules/@autorest/python/autorest/jsonrpc/server.py", line 49, in Process
    return plugin.process()
  File "/root/.autorest/@[email protected]/node_modules/@autorest/python/autorest/codegen/init.py", line 177, in process
    options = self._build_code_model_options()
  File "/root/.autorest/@[email protected]/node_modules/@autorest/python/autorest/codegen/init.py", line 157, in _build_code_model_options
    raise ValueError("--basic-setup-py must be used with --package-version")
ValueError: --basic-setup-py must be used with --package-version
  Error: Plugin codegen reported failure.
, {}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 22, 2020 •
edited
Loading

azure-sdk-for-java

❌ failed [Logs] [Expand Details]
  • ❌ Generate from 3210edf with merge commit 1a4f3a28fa99d34c45826e3b83fa353cac71421f. SDK Automation 13.0.17.20200416.2 
    [AutoRest] FATAL: System.Exception: Duplicate File Generation: src/main/java/com/microsoft/azure/management/managementgroups/v2020_02_01/HierarchySettings.java
[AutoRest]    at AutoRest.Core.CodeGenerator.d__13.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 151
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Core.CodeGenerator.d__12.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 121
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Java.Azure.Fluent.CodeGeneratorJvaf.d__6.MoveNext() in /home/vsts/work/1/s/src/azurefluent/CodeGeneratorJvaf.cs:line 106
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Java.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 114
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
[AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
[AutoRest] FATAL: java/generate - FAILED
[AutoRest] FATAL: Error: Plugin java reported failure.
[AutoRest] Failure during batch task - {"tag":"package-2020-02"} -- Error: Plugin java reported failure..
[AutoRest]   Error: Plugin java reported failure.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --version=V2 --java --verbose --multiapi [email protected]/autorest.java@preview --azure-libraries-for-java-folder=/z/work/azure-sdk-for-java /z/work/azure-rest-api-specs/specification/managementgroups/resource-manager/readme.md FATAL: System.Exception: Duplicate File Generation: src/main/java/com/microsoft/azure/management/managementgroups/v2020_02_01/HierarchySettings.java
   at AutoRest.Core.CodeGenerator.d__13.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 151
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Core.CodeGenerator.d__12.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 121
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Azure.Fluent.CodeGeneratorJvaf.d__6.MoveNext() in /home/vsts/work/1/s/src/azurefluent/CodeGeneratorJvaf.cs:line 106
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 114
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: java/generate - FAILED
FATAL: Error: Plugin java reported failure.
Failure during batch task - {"tag":"package-2020-02"} -- Error: Plugin java reported failure..
  Error: Plugin java reported failure.
, {}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 22, 2020 •
edited
Loading

azure-sdk-for-js

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 3210edf with merge commit 1a4f3a28fa99d34c45826e3b83fa353cac71421f. SDK Automation 13.0.17.20200416.2
  • ⚠️@azure/arm-managementgroups [Logs]  
      No file is changed.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Apr 22, 2020 •
    edited
    Loading

    azure-sdk-for-python

    - Breaking Change detected in SDK

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 3210edf with merge commit 1a4f3a28fa99d34c45826e3b83fa353cac71421f. SDK Automation 13.0.17.20200416.2
    • ⚠️azure-mgmt-managementgroups [Logs]  [Preview SDK Changes] Breaking Change Detected
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-managementgroups
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-managementgroups
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 35.204% size of original (original: 19620 chars, delta: 6907 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog] - Model OperationResults has a new parameter display_name
[ChangeLog] - Model OperationResults has a new parameter tenant_id
[ChangeLog] - Model ManagementGroup has a new parameter path
[ChangeLog] - Added operation ManagementGroupsOperations.get_descendants
[ChangeLog] - Added operation group HierarchySettingsOperations
[ChangeLog] - Added operation group ManagementGroupsAPIOperationsMixin
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog] - Operation ManagementGroupsOperations.list has a new signature
[ChangeLog] - Model OperationResults no longer has parameter provisioning_state
[ChangeLog] - Operation EntitiesOperations.list has a new signature

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Apr 22, 2020 •
    edited
    Loading

    azure-sdk-for-trenton

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Apr 22, 2020 •
    edited
    Loading

    azure-sdk-for-net

    ️✔️ succeeded [Logs] [Expand Details]

    This was referenced Apr 22, 2020
    Open
    Open
    Open
    @qiaozha
    Copy link
    Member

    qiaozha commented Apr 22, 2020

    it already has python config in readme.md https://github.com/Azure/azure-rest-api-specs/blob/master/specification/managementgroups/resource-manager/readme.md#python

    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @RodgeFu RodgeFu closed this Jun 29, 2020
    @JackTn
    Copy link
    Member

    JackTn commented Aug 23, 2021

    Hi, @RodgeFu. The PR has be closed for a long time and it's related branch still exist. If no further used for over 14 days, I will delete this related branch. Please tell me if you still need this branch.

    @JackTn
    Copy link
    Member

    JackTn commented Jun 16, 2022

    Hi, @RodgeFu. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

    2 similar comments
    @JackTn
    Copy link
    Member

    JackTn commented Jun 16, 2022

    Hi, @RodgeFu. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

    @JackTn
    Copy link
    Member

    JackTn commented Jun 16, 2022

    Hi, @RodgeFu. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

    @JackTn JackTn deleted the add-config-mg branch July 5, 2022 01:18
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

    Assignees

    @qiaozha qiaozha

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @RodgeFu @qiaozha @azuresdkci @JackTn @erich-wang