Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lastEnabledTime in GetBlobServiceProperties API and minor descrip… #8920

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Conversation

xmbms
Copy link
Contributor

@xmbms xmbms commented Apr 2, 2020

…tion update for restoreblobrange

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 2, 2020

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 2, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 2, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 2, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 2f65f92 with merge commit 7586a48. SDK Automation 13.0.17.20200326.3
  • ⚠️preview/storage/mgmt/2015-05-01-preview [Logs
      No file is changed.
    • ⚠️preview/storage/mgmt/2018-03-01-preview [Logs
        No file is changed.
      • ⚠️storage/mgmt/2015-06-15 [Logs
          No file is changed.
        • ⚠️storage/mgmt/2016-01-01 [Logs
            No file is changed.
          • ⚠️storage/mgmt/2016-05-01 [Logs
              No file is changed.
            • ⚠️storage/mgmt/2016-12-01 [Logs
                No file is changed.
              • ⚠️storage/mgmt/2017-06-01 [Logs
                  No file is changed.
                • ⚠️storage/mgmt/2017-10-01 [Logs
                    No file is changed.
                  • ⚠️storage/mgmt/2018-02-01 [Logs
                      No file is changed.
                    • ⚠️storage/mgmt/2018-07-01 [Logs
                        No file is changed.
                      • ⚠️storage/mgmt/2018-11-01 [Logs
                          No file is changed.
                        • ⚠️storage/mgmt/2019-04-01 [Logs
                            No file is changed.
                          • ️✔️storage/mgmt/2019-06-01 [Logs]  [Release SDK Changes]

                          @openapi-sdkautomation
                          Copy link

                          openapi-sdkautomation bot commented Apr 2, 2020

                          azure-sdk-for-js - Release

                          ️✔️ succeeded [Logs] [Expand Details]

                          @openapi-sdkautomation
                          Copy link

                          openapi-sdkautomation bot commented Apr 2, 2020

                          azure-sdk-for-python - Release

                          ️✔️ succeeded [Logs] [Expand Details]
                          • ️✔️ Generate from 2f65f92 with merge commit 7586a48. SDK Automation 13.0.17.20200326.3
                          • ️✔️azure-mgmt-storage [Logs]  [Release SDK Changes]
                            [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-07-01', '2018-03-01-preview'} in label v2018_07_01
                            [after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
                            [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                            [build_package]   warnings.warn(msg)
                            [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                            [build_package]   warnings.warn(msg)
                            [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
                            [breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
                            [breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
                            [ChangeLog] Size of delta 0.249% size of original (original: 71216 chars, delta: 177 chars)
                            [ChangeLog] **Features**
                            [ChangeLog] 
                            [ChangeLog]   - Model RestorePolicyProperties has a new parameter last_enabled_time

                          This was referenced Apr 2, 2020
                          @azuresdkci
                          Copy link
                          Contributor

                          Can one of the admins verify this patch?

                          Copy link
                          Member

                          @majastrz majastrz left a comment

                          Choose a reason for hiding this comment

                          The reason will be displayed to describe this comment to others. Learn more.

                          Signed off from ARM side.

                          @majastrz
                          Copy link
                          Member

                          majastrz commented Apr 2, 2020

                          I'm not able to put the ARMSignedOff label on this PR for some reason. I should have permissions, but GitHub is having some problems with 500s being returned for certain operations. I suspect that's the cause. Please ping me later to try adding the label again.

                          @majastrz majastrz added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 2, 2020
                          @qianwens qianwens merged commit 7586a48 into Azure:master Apr 3, 2020
                          00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
                          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
                          Labels
                          ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
                          Projects
                          None yet
                          Development

                          Successfully merging this pull request may close these issues.

                          4 participants