Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Stack] Updates to User-Subscriptions Spec #8914

Merged
merged 5 commits into from
Aug 13, 2020
Merged

[Azure Stack] Updates to User-Subscriptions Spec #8914

merged 5 commits into from
Aug 13, 2020

Conversation

viananth
Copy link
Member

@viananth viananth commented Apr 1, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

viananth added 2 commits March 31, 2020 12:03
@viananth
commit 4691c2a
e86758c 
Author: Rakesh Kumar <[email protected]>
Date:   Wed Jan 29 17:46:01 2020 -0800

    [AzureStack] User Subscription: rename NewSubscription to SubscriptionDefinition (Azure#8257)

commit 9e551f0
Author: bganapa <[email protected]>
Date:   Tue Nov 12 11:44:22 2019 -0800

    Reset to Stackadmin2 (Azure#7766)
@viananth
Fix sub def in example
626b9a2
@viananth viananth requested a review from bganapa April 1, 2020 18:38
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 1, 2020 •
edited
Loading

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 1, 2020 •
edited
Loading

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 1, 2020 •
edited
Loading

azure-cli-extensions

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 1, 2020 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 1, 2020 •
edited
Loading

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 1, 2020 •
edited
Loading

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@njuCZ
Copy link
Contributor

njuCZ commented Apr 2, 2020

@viananth please fix the CI error

@viananth
Copy link
Member Author

viananth commented Apr 6, 2020

@viananth please fix the CI error

@njuCZ CI is reporting this as an error, but there are no errors in example validation:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=340779&view=logs&j=8d2f9c49-cd83-5a9d-f3fe-2fd651afa742&t=43324f1f-6724-5d61-785f-f0ac9fd256a1&l=28

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@viananth
Copy link
Member Author

@njuCZ I reviewed the breaking changes and they are expected. Could you please take a look and let me know if you have any feedback?

@viananth
Copy link
Member Author

@njuCZ could you pls approve this PR if it looks good to you? @bganapa as FYI

@njuCZ
Copy link
Contributor

njuCZ commented Jul 7, 2020

@viananth Sorry for missing this thread. According to our latest policy: Per Retirement of Preview guidance, products in Preview for over one year need to move to GA or retire; require CVP exemption after 1 year in preview

@viananth
Copy link
Member Author

viananth commented Jul 7, 2020

@bganapa FYI

@bganapa
Copy link
Member

bganapa commented Aug 6, 2020

@njuCZ This is another Azure Stack Admin API swagger spec where we are planning to move all our specs to stable in Fe timeframe. Could you please approve this PR and proceed to merge. Thank you!

@njuCZ njuCZ added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed BreakingChangeReviewRequired labels Aug 7, 2020
@njuCZ
Copy link
Contributor

njuCZ commented Aug 7, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 7, 2020 •
edited
Loading

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 7, 2020 •
edited
Loading

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 7, 2020 •
edited
Loading

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@viananth
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 11, 2020 •
edited
Loading

[Staging] Swagger Validation Report

️❌BreakingChange: 3 Errors, 0 Warnings [Detail] [Expand]
Rule Message
❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'NewSubscriptionParameter' removed or renamed?
New: Microsoft.Subscriptions/preview/2015-11-01/Subscriptions.json#L249:3
Old: Microsoft.Subscriptions/preview/2015-11-01/Subscriptions.json#L249:3
❌ 1009 - RemovedRequiredParameter The required parameter 'newSubscription' was removed in the new version.
Old: Microsoft.Subscriptions/preview/2015-11-01/Subscriptions.json#L89:9
❌ 1010 - AddingRequiredParameter The required parameter 'subscriptionDefinition' was added in the new version.
New: Microsoft.Subscriptions/preview/2015-11-01/Subscriptions.json#L89:9
️️✔️LintDiff [Detail] 
 Validation passes for LintDiff.
️️✔️Avocado [Detail] 
 Validation passes for Avocado.
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@njuCZ njuCZ merged commit 1b430eb into Azure:master Aug 13, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020 •
edited
Loading

azure-resource-manager-schemas - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

innosam pushed a commit to innosam/azure-rest-api-specs that referenced this pull request Aug 17, 2020
@viananth @innosam
[Azure Stack] Updates to User-Subscriptions Spec (Azure#8914)
4a9731b 
* commit 4691c2a
Author: Rakesh Kumar <[email protected]>
Date:   Wed Jan 29 17:46:01 2020 -0800

    [AzureStack] User Subscription: rename NewSubscription to SubscriptionDefinition (Azure#8257)

commit 9e551f0
Author: bganapa <[email protected]>
Date:   Tue Nov 12 11:44:22 2019 -0800

    Reset to Stackadmin2 (Azure#7766)

* Fix sub def in example

* Address PR comments

* Fix model validation error

* Fix prettier issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bganapa bganapa bganapa approved these changes

@njuCZ njuCZ njuCZ approved these changes

Assignees

@njuCZ njuCZ

Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viananth @azuresdkci @njuCZ @bganapa