Azure Spring Cloud: Add location to Apps #8851

xgugeng · 2020-03-27T08:55:10Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-03-27T08:55:26Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-27T09:05:58Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-03-27T09:06:05Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-03-27T09:16:20Z

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-03-27T09:16:26Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 9d0c0de with merge commit 3a9aa50. SDK Automation 13.0.17.20200326.3
️✔️preview/appplatform/mgmt/2019-05-01-preview [Logs] [Release SDK Changes]
- preview.appplatform.mgmt.2019-05-01-preview.zip

openapi-sdkautomation · 2020-03-27T09:16:35Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 9d0c0de with merge commit 3a9aa50. SDK Automation 13.0.17.20200326.3
️✔️sdk/appplatform/mgmt-v2019_05_01_preview [Logs] [Release SDK Changes]

openapi-sdkautomation · 2020-03-27T09:16:46Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 9d0c0de with merge commit 3a9aa50. SDK Automation 13.0.17.20200326.3

️✔️@azure/arm-appplatform [Logs] [Release SDK Changes]

azure-arm-appplatform-1.0.0.tgz

[npmPack] npm WARN lifecycle @azure/[email protected]~prepack: cannot run in wd @azure/[email protected] npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/appplatform/arm-appplatform)

openapi-sdkautomation · 2020-03-27T09:16:55Z

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 9d0c0de with merge commit 3a9aa50. SDK Automation 13.0.17.20200326.3

⚠️azure-mgmt-appplatform [Logs] [Release SDK Changes] Breaking Change Detected

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 1.106% size of original (original: 30108 chars, delta: 333 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model AppResource has a new parameter location
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog]   - Operation AppsOperations.create_or_update has a new signature
[ChangeLog]   - Operation AppsOperations.update has a new signature

openapi-sdkautomation · 2020-03-27T09:16:57Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 9d0c0de with merge commit 3a9aa50. SDK Automation 13.0.17.20200326.3
️✔️Microsoft.Azure.Management.AppPlatform [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.AppPlatform.0.1.0-preview.nupkg
- Microsoft.Azure.Management.AppPlatform.0.1.0-preview.snupkg

majastrz · 2020-03-30T22:31:19Z

...pplatform/resource-manager/Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json

@@ -2043,6 +2043,10 @@
          "$ref": "#/definitions/AppResourceProperties",
          "description": "Properties of the App resource",
          "x-ms-client-flatten": false
+        },
+        "location": {


location [](start = 9, length = 8)

Please mark as read-only if it's inherited from parent resource.

location is needed in user request (PUT/PATCH). I just found making it read-only removes this property from http request in the SDK generated. It might not be a read-only case in this scenario?

If user puts a location different from parent resource deliberately, a 404 error will be returned due to the uniqueness of parent resource cross all regions

Your create and update examples don't have location in request body. If it's required then it should be marked required in the swagger and in those examples.

The experience around this is kind of weird. We know what the only valid location is and we're going to make the user put it in the request anyway, but if they get it wrong we will reject the request. Why do we make them specify the location at all?

In reply to: 401348345 [](ancestors = 401348345)

Updated the create and update examples. Actually the location is required only when enabling/disabling MSI via PUT/PATCH, so ARM can figure out which regional MSI RP it should call. Otherwise, it's optional.

azure-pipelines · 2020-03-31T02:22:39Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-31T02:27:33Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-31T03:10:55Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-04-02T01:39:57Z

Azure Pipelines successfully started running 1 pipeline(s).

majastrz

Signing off from ARM side.

* Azure Spring Cloud: Add location to Apps * make location read-only for Apps * revert: make location read-only for Apps * put location in PUT/PATCH request examples Co-authored-by: Guoqing Geng <[email protected]>

Azure Spring Cloud: Add location to Apps

e356f4b

openapi-assignment-bot bot assigned erich-wang Mar 27, 2020

xgugeng closed this Mar 27, 2020

xgugeng reopened this Mar 27, 2020

erich-wang approved these changes Mar 27, 2020

View reviewed changes

erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 27, 2020

majastrz reviewed Mar 30, 2020

View reviewed changes

majastrz added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 30, 2020

xgugeng mentioned this pull request Mar 31, 2020

spring-cloud: add location to Apps operation Azure/azure-cli-extensions#1458

Merged

3 tasks

make location read-only for Apps

ca9d0e6

Merge remote-tracking branch 'azure/master' into hkn/spring-app-location

337e38d

revert: make location read-only for Apps

26d8131

put location in PUT/PATCH request examples

9d0c0de

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Apr 2, 2020

majastrz approved these changes Apr 2, 2020

View reviewed changes

erich-wang added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 2, 2020

akning-ms merged commit 3a9aa50 into Azure:master Apr 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Azure Spring Cloud: Add location to Apps #8851

Azure Spring Cloud: Add location to Apps #8851

xgugeng commented Mar 27, 2020 •

edited

Loading

azure-pipelines bot commented Mar 27, 2020

azure-pipelines bot commented Mar 27, 2020

azuresdkci commented Mar 27, 2020

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

majastrz Mar 30, 2020

xgugeng Mar 31, 2020 •

edited

Loading

xgugeng Apr 1, 2020 •

edited

Loading

majastrz Apr 1, 2020

xgugeng Apr 2, 2020

azure-pipelines bot commented Mar 31, 2020

azure-pipelines bot commented Mar 31, 2020

azure-pipelines bot commented Mar 31, 2020

azure-pipelines bot commented Apr 2, 2020

majastrz left a comment

Azure Spring Cloud: Add location to Apps #8851

Azure Spring Cloud: Add location to Apps #8851

Conversation

xgugeng commented Mar 27, 2020 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Mar 27, 2020

azure-pipelines bot commented Mar 27, 2020

azuresdkci commented Mar 27, 2020

openapi-sdkautomation bot commented Mar 27, 2020 • edited Loading

azure-cli-extensions - Release

openapi-sdkautomation bot commented Mar 27, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Mar 27, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Mar 27, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Mar 27, 2020 • edited Loading

azure-sdk-for-python - Release

- Breaking Change detected in SDK

openapi-sdkautomation bot commented Mar 27, 2020 • edited Loading

azure-sdk-for-net - Release

majastrz Mar 30, 2020

Choose a reason for hiding this comment

xgugeng Mar 31, 2020 • edited Loading

Choose a reason for hiding this comment

xgugeng Apr 1, 2020 • edited Loading

Choose a reason for hiding this comment

majastrz Apr 1, 2020

Choose a reason for hiding this comment

xgugeng Apr 2, 2020

Choose a reason for hiding this comment

azure-pipelines bot commented Mar 31, 2020

azure-pipelines bot commented Mar 31, 2020

azure-pipelines bot commented Mar 31, 2020

azure-pipelines bot commented Apr 2, 2020

majastrz left a comment

Choose a reason for hiding this comment

xgugeng commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

xgugeng Mar 31, 2020 •

edited

Loading

xgugeng Apr 1, 2020 •

edited

Loading