Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ErrorSchema to ErrorResponse. Rename Error to ErrorResponseBod… #8827

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Rename ErrorSchema to ErrorResponse. Rename Error to ErrorResponseBod… #8827

merged 1 commit into from
Mar 25, 2020

Conversation

huanwu
Copy link
Contributor

@huanwu huanwu commented Mar 24, 2020

…y. Rename Status to ConnectionStatus.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@huanwu huanwu requested a review from northtyphoon March 24, 2020 21:52
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 24, 2020 •
edited
Loading

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 80e57db with merge commit 3151125. SDK Automation 13.0.17.20200320.2
  • ⚠️containerregistry/mgmt/2017-03-01 [Logs]  
      No file is changed.
    • ⚠️containerregistry/mgmt/2017-10-01 [Logs]  
        No file is changed.
      • ⚠️containerregistry/mgmt/2018-09-01 [Logs]  
          No file is changed.
        • ⚠️containerregistry/mgmt/2019-04-01 [Logs]  
            No file is changed.
          • ⚠️containerregistry/mgmt/2019-05-01-preview [Logs]  
              No file is changed.
            • ⚠️containerregistry/mgmt/2019-05-01 [Logs]  
                No file is changed.
              • ️✔️containerregistry/mgmt/2019-06-01-preview [Logs]  [Release SDK Changes]
              • ⚠️preview/containerregistry/mgmt/2016-06-27-preview [Logs]  
                  No file is changed.
                • ⚠️preview/containerregistry/mgmt/2017-06-01-preview [Logs]  
                    No file is changed.
                  • ⚠️preview/containerregistry/mgmt/2018-02-01 [Logs]  
                      No file is changed.
                    • ️✔️preview/containerregistry/mgmt/2019-12-01-preview [Logs]  [Release SDK Changes]

                    @openapi-sdkautomation
                    Copy link

                    openapi-sdkautomation bot commented Mar 24, 2020 •
                    edited
                    Loading

                    azure-cli-extensions - Release

                    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

                    northtyphoon
                    northtyphoon approved these changes Mar 24, 2020
                    View reviewed changes
                    Copy link
                    Member

                    @northtyphoon northtyphoon left a comment

                    Choose a reason for hiding this comment

                    The reason will be displayed to describe this comment to others. Learn more.

                    LGTM

                    @openapi-sdkautomation
                    Copy link

                    openapi-sdkautomation bot commented Mar 24, 2020 •
                    edited
                    Loading

                    azure-sdk-for-python - Release

                    - Breaking Change detected in SDK

                    ⚠️ warning [Logs] [Expand Details]
                    • ⚠️ Generate from 80e57db with merge commit 3151125. SDK Automation 13.0.17.20200320.2
                    • ⚠️azure-mgmt-containerregistry [Logs]  [Release SDK Changes] Breaking Change Detected
                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-02-01-preview', '2017-10-01'} in label v2018_02_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2018-02-01-preview based on label v2018_02_01_preview
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-09-01'} in label v2018_09_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-09-01 based on label v2018_09_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2017-10-01'} in label v2019_04_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-04-01 based on label v2019_04_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2019-05-01'} in label v2019_05_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01 based on label v2019_05_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-05-01-preview'} in label v2019_05_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01-preview based on label v2019_05_01_preview
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01-preview', '2019-05-01', '2019-05-01-preview'} in label v2019_06_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2019-06-01-preview based on label v2019_06_01_preview
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01-preview', '2019-12-01-preview', '2019-05-01-preview'} in label v2019_12_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2019-12-01-preview based on label v2019_12_01_preview
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 1.388% size of original (original: 107366 chars, delta: 1490 chars)
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog]   - Operation PrivateEndpointConnectionsOperations.create_or_update has a new signature
[ChangeLog]   - Operation PrivateEndpointConnectionsOperations.create_or_update has a new signature

                    @openapi-sdkautomation
                    Copy link

                    openapi-sdkautomation bot commented Mar 24, 2020 •
                    edited
                    Loading

                    azure-sdk-for-js - Release

                    ️✔️ succeeded [Logs] [Expand Details]

                    @openapi-sdkautomation
                    Copy link

                    openapi-sdkautomation bot commented Mar 24, 2020 •
                    edited
                    Loading

                    azure-sdk-for-net - Release

                    ️✔️ succeeded [Logs] [Expand Details]

                    @huanwu huanwu requested review from northtyphoon and djyou March 24, 2020 21:53
                    @azuresdkci
                    Copy link
                    Contributor

                    Can one of the admins verify this patch?

                    This was referenced Mar 24, 2020
                    Closed
                    Closed
                    @openapi-sdkautomation
                    Copy link

                    openapi-sdkautomation bot commented Mar 24, 2020 •
                    edited
                    Loading

                    azure-sdk-for-java - Release

                    ️✔️ succeeded [Logs] [Expand Details]

                    This was referenced Mar 24, 2020
                    Closed
                    Closed
                    Closed
                    Closed
                    Closed
                    Closed
                    Closed
                    Closed
                    Closed
                    Closed
                    northtyphoon
                    northtyphoon approved these changes Mar 24, 2020
                    View reviewed changes
                    Copy link
                    Member

                    @northtyphoon northtyphoon left a comment

                    Choose a reason for hiding this comment

                    The reason will be displayed to describe this comment to others. Learn more.

                    LGTM

                    @yungezz yungezz merged commit 3151125 into Azure:master Mar 25, 2020
                    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
                    @huanwu @00Kai0
                    Rename ErrorSchema to ErrorResponse. Rename Error to ErrorResponseBod…
                    fcd2d21 
                    …y. Rename Status to ConnectionStatus. (Azure#8827)
                    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
                    Reviewers

                    @yungezz yungezz yungezz approved these changes

                    @northtyphoon northtyphoon northtyphoon approved these changes

                    @djyou djyou Awaiting requested review from djyou

                    Assignees

                    @fengzhou-msft fengzhou-msft

                    Labels
                    None yet
                    Projects
                    None yet
                    Milestone
                    No milestone
                    Development

                    Successfully merging this pull request may close these issues.
                    5 participants
                    @huanwu @azuresdkci @northtyphoon @yungezz @fengzhou-msft