-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Security to add version stable/2020-01-01 #8805
Merged
akning-ms
merged 13 commits into
Azure:master
from
nitsi:dev-security-Microsoft.Security-2020-01-01-alerts
Aug 31, 2020
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b504a0d
Adding new stable alerts API version 2020-01-01.
278b583
Fixing: https://github.com/Azure/oav/blob/master/documentation/oav-er…
1f1c4b7
Ran prettier-fix
4800910
Changing "severity" enum name so it won't conflict with assessmentMet…
723d4ec
Changing "status" enum name to "alertStatus" so it won't conflict wit…
d89144d
Microsoft Security 2020-01-01/alerts.json Change reactivate to activate
6bbca52
Update readme.md
yibirnba afbd468
remove additional properties
yibirnba 97e020b
update readme
yibirnba d7217a3
Merge branch 'master' into dev-security-Microsoft.Security-2020-01-01…
yibirnba 0fd3252
CR fixes
yibirnba ce0fc92
Change description of ResourceIdentifiers property
yibirnba eae295a
remove OData support
yibirnba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
966 changes: 966 additions & 0 deletions
966
specification/security/resource-manager/Microsoft.Security/stable/2020-01-01/alerts.json
Large diffs are not rendered by default.
Oops, something went wrong.
79 changes: 79 additions & 0 deletions
79
...oft.Security/stable/2020-01-01/examples/Alerts/GetAlertResourceGroupLocation_example.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2020-01-01", | ||
| "subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23", | ||
| "resourceGroupName": "myRg1", | ||
| "ascLocation": "westeurope", | ||
| "alertName": "2518298467986649999_4d25bfef-2d77-4a08-adc0-3e35715cc92a" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/resourceGroups/myRg1/providers/Microsoft.Security/locations/westeurope/alerts/2518770965529163669_F144EE95-A3E5-42DA-A279-967D115809AA", | ||
| "name": "2518298467986649999_4d25bfef-2d77-4a08-adc0-3e35715cc92a", | ||
| "type": "Microsoft.Security/Locations/alerts", | ||
| "properties": { | ||
| "alertType": "VM_EICAR", | ||
| "systemAlertId": "2518298467986649999_4d25bfef-2d77-4a08-adc0-3e35715cc92a", | ||
| "productComponentName": "", | ||
| "alertDisplayName": "Azure Security Center test alert (not a threat)", | ||
| "description": "This is a test alert generated by Azure Security Center. No further action is needed.", | ||
| "severity": "High", | ||
| "intent": "Execution", | ||
| "startTimeUtc": "2020-02-22T00:00:00.0000000Z", | ||
| "endTimeUtc": "2020-02-22T00:00:00.0000000Z", | ||
| "resourceIdentifiers": [ | ||
| { | ||
| "azureResourceId": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/resourceGroups/myRg1/providers/Microsoft.Compute/virtualMachines/vm1", | ||
| "type": "AzureResource" | ||
| }, | ||
| { | ||
| "workspaceId": "f419f624-acad-4d89-b86d-f62fa387f019", | ||
| "workspaceSubscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23", | ||
| "workspaceResourceGroup": "myRg1", | ||
| "agentId": "75724a01-f021-4aa8-9ec2-329792373e6e", | ||
| "type": "LogAnalytics" | ||
| } | ||
| ], | ||
| "remediationSteps": [ | ||
| "No further action is needed." | ||
| ], | ||
| "vendorName": "Microsoft", | ||
| "status": "New", | ||
| "extendedLinks": [ | ||
| { | ||
| "Category": "threat_reports", | ||
| "Label": "Report: RDP Brute Forcing", | ||
| "Href": "https://contoso.com/reports/DisplayReport", | ||
| "Type": "webLink" | ||
| } | ||
| ], | ||
| "alertUri": "https://portal.azure.com/#blade/Microsoft_Azure_Security/AlertBlade/alertId/2518298467986649999_4d25bfef-2d77-4a08-adc0-3e35715cc92a/subscriptionId/20ff7fc3-e762-44dd-bd96-b71116dcdc23/resourceGroup/myRg1/referencedFrom/alertDeepLink/location/westeurope", | ||
| "timeGeneratedUtc": "2020-02-23T13:47:58.0000000Z", | ||
| "productName": "Azure Security Center", | ||
| "processingEndTimeUtc": "2020-02-23T13:47:58.9205584Z", | ||
| "entities": [ | ||
| { | ||
| "address": "192.0.2.1", | ||
| "location": { | ||
| "countryCode": "gb", | ||
| "state": "wokingham", | ||
| "city": "sonning", | ||
| "longitude": -0.909, | ||
| "latitude": 51.468, | ||
| "asn": 6584 | ||
| }, | ||
| "type": "ip" | ||
| } | ||
| ], | ||
| "isIncident": true, | ||
| "correlationKey": "kso0LFWxzCll5tqrk5hmrBJ+MY1BX806W6q6+0s9Lk=", | ||
| "extendedProperties": { | ||
| "Property1": "Property1 information" | ||
| }, | ||
| "compromisedEntity": "vm1" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
78 changes: 78 additions & 0 deletions
78
...soft.Security/stable/2020-01-01/examples/Alerts/GetAlertSubscriptionLocation_example.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2020-01-01", | ||
| "subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23", | ||
| "ascLocation": "westeurope", | ||
| "alertName": "2518770965529163669_F144EE95-A3E5-42DA-A279-967D115809AA" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/resourceGroups/myRg1/providers/Microsoft.Security/locations/westeurope/alerts/2518770965529163669_F144EE95-A3E5-42DA-A279-967D115809AA", | ||
| "name": "2518298467986649999_4d25bfef-2d77-4a08-adc0-3e35715cc92a", | ||
| "type": "Microsoft.Security/Locations/alerts", | ||
| "properties": { | ||
| "alertType": "VM_EICAR", | ||
| "systemAlertId": "2518298467986649999_4d25bfef-2d77-4a08-adc0-3e35715cc92a", | ||
| "productComponentName": "", | ||
| "alertDisplayName": "Azure Security Center test alert (not a threat)", | ||
| "description": "This is a test alert generated by Azure Security Center. No further action is needed.", | ||
| "severity": "High", | ||
| "intent": "Execution", | ||
| "startTimeUtc": "2020-02-22T00:00:00.0000000Z", | ||
| "endTimeUtc": "2020-02-22T00:00:00.0000000Z", | ||
| "resourceIdentifiers": [ | ||
| { | ||
| "azureResourceId": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/resourceGroups/myRg1/providers/Microsoft.Compute/virtualMachines/vm1", | ||
| "type": "AzureResource" | ||
| }, | ||
| { | ||
| "workspaceId": "f419f624-acad-4d89-b86d-f62fa387f019", | ||
| "workspaceSubscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23", | ||
| "workspaceResourceGroup": "myRg1", | ||
| "agentId": "75724a01-f021-4aa8-9ec2-329792373e6e", | ||
| "type": "LogAnalytics" | ||
| } | ||
| ], | ||
| "remediationSteps": [ | ||
| "No further action is needed." | ||
| ], | ||
| "vendorName": "Microsoft", | ||
| "status": "New", | ||
| "extendedLinks": [ | ||
| { | ||
| "Category": "threat_reports", | ||
| "Label": "Report: RDP Brute Forcing", | ||
| "Href": "https://contoso.com/reports/DisplayReport", | ||
| "Type": "webLink" | ||
| } | ||
| ], | ||
| "alertUri": "https://portal.azure.com/#blade/Microsoft_Azure_Security/AlertBlade/alertId/2518298467986649999_4d25bfef-2d77-4a08-adc0-3e35715cc92a/subscriptionId/20ff7fc3-e762-44dd-bd96-b71116dcdc23/resourceGroup/myRg1/referencedFrom/alertDeepLink/location/westeurope", | ||
| "timeGeneratedUtc": "2020-02-23T13:47:58.0000000Z", | ||
| "productName": "Azure Security Center", | ||
| "processingEndTimeUtc": "2020-02-23T13:47:58.9205584Z", | ||
| "entities": [ | ||
| { | ||
| "address": "192.0.2.1", | ||
| "location": { | ||
| "countryCode": "gb", | ||
| "state": "wokingham", | ||
| "city": "sonning", | ||
| "longitude": -0.909, | ||
| "latitude": 51.468, | ||
| "asn": 6584 | ||
| }, | ||
| "type": "ip" | ||
| } | ||
| ], | ||
| "isIncident": true, | ||
| "correlationKey": "kso0LFWxzCll5tqrk5hmrBJ+MY1BX806W6q6+0s9Lk=", | ||
| "extendedProperties": { | ||
| "Property1": "Property1 information" | ||
| }, | ||
| "compromisedEntity": "vm1" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
82 changes: 82 additions & 0 deletions
82
...ft.Security/stable/2020-01-01/examples/Alerts/GetAlertsResourceGroupLocation_example.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2020-01-01", | ||
| "subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23", | ||
| "resourceGroupName": "myRg1", | ||
| "ascLocation": "westeurope" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/resourceGroups/myRg1/providers/Microsoft.Security/locations/westeurope/alerts/2518770965529163669_F144EE95-A3E5-42DA-A279-967D115809AA", | ||
| "name": "2518298467986649999_4d25bfef-2d77-4a08-adc0-3e35715cc92a", | ||
| "type": "Microsoft.Security/Locations/alerts", | ||
| "properties": { | ||
| "alertType": "VM_EICAR", | ||
| "systemAlertId": "2518298467986649999_4d25bfef-2d77-4a08-adc0-3e35715cc92a", | ||
| "productComponentName": "", | ||
| "alertDisplayName": "Azure Security Center test alert (not a threat)", | ||
| "description": "This is a test alert generated by Azure Security Center. No further action is needed.", | ||
| "severity": "High", | ||
| "intent": "Execution", | ||
| "startTimeUtc": "2020-02-22T00:00:00.0000000Z", | ||
| "endTimeUtc": "2020-02-22T00:00:00.0000000Z", | ||
| "resourceIdentifiers": [ | ||
| { | ||
| "azureResourceId": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/resourceGroups/myRg1/providers/Microsoft.Compute/virtualMachines/vm1", | ||
| "type": "AzureResource" | ||
| }, | ||
| { | ||
| "workspaceId": "f419f624-acad-4d89-b86d-f62fa387f019", | ||
| "workspaceSubscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23", | ||
| "workspaceResourceGroup": "myRg1", | ||
| "agentId": "75724a01-f021-4aa8-9ec2-329792373e6e", | ||
| "type": "LogAnalytics" | ||
| } | ||
| ], | ||
| "remediationSteps": [ | ||
| "No further action is needed." | ||
| ], | ||
| "vendorName": "Microsoft", | ||
| "status": "New", | ||
| "extendedLinks": [ | ||
| { | ||
| "Category": "threat_reports", | ||
| "Label": "Report: RDP Brute Forcing", | ||
| "Href": "https://contoso.com/reports/DisplayReport", | ||
| "Type": "webLink" | ||
| } | ||
| ], | ||
| "alertUri": "https://portal.azure.com/#blade/Microsoft_Azure_Security/AlertBlade/alertId/2518298467986649999_4d25bfef-2d77-4a08-adc0-3e35715cc92a/subscriptionId/20ff7fc3-e762-44dd-bd96-b71116dcdc23/resourceGroup/myRg1/referencedFrom/alertDeepLink/location/westeurope", | ||
| "timeGeneratedUtc": "2020-02-23T13:47:58.0000000Z", | ||
| "productName": "Azure Security Center", | ||
| "processingEndTimeUtc": "2020-02-23T13:47:58.9205584Z", | ||
| "entities": [ | ||
| { | ||
| "address": "192.0.2.1", | ||
| "location": { | ||
| "countryCode": "gb", | ||
| "state": "wokingham", | ||
| "city": "sonning", | ||
| "longitude": -0.909, | ||
| "latitude": 51.468, | ||
| "asn": 6584 | ||
| }, | ||
| "type": "ip" | ||
| } | ||
| ], | ||
| "isIncident": true, | ||
| "correlationKey": "kso0LFWxzCll5tqrk5hmrBJ+MY1BX806W6q6+0s9Lk=", | ||
| "extendedProperties": { | ||
| "Property1": "Property1 information" | ||
| }, | ||
| "compromisedEntity": "vm1" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
81 changes: 81 additions & 0 deletions
81
.../Microsoft.Security/stable/2020-01-01/examples/Alerts/GetAlertsResourceGroup_example.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2020-01-01", | ||
| "subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23", | ||
| "resourceGroupName": "myRg1" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/resourceGroups/myRg1/providers/Microsoft.Security/locations/westeurope/alerts/2518770965529163669_F144EE95-A3E5-42DA-A279-967D115809AA", | ||
| "name": "2518298467986649999_4d25bfef-2d77-4a08-adc0-3e35715cc92a", | ||
| "type": "Microsoft.Security/Locations/alerts", | ||
| "properties": { | ||
| "alertType": "VM_EICAR", | ||
| "systemAlertId": "2518298467986649999_4d25bfef-2d77-4a08-adc0-3e35715cc92a", | ||
| "productComponentName": "", | ||
| "alertDisplayName": "Azure Security Center test alert (not a threat)", | ||
| "description": "This is a test alert generated by Azure Security Center. No further action is needed.", | ||
| "severity": "High", | ||
| "intent": "Execution", | ||
| "startTimeUtc": "2020-02-22T00:00:00.0000000Z", | ||
| "endTimeUtc": "2020-02-22T00:00:00.0000000Z", | ||
| "resourceIdentifiers": [ | ||
| { | ||
| "azureResourceId": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/resourceGroups/myRg1/providers/Microsoft.Compute/virtualMachines/vm1", | ||
| "type": "AzureResource" | ||
| }, | ||
| { | ||
| "workspaceId": "f419f624-acad-4d89-b86d-f62fa387f019", | ||
| "workspaceSubscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23", | ||
| "workspaceResourceGroup": "myRg1", | ||
| "agentId": "75724a01-f021-4aa8-9ec2-329792373e6e", | ||
| "type": "LogAnalytics" | ||
| } | ||
| ], | ||
| "remediationSteps": [ | ||
| "No further action is needed." | ||
| ], | ||
| "vendorName": "Microsoft", | ||
| "status": "New", | ||
| "extendedLinks": [ | ||
| { | ||
| "Category": "threat_reports", | ||
| "Label": "Report: RDP Brute Forcing", | ||
| "Href": "https://contoso.com/reports/DisplayReport", | ||
| "Type": "webLink" | ||
| } | ||
| ], | ||
| "alertUri": "https://portal.azure.com/#blade/Microsoft_Azure_Security/AlertBlade/alertId/2518298467986649999_4d25bfef-2d77-4a08-adc0-3e35715cc92a/subscriptionId/20ff7fc3-e762-44dd-bd96-b71116dcdc23/resourceGroup/myRg1/referencedFrom/alertDeepLink/location/westeurope", | ||
| "timeGeneratedUtc": "2020-02-23T13:47:58.0000000Z", | ||
| "productName": "Azure Security Center", | ||
| "processingEndTimeUtc": "2020-02-23T13:47:58.9205584Z", | ||
| "entities": [ | ||
| { | ||
| "address": "192.0.2.1", | ||
| "location": { | ||
| "countryCode": "gb", | ||
| "state": "wokingham", | ||
| "city": "sonning", | ||
| "longitude": -0.909, | ||
| "latitude": 51.468, | ||
| "asn": 6584 | ||
| }, | ||
| "type": "ip" | ||
| } | ||
| ], | ||
| "isIncident": true, | ||
| "correlationKey": "kso0LFWxzCll5tqrk5hmrBJ+MY1BX806W6q6+0s9Lk=", | ||
| "extendedProperties": { | ||
| "Property1": "Property1 information" | ||
| }, | ||
| "compromisedEntity": "vm1" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we modeled this differently? Can't we use azureResourceId as workspace is also an Azure resource?
Please work with Gaurav Bhatnagar for continuing the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are different values , or did you mean something else? I'll work with Gaurav
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can the workspace Id be the ARM resource ID which is of the form /subsccriptions/{id}/resourceGroups/{rgname}/..../workspaces/{name}? @yibirnba ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we keep this separately on different properties: WorkspaceId, WorkspaceSubscriptionId, WorkspaceResourceGroup, AgentId , since those are not mandatory fields and we want to show information that we have