Adding APIs for private link #8540

juniwang · 2020-02-27T07:43:34Z

Changes

Adding APIs for SignalR PrivateEndpointConnection
Adding new field upstream

For both changes, backward compatibilities are took into account. If they are null, whether it's from old SDK or newer version of SDK, we won't change anything. Only if it's not null, we read their children properties and handle it correspondingly.

Validations documented at Swagger Validation tools all passed.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-02-27T07:43:50Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-02-27T07:45:14Z

azure-sdk-for-go

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from a16b59c with merge commit fb4e71f495b5cdc2c6d8f2f66ced89239a101102. SDK Automation 13.0.17.20200423.4
️✔️preview/signalr/mgmt/2018-03-01-preview [Logs] [Preview SDK Changes]
- preview.signalr.mgmt.2018-03-01-preview.zip
️✔️signalr/mgmt/2018-10-01 [Logs] [Preview SDK Changes]
- signalr.mgmt.2018-10-01.zip

openapi-sdkautomation · 2020-02-27T07:45:15Z

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from a16b59c with merge commit fb4e71f495b5cdc2c6d8f2f66ced89239a101102. SDK Automation 13.0.17.20200423.4

⚠️sdk/signalr/mgmt-v2018_03_01_preview [Logs] [Preview SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_03_01_preview/src/main/java/com/microsoft/azure/management/signalr/v2018_03_01_preview/implementation/SignalRManager.java:[82,50] incompatible types: com.microsoft.azure.management.signalr.v2018_03_01_preview.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_03_01_preview.implementation.SignalRServiceManager
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_03_01_preview/src/main/java/com/microsoft/azure/management/signalr/v2018_03_01_preview/implementation/SignalRManager.java:[92,46] incompatible types: com.microsoft.azure.management.signalr.v2018_03_01_preview.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_03_01_preview.implementation.SignalRServiceManager
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-signalrservice: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_03_01_preview/src/main/java/com/microsoft/azure/management/signalr/v2018_03_01_preview/implementation/SignalRManager.java:[82,50] incompatible types: com.microsoft.azure.management.signalr.v2018_03_01_preview.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_03_01_preview.implementation.SignalRServiceManager
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_03_01_preview/src/main/java/com/microsoft/azure/management/signalr/v2018_03_01_preview/implementation/SignalRManager.java:[92,46] incompatible types: com.microsoft.azure.management.signalr.v2018_03_01_preview.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_03_01_preview.implementation.SignalRServiceManager
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

⚠️sdk/signalr/mgmt-v2018_10_01 [Logs] [Preview SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/signalr/v2018_10_01/implementation/SignalRManager.java:[84,50] incompatible types: com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRServiceManager
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/signalr/v2018_10_01/implementation/SignalRManager.java:[94,46] incompatible types: com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRServiceManager
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/signalr/v2018_10_01/implementation/SignalRManager.java:[104,42] incompatible types: com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRServiceManager
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-signalrservice: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/signalr/v2018_10_01/implementation/SignalRManager.java:[84,50] incompatible types: com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRServiceManager
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/signalr/v2018_10_01/implementation/SignalRManager.java:[94,46] incompatible types: com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRServiceManager
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/signalr/v2018_10_01/implementation/SignalRManager.java:[104,42] incompatible types: com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRServiceManager
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2020-02-27T07:45:18Z

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from a16b59c with merge commit fb4e71f495b5cdc2c6d8f2f66ced89239a101102. SDK Automation 13.0.17.20200423.4
️✔️Microsoft.Azure.Management.SignalR [Logs] [Preview SDK Changes]
- Microsoft.Azure.Management.SignalR.1.0.1.nupkg
- Microsoft.Azure.Management.SignalR.1.0.1.snupkg

openapi-sdkautomation · 2020-02-27T07:45:21Z

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from a16b59c with merge commit fb4e71f495b5cdc2c6d8f2f66ced89239a101102. SDK Automation 13.0.17.20200423.4
️✔️@azure/arm-signalr [Logs] [Preview SDK Changes]
- azure-arm-signalr-2.0.0.tgz

openapi-sdkautomation · 2020-02-27T07:45:22Z

azure-sdk-for-python

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from a16b59c with merge commit fb4e71f495b5cdc2c6d8f2f66ced89239a101102. SDK Automation 13.0.17.20200423.4

️✔️azure-mgmt-signalr [Logs] [Preview SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-signalr
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-signalr
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 44.139% size of original (original: 22069 chars, delta: 9741 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model Operation has a new parameter is_data_action
[ChangeLog]   - Model SignalRResource has a new parameter private_endpoint_connections
[ChangeLog]   - Model SignalRResource has a new parameter kind
[ChangeLog]   - Model SignalRResource has a new parameter upstream
[ChangeLog]   - Model SignalRResource has a new parameter network_ac_ls
[ChangeLog]   - Model ServiceSpecification has a new parameter log_specifications
[ChangeLog]   - Model SignalRCreateParameters has a new parameter kind
[ChangeLog]   - Model SignalRCreateOrUpdateProperties has a new parameter upstream
[ChangeLog]   - Model SignalRCreateOrUpdateProperties has a new parameter network_ac_ls
[ChangeLog]   - Added operation group SignalRPrivateLinkResourcesOperations
[ChangeLog]   - Added operation group SignalRPrivateEndpointConnectionsOperations

azuresdkci · 2020-02-27T07:45:31Z

Can one of the admins verify this patch?

akning-ms · 2020-03-03T13:40:22Z

@juniwang there is 4 validations failure to fix. you should fix avocado first then modal validation & others

azure-pipelines · 2020-03-05T14:21:42Z

Azure Pipelines successfully started running 1 pipeline(s).

juniwang · 2020-03-06T01:07:39Z

@akning-ms Thanks for following up. Validation errors fixed.

specification/signalr/resource-manager/Microsoft.SignalRService/stable/2018-10-01/signalr.json

ravbhatnagar · 2020-03-06T23:50:54Z

@juniwang - few comments

azure-pipelines · 2020-03-12T07:14:40Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-12T07:32:29Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoenixHe-NV · 2020-03-25T04:42:42Z

/azp run

azure-pipelines · 2020-03-25T04:43:00Z

Azure Pipelines successfully started running 3 pipeline(s).

openapi-sdkautomation · 2020-03-25T04:44:24Z

azure-cli-extensions

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-04-03T03:55:31Z

Azure Pipelines successfully started running 1 pipeline(s).

…ecific

azure-pipelines · 2020-04-24T07:12:41Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-04-24T07:14:07Z

azure-sdk-for-trenton

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-04-24T07:30:47Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-04-24T07:47:01Z

Azure Pipelines successfully started running 1 pipeline(s).

pilor · 2020-04-27T18:01:08Z

specification/signalr/resource-manager/Microsoft.SignalRService/stable/2018-10-01/signalr.json

@@ -861,7 +1083,7 @@
          "readOnly": true
        },
        "type": {
-          "description": "The type of the service - e.g. \"Microsoft.SignalRService/SignalR\"",
+          "description": "The type of the resource - e.g. \"Microsoft.SignalRService/SignalR\", \"Microsoft.SignalRService/SignalR/PrivateEndpointConnections\"",


Microsoft.SignalRService/SignalR/PrivateEndpointConnections" [](start = 98, length = 61)

privateEndpointConnections does not belong here as an example on this definition. This definition describes a tracked resource specific to your service. PrivateEndpointConnections are proxy

pilor · 2020-04-27T18:02:31Z

specification/signalr/resource-manager/Microsoft.SignalRService/stable/2018-10-01/signalr.json

@@ -1059,7 +1297,7 @@
          }
        },
        "value": {
-          "description": "Value of the feature flag. See Azure SignalR service document https://docs.microsoft.com/azure/azure-signalr/ for allowed values.",
+          "description": "Value of the feature flag. See Azure SignalR service document https://docs.microsoft.com/en-us/azure/azure-signalr/ for allowed values.",


en-us/ [](start = 115, length = 6)

don't include locale in documentation links

pilor · 2020-04-27T18:03:57Z

specification/signalr/resource-manager/Microsoft.SignalRService/stable/2018-10-01/signalr.json

+      "type": "object",
+      "properties": {
+        "allow": {
+          "description": "Allowed request types. The value can be: ClientConnection, ServerConnection, RESTAPI.",


ClientConnection, ServerConnection, RESTAPI [](start = 67, length = 43)

if this is value constrained it should be represented by an array of string enums

pilor · 2020-04-27T18:04:54Z

specification/signalr/resource-manager/Microsoft.SignalRService/stable/2018-10-01/signalr.json

+          "readOnly": true
+        },
+        "type": {
+          "description": "The type of the resource - e.g. \"Microsoft.SignalRService/SignalR\", \"Microsoft.SignalRService/SignalR/PrivateEndpointConnections\"",


"Microsoft.SignalRService/SignalR" [](start = 58, length = 36)

Please update the type description so it is valid for this definition

pilor · 2020-04-27T18:05:44Z

specification/signalr/resource-manager/Microsoft.SignalRService/stable/2018-10-01/signalr.json

+          "description": "The type of the resource - e.g. \"Microsoft.SignalRService/SignalR\", \"Microsoft.SignalRService/SignalR/PrivateEndpointConnections\"",
+          "type": "string",
+          "readOnly": true
+        }


id, name, and type are inherited from the ProxyResource->Resource reference. You don't need to redeclare them here

pilor · 2020-04-27T18:08:20Z

...soft.SignalRService/stable/2018-10-01/examples/SignalRPrivateEndpointConnections_Create.json

+        "type": "Microsoft.SignalRService/SignalR/privateEndpointConnections"
+      },
+      "headers": {
+        "Location": "https://management.azure.com/subscriptions/subid/providers/Microsoft.SignalRService/...pathToOperationResult..."


"Location" [](start = 8, length = 10)

Async PUT should use the azure-asyncoperation header if it needs additional operation info, not location. https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/Addendum.md#creatingupdating-using-put

pilor · 2020-04-27T18:20:22Z

specification/signalr/resource-manager/Microsoft.SignalRService/stable/2018-10-01/signalr.json

+        },
+        "networkACLs": {
+          "$ref": "#/definitions/SignalRNetworkACLs",
+          "description": "Network ACLs"
        }


this needs to be a new api-version. Handling it via "patch" semantics with nulls is not a good approach as that is not expected by consumers of your API (a PUT should replace all properties). It makes what-if analysis on template deployments much more complex, will break users with custom Azure Policies in place that require certain properties, etc...

pilor

🕐

juniwang · 2020-04-29T05:52:16Z

Thanks for review, we will have a internal discussion first about the api-version

PhoenixHe-NV · 2020-05-17T03:57:28Z

@juniwang Suggest to refer to #8935 and try to use types in the common folder. Thanks!

juniwang · 2020-05-18T01:45:06Z

Close this PR since we have another one: #9377

Adding APIs for private link

2300b2a

openapi-assignment-bot bot assigned PhoenixHe-NV Feb 27, 2020

PhoenixHe-NV added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 27, 2020

fix valiation errors

7f0ef84

ravbhatnagar reviewed Mar 6, 2020

View reviewed changes

ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 6, 2020

update privateLinkResources to comply ARM standard

554c5a4

commit prettier changes

b24105d

juniwang requested a review from ravbhatnagar March 13, 2020 02:57

akning-ms added WaitForARMRevisit and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Apr 3, 2020

juniwang mentioned this pull request Apr 23, 2020

[BUG] Microsoft.Azure.Management.SignalR.Models.SignalRFeature: inconsistency with resource manifest/template because of static member Flag Azure/azure-sdk-for-net#8806

Closed

3 tasks

Move from top-level Resource to SignalRResource since it's SignalR-sp…

aa256b1

…ecific

openapi-assignment-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 24, 2020

fix typo

a0d26ab

using camel case

a16b59c

pilor added the ARMReviewInProgress label Apr 27, 2020

pilor reviewed Apr 27, 2020

View reviewed changes

pilor suggested changes Apr 27, 2020

View reviewed changes

pilor added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMReviewInProgress labels Apr 27, 2020

juniwang mentioned this pull request May 9, 2020

[Azure SignalR service]Support Private Link and add new api-version #9377

Merged

5 tasks

juniwang closed this May 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding APIs for private link #8540

Adding APIs for private link #8540

juniwang commented Feb 27, 2020

azure-pipelines bot commented Feb 27, 2020

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

azuresdkci commented Feb 27, 2020

akning-ms commented Mar 3, 2020

azure-pipelines bot commented Mar 5, 2020

juniwang commented Mar 6, 2020

ravbhatnagar commented Mar 6, 2020

azure-pipelines bot commented Mar 12, 2020

azure-pipelines bot commented Mar 12, 2020

PhoenixHe-NV commented Mar 25, 2020

azure-pipelines bot commented Mar 25, 2020

openapi-sdkautomation bot commented Mar 25, 2020 •

edited

Loading

azure-pipelines bot commented Apr 3, 2020

azure-pipelines bot commented Apr 24, 2020

openapi-sdkautomation bot commented Apr 24, 2020 •

edited

Loading

azure-pipelines bot commented Apr 24, 2020

azure-pipelines bot commented Apr 24, 2020

pilor Apr 27, 2020

pilor Apr 27, 2020

pilor Apr 27, 2020

pilor Apr 27, 2020

pilor Apr 27, 2020

pilor Apr 27, 2020

pilor Apr 27, 2020

pilor left a comment

juniwang commented Apr 29, 2020

PhoenixHe-NV commented May 17, 2020

juniwang commented May 18, 2020

Adding APIs for private link #8540

Adding APIs for private link #8540

Conversation

juniwang commented Feb 27, 2020

Changes

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Feb 27, 2020

openapi-sdkautomation bot commented Feb 27, 2020 • edited Loading

azure-sdk-for-go

openapi-sdkautomation bot commented Feb 27, 2020 • edited Loading

azure-sdk-for-java

openapi-sdkautomation bot commented Feb 27, 2020 • edited Loading

azure-sdk-for-net

openapi-sdkautomation bot commented Feb 27, 2020 • edited Loading

azure-sdk-for-js

openapi-sdkautomation bot commented Feb 27, 2020 • edited Loading

azure-sdk-for-python

azuresdkci commented Feb 27, 2020

akning-ms commented Mar 3, 2020

azure-pipelines bot commented Mar 5, 2020

juniwang commented Mar 6, 2020

ravbhatnagar commented Mar 6, 2020

azure-pipelines bot commented Mar 12, 2020

azure-pipelines bot commented Mar 12, 2020

PhoenixHe-NV commented Mar 25, 2020

azure-pipelines bot commented Mar 25, 2020

openapi-sdkautomation bot commented Mar 25, 2020 • edited Loading

azure-cli-extensions

azure-pipelines bot commented Apr 3, 2020

azure-pipelines bot commented Apr 24, 2020

openapi-sdkautomation bot commented Apr 24, 2020 • edited Loading

azure-sdk-for-trenton

azure-pipelines bot commented Apr 24, 2020

azure-pipelines bot commented Apr 24, 2020

pilor Apr 27, 2020

Choose a reason for hiding this comment

pilor Apr 27, 2020

Choose a reason for hiding this comment

pilor Apr 27, 2020

Choose a reason for hiding this comment

pilor Apr 27, 2020

Choose a reason for hiding this comment

pilor Apr 27, 2020

Choose a reason for hiding this comment

pilor Apr 27, 2020

Choose a reason for hiding this comment

pilor Apr 27, 2020

Choose a reason for hiding this comment

pilor left a comment

Choose a reason for hiding this comment

juniwang commented Apr 29, 2020

PhoenixHe-NV commented May 17, 2020

juniwang commented May 18, 2020

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 25, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 24, 2020 •

edited

Loading