Donaliu/20200207 sap monitor #8528

PakDLiu · 2020-02-26T22:08:58Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-02-26T22:09:14Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-02-26T22:16:26Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 32548ed with merge commit 619796b. SDK Automation 13.0.17.20200320.2
⚠️preview/hanaonazure/mgmt/2017-11-03-preview [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-02-26T22:16:32Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 32548ed with merge commit 619796b. SDK Automation 13.0.17.20200320.2
️✔️sdk/hanaonazure/mgmt-v2017_11_03_preview [Logs] [Release SDK Changes]

openapi-sdkautomation · 2020-02-26T22:16:38Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 32548ed with merge commit 619796b. SDK Automation 13.0.17.20200320.2

️✔️@azure/arm-hanaonazure [Logs] [Release SDK Changes]

azure-arm-hanaonazure-3.0.0.tgz

[npmPack] npm WARN lifecycle @azure/[email protected]~prepack: cannot run in wd @azure/[email protected] npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/hanaonazure/arm-hanaonazure)

openapi-sdkautomation · 2020-02-26T22:16:42Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 32548ed with merge commit 619796b. SDK Automation 13.0.17.20200320.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-02-26T22:16:43Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-02-26T22:18:43Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-26T22:25:24Z

Azure Pipelines successfully started running 1 pipeline(s).

tniek

Couple of comments, mostly naming

...ager/Microsoft.HanaOnAzure/preview/2020-02-07-preview/examples/ProviderInstances_Create.json

...ager/Microsoft.HanaOnAzure/preview/2020-02-07-preview/examples/ProviderInstances_Delete.json

...manager/Microsoft.HanaOnAzure/preview/2020-02-07-preview/examples/ProviderInstances_Get.json

...ce-manager/Microsoft.HanaOnAzure/preview/2020-02-07-preview/examples/SapMonitors_Create.json

...ource-manager/Microsoft.HanaOnAzure/preview/2020-02-07-preview/examples/SapMonitors_Get.json

...urce-manager/Microsoft.HanaOnAzure/preview/2020-02-07-preview/examples/SapMonitors_List.json

...manager/Microsoft.HanaOnAzure/preview/2020-02-07-preview/examples/SapMonitors_PatchTags.json

azure-pipelines · 2020-02-26T22:41:25Z

Azure Pipelines successfully started running 1 pipeline(s).

...ager/Microsoft.HanaOnAzure/preview/2020-02-07-preview/examples/ProviderInstances_Create.json

azure-pipelines · 2020-02-26T22:52:15Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-26T22:56:43Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-02-26T23:00:37Z

Can one of the admins verify this patch?

azure-pipelines · 2020-02-26T23:07:14Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-26T23:17:35Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-27T00:20:25Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-10T17:14:51Z

Azure Pipelines successfully started running 1 pipeline(s).

markcowl · 2020-03-10T22:44:51Z

@ravbhatnagar Please answer the remaining question to your feedback

Added List providerInstance API

azure-pipelines · 2020-03-13T23:45:46Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-13T23:56:51Z

Azure Pipelines successfully started running 1 pipeline(s).

markcowl · 2020-03-19T17:56:28Z

...naonazure/resource-manager/Microsoft.HanaOnAzure/preview/2020-02-07-preview/hanaonazure.json

-        "type": {
-          "type": "string",
-          "description": "The provider instance type."
-        },


Why is there no modelling of the properties of the provider instance? This is going to make writing tools to consume this type very difficult, both in SDKs and for customers consuming the API directly

This is by design. the properties field is a JSON string and the schema will be determined by the type field.

We wanted to make the API flexible. Also, other teams will be implementing their own providers and it will be up to them what their JSON schema will be.

markcowl · 2020-03-19T18:00:07Z

@PakDLiu One comment, verified that ARM feedback was addressed. Please take a look

azure-pipelines · 2020-03-19T20:59:15Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-19T21:00:52Z

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

* Added new version 2020-02-07-preview of SapMonitor APIs * bugs * Fixed parameter naming * fixed examples * fixed more examples * various fixed * more fixes * ran prettier * renamed monitorProviders to providerInstances * updated README * Added 201 and 202 for create and delete provider instances * ran prettier * fixed path in readme * added id field to providerInstances * Separate SapMonitor and providerInstance APIs Added List providerInstance API * fixed spelling * updated provider instance payload

PakDLiu added 2 commits February 26, 2020 13:56

Added new version 2020-02-07-preview of SapMonitor APIs

09ffe27

bugs

f98c566

openapi-assignment-bot bot assigned markcowl Feb 26, 2020

openapi-sdkautomation bot mentioned this pull request Feb 26, 2020

[AutoPR @azure/arm-hanaonazure] Donaliu/20200207 sap monitor AzureSDKAutomation/azure-sdk-for-js#669

Closed

Fixed parameter naming

49deb5b

openapi-sdkautomation bot mentioned this pull request Feb 26, 2020

[AutoPR sdk/hanaonazure/mgmt-v2017_11_03_preview] Donaliu/20200207 sap monitor AzureSDKAutomation/azure-sdk-for-java#1688

Closed

fixed examples

39c7f76

tniek reviewed Feb 26, 2020

View reviewed changes

fixed more examples

a0a7433

persiaAziz-zz reviewed Feb 26, 2020

View reviewed changes

...ager/Microsoft.HanaOnAzure/preview/2020-02-07-preview/examples/ProviderInstances_Create.json Outdated Show resolved Hide resolved

various fixed

ef42ba9

more fixes

0bbb803

ran prettier

c99eaf4

renamed monitorProviders to providerInstances

ff0ca1c

updated README

853f3ba

markcowl assigned PakDLiu Mar 7, 2020

added id field to providerInstances

ea21c3f

PakDLiu removed their assignment Mar 10, 2020

PakDLiu requested review from markcowl, ryansbenson and ravbhatnagar March 10, 2020 19:55

markcowl added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Mar 10, 2020

markcowl assigned ravbhatnagar Mar 10, 2020

Separate SapMonitor and providerInstance APIs

eacfca8

Added List providerInstance API

fixed spelling

e336f58

markcowl requested changes Mar 19, 2020

View reviewed changes

markcowl added Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 19, 2020

markcowl assigned PakDLiu and unassigned ravbhatnagar and ryansbenson Mar 19, 2020

updated provider instance payload

32548ed

markcowl approved these changes Mar 24, 2020

View reviewed changes

markcowl added Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates and removed Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Mar 24, 2020

markcowl merged commit 619796b into Azure:master Mar 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Donaliu/20200207 sap monitor #8528

Donaliu/20200207 sap monitor #8528

PakDLiu commented Feb 26, 2020

azure-pipelines bot commented Feb 26, 2020

openapi-sdkautomation bot commented Feb 26, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 26, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 26, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 26, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 26, 2020 •

edited

Loading

azure-pipelines bot commented Feb 26, 2020

azure-pipelines bot commented Feb 26, 2020

tniek left a comment

azure-pipelines bot commented Feb 26, 2020

azure-pipelines bot commented Feb 26, 2020

azure-pipelines bot commented Feb 26, 2020

azuresdkci commented Feb 26, 2020

azure-pipelines bot commented Feb 26, 2020

azure-pipelines bot commented Feb 26, 2020

azure-pipelines bot commented Feb 27, 2020

azure-pipelines bot commented Mar 10, 2020

markcowl commented Mar 10, 2020

azure-pipelines bot commented Mar 13, 2020

azure-pipelines bot commented Mar 13, 2020

markcowl Mar 19, 2020

PakDLiu Mar 23, 2020

markcowl commented Mar 19, 2020

azure-pipelines bot commented Mar 19, 2020

openapi-sdkautomation bot commented Mar 19, 2020 •

edited

Loading

Donaliu/20200207 sap monitor #8528

Donaliu/20200207 sap monitor #8528

Conversation

PakDLiu commented Feb 26, 2020

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Feb 26, 2020

openapi-sdkautomation bot commented Feb 26, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Feb 26, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Feb 26, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Feb 26, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Feb 26, 2020 • edited Loading

azure-sdk-for-net - Release

azure-pipelines bot commented Feb 26, 2020

azure-pipelines bot commented Feb 26, 2020

tniek left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented Feb 26, 2020

azure-pipelines bot commented Feb 26, 2020

azure-pipelines bot commented Feb 26, 2020

azuresdkci commented Feb 26, 2020

azure-pipelines bot commented Feb 26, 2020

azure-pipelines bot commented Feb 26, 2020

azure-pipelines bot commented Feb 27, 2020

azure-pipelines bot commented Mar 10, 2020

markcowl commented Mar 10, 2020

azure-pipelines bot commented Mar 13, 2020

azure-pipelines bot commented Mar 13, 2020

markcowl Mar 19, 2020

Choose a reason for hiding this comment

PakDLiu Mar 23, 2020

Choose a reason for hiding this comment

markcowl commented Mar 19, 2020

azure-pipelines bot commented Mar 19, 2020

openapi-sdkautomation bot commented Mar 19, 2020 • edited Loading

azure-cli-extensions - Release

openapi-sdkautomation bot commented Feb 26, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 26, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 26, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 26, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 26, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 19, 2020 •

edited

Loading