Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Security Center] Adding a new version to SecurityContact #8493

Merged
merged 7 commits into from
Jul 22, 2020

Conversation

anatinon
Copy link
Contributor

@anatinon anatinon commented Feb 24, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 24, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 24, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 6854a23 with merge commit f86892f. SDK Automation 13.0.17.20200619.4
  • ️✔️@azure/arm-security [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/securityCenter.js → ./dist/arm-security.js...
    [npmPack] created ./dist/arm-security.js in 1.1s
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 4.8kB   esm/operations/adaptiveApplicationControls.js                          
    [npmPack] npm notice 634B    esm/models/adaptiveApplicationControlsMappers.js                       
    [npmPack] npm notice 7.9kB   esm/operations/adaptiveNetworkHardenings.js                            
    [npmPack] npm notice 3.0kB   esm/models/adaptiveNetworkHardeningsMappers.js                         
    [npmPack] npm notice 3.0kB   esm/operations/advancedThreatProtection.js                             
    [npmPack] npm notice 2.9kB   esm/models/advancedThreatProtectionMappers.js                          
    [npmPack] npm notice 13.7kB  esm/operations/alerts.js                                               
    [npmPack] npm notice 2.9kB   esm/models/alertsMappers.js                                            
    [npmPack] npm notice 5.5kB   esm/operations/alertsSuppressionRules.js                               
    [npmPack] npm notice 3.0kB   esm/models/alertsSuppressionRulesMappers.js                            
    [npmPack] npm notice 5.0kB   esm/operations/allowedConnections.js                                   
    [npmPack] npm notice 521B    esm/models/allowedConnectionsMappers.js                                
    [npmPack] npm notice 687.3kB dist/arm-security.js                                                   
    [npmPack] npm notice 267.2kB dist/arm-security.min.js                                               
    [npmPack] npm notice 5.3kB   esm/operations/assessments.js                                          
    [npmPack] npm notice 3.0kB   esm/models/assessmentsMappers.js                                       
    [npmPack] npm notice 7.7kB   esm/operations/assessmentsMetadata.js                                  
    [npmPack] npm notice 3.0kB   esm/models/assessmentsMetadataMappers.js                               
    [npmPack] npm notice 8.3kB   esm/operations/automations.js                                          
    [npmPack] npm notice 672B    esm/models/automationsMappers.js                                       
    [npmPack] npm notice 4.4kB   esm/operations/autoProvisioningSettings.js                             
    [npmPack] npm notice 3.0kB   esm/models/autoProvisioningSettingsMappers.js                          
    [npmPack] npm notice 3.3kB   esm/operations/complianceResults.js                                    
    [npmPack] npm notice 3.0kB   esm/models/complianceResultsMappers.js                                 
    [npmPack] npm notice 3.2kB   esm/operations/compliances.js                                          
    [npmPack] npm notice 2.9kB   esm/models/compliancesMappers.js                                       
    [npmPack] npm notice 5.1kB   esm/operations/connectors.js                                           
    [npmPack] npm notice 3.0kB   esm/models/connectorsMappers.js                                        
    [npmPack] npm notice 5.6kB   esm/operations/deviceSecurityGroups.js                                 
    [npmPack] npm notice 3.0kB   esm/models/deviceSecurityGroupsMappers.js                              
    [npmPack] npm notice 5.3kB   esm/operations/discoveredSecuritySolutions.js                          
    [npmPack] npm notice 498B    esm/models/discoveredSecuritySolutionsMappers.js                       
    [npmPack] npm notice 5.3kB   esm/operations/externalSecuritySolutions.js                            
    [npmPack] npm notice 704B    esm/models/externalSecuritySolutionsMappers.js                         
    [npmPack] npm notice 345B    esm/models/index.js                                                    
    [npmPack] npm notice 2.0kB   esm/operations/index.js                                                
    [npmPack] npm notice 4.9kB   esm/operations/informationProtectionPolicies.js                        
    [npmPack] npm notice 3.0kB   esm/models/informationProtectionPoliciesMappers.js                     
    [npmPack] npm notice 3.8kB   esm/operations/iotAlerts.js                                            
    [npmPack] npm notice 444B    esm/models/iotAlertsMappers.js                                         
    [npmPack] npm notice 3.0kB   esm/operations/iotAlertTypes.js                                        
    [npmPack] npm notice 3.0kB   esm/models/iotAlertTypesMappers.js                                     
    [npmPack] npm notice 8.9kB   esm/operations/iotSecuritySolution.js                                  
    [npmPack] npm notice 3.1kB   esm/operations/iotSecuritySolutionAnalytics.js                         
    [npmPack] npm notice 3.0kB   esm/models/iotSecuritySolutionAnalyticsMappers.js                      
    [npmPack] npm notice 598B    esm/models/iotSecuritySolutionMappers.js                               
    [npmPack] npm notice 5.3kB   esm/operations/iotSecuritySolutionsAnalyticsAggregatedAlert.js         
    [npmPack] npm notice 571B    esm/models/iotSecuritySolutionsAnalyticsAggregatedAlertMappers.js      
    [npmPack] npm notice 4.3kB   esm/operations/iotSecuritySolutionsAnalyticsRecommendation.js          
    [npmPack] npm notice 532B    esm/models/iotSecuritySolutionsAnalyticsRecommendationMappers.js       
    [npmPack] npm notice 12.6kB  esm/operations/jitNetworkAccessPolicies.js                             
    [npmPack] npm notice 767B    esm/models/jitNetworkAccessPoliciesMappers.js                          
    [npmPack] npm notice 3.1kB   esm/operations/locations.js                                            
    [npmPack] npm notice 2.9kB   esm/models/locationsMappers.js                                         
    [npmPack] npm notice 202.8kB esm/models/mappers.js                                                  
    [npmPack] npm notice 2.2kB   esm/operations/operations.js                                           
    [npmPack] npm notice 465B    esm/models/operationsMappers.js                                        
    [npmPack] npm notice 16.8kB  esm/models/parameters.js                                               
    [npmPack] npm notice 3.4kB   esm/operations/pricings.js                                             
    [npmPack] npm notice 2.9kB   esm/models/pricingsMappers.js                                          
    [npmPack] npm notice 4.5kB   esm/operations/regulatoryComplianceAssessments.js                      
    [npmPack] npm notice 3.0kB   esm/models/regulatoryComplianceAssessmentsMappers.js                   
    [npmPack] npm notice 4.0kB   esm/operations/regulatoryComplianceControls.js                         
    [npmPack] npm notice 3.0kB   esm/models/regulatoryComplianceControlsMappers.js                      
    [npmPack] npm notice 3.6kB   esm/operations/regulatoryComplianceStandards.js                        
    [npmPack] npm notice 3.0kB   esm/models/regulatoryComplianceStandardsMappers.js                     
    [npmPack] npm notice 976B    rollup.config.js                                                       
    [npmPack] npm notice 4.1kB   esm/operations/secureScoreControlDefinitions.js                        
    [npmPack] npm notice 3.0kB   esm/models/secureScoreControlDefinitionsMappers.js                     
    [npmPack] npm notice 4.2kB   esm/operations/secureScoreControls.js                                  
    [npmPack] npm notice 3.0kB   esm/models/secureScoreControlsMappers.js                               
    [npmPack] npm notice 3.2kB   esm/operations/secureScores.js                                         
    [npmPack] npm notice 3.0kB   esm/models/secureScoresMappers.js                                      
    [npmPack] npm notice 4.9kB   esm/securityCenter.js                                                  
    [npmPack] npm notice 2.7kB   esm/securityCenterContext.js                                           
    [npmPack] npm notice 6.3kB   esm/operations/securityContacts.js                                     
    [npmPack] npm notice 3.0kB   esm/models/securityContactsMappers.js                                  
    [npmPack] npm notice 3.5kB   esm/operations/securitySolutions.js                                    
    [npmPack] npm notice 468B    esm/models/securitySolutionsMappers.js                                 
    [npmPack] npm notice 2.8kB   esm/operations/securitySolutionsReferenceDataOperations.js             
    [npmPack] npm notice 519B    esm/models/securitySolutionsReferenceDataOperationsMappers.js          
    [npmPack] npm notice 6.5kB   esm/operations/serverVulnerabilityAssessmentOperations.js              
    [npmPack] npm notice 3.0kB   esm/models/serverVulnerabilityAssessmentOperationsMappers.js           
    [npmPack] npm notice 4.1kB   esm/operations/settings.js                                             
    [npmPack] npm notice 2.9kB   esm/models/settingsMappers.js                                          
    [npmPack] npm notice 5.0kB   esm/operations/subAssessments.js                                       
    [npmPack] npm notice 3.0kB   esm/models/subAssessmentsMappers.js                                    

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 24, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 24, 2020

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 6854a23 with merge commit f86892f. SDK Automation 13.0.17.20200619.4
  • ️✔️azure-mgmt-security [View full logs]  [Release SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-security
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-security
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 11.447% size of original (original: 154481 chars, delta: 17684 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Added operation group ConnectorsOperations
    [ChangeLog]   - Added operation group SecuritySolutionsReferenceDataOperations
    [ChangeLog]   - Added operation group SecuritySolutionsOperations
    [ChangeLog]   - Added operation group IotAlertsOperations
    [ChangeLog]   - Added operation group IotAlertTypesOperations

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 24, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to fix the style.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@weidongxu-microsoft weidongxu-microsoft added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Mar 22, 2020
@azure-pipelines
Copy link

Comment was made before the most recent commit for PR 8493 in repo Azure/azure-rest-api-specs

@weidongxu-microsoft
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 24, 2020

azure-cli-extensions

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@anatinon
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8493 in repo Azure/azure-rest-api-specs

@weidongxu-microsoft
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@weidongxu-microsoft
Copy link
Member

@anatinon

This one is finally good. Ping me when you need to merge it.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 21, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 8493 in repo Azure/azure-rest-api-specs

@weidongxu-microsoft
Copy link
Member

Seems lint error is this

  `  "Text": "Error: Could not read 'file:///home/vsts/work/1/s/specification/security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/serverVulnerabilityAssessments.json'."\n` +

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 21, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 21, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 21, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@anatinon
Copy link
Contributor Author

anatinon commented Jul 21, 2020 via email

@weidongxu-microsoft weidongxu-microsoft merged commit f86892f into Azure:master Jul 22, 2020
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
…e#8493)

* Adding a copy of security contact for new version

* update swagger with new SecurityContact API version

* Fix descriptions

* CR fixes

* compilation fix

* Update readme.md

Co-authored-by: ariklin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review DoNotMerge <valid label in PR review process> use to hold merge after approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants