Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove management plane changes from data plane PR #8459

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Remove management plane changes from data plane PR #8459

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93f8d64
Remove management plane changes from data plane PR
heaths Feb 21, 2020
2ccaa8e
Resolve validation issues on older preview version
heaths Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .../resource-manager/Microsoft.KeyVault/preview/2018-02-14-preview/examples/deleteVault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,8 @@
},
"responses": {
"200": {
"headers": {}
},
"204": {
"headers": {}
"headers": {},
"body": ""
}
}
}
8 changes: 6 additions & 2 deletions ...rce-manager/Microsoft.KeyVault/preview/2018-02-14-preview/examples/purgeDeletedVault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@
"api-version": "2018-02-14-preview"
},
"responses": {
"200": {},
"202": {}
"200": {
"body": ""
},
"202": {
"body": ""
}
}
}
3 changes: 0 additions & 3 deletions ...ion/keyvault/resource-manager/Microsoft.KeyVault/preview/2018-02-14-preview/keyvault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,6 @@
"responses": {
"200": {
"description": "OK Response."
},
"204": {
"description": "No Content."
}
},
"x-ms-examples": {
Expand Down
16 changes: 2 additions & 14 deletions specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/keyvault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,13 +1122,7 @@
},
"enableSoftDelete": {
"type": "boolean",
"default": true,
"description": "Property to specify whether the 'soft delete' functionality is enabled for this key vault. If it's not set to any value(true or false) when creating new key vault, it will be set to true by default. Once it's been set to true value, it can NOT be reverted to false."
},
"softDeleteRetentionInDays": {
"type": "integer",
"format": "int32",
"description": "softDelete data retention days. It accepts >=7 and <=90."
"description": "Property to specify whether the 'soft delete' functionality is enabled for this key vault. If omitted, assume true as default value. Once set to true, cannot be reverted to false."
},
"createMode": {
"type": "string",
Expand Down Expand Up @@ -1197,13 +1191,7 @@
},
"enableSoftDelete": {
"type": "boolean",
"default": false,
"description": "Property to specify whether the 'soft delete' functionality is enabled for this key vault. If omitted, assume false as default value when patching an existing vault. Once set to true, cannot be reverted to false."
},
"softDeleteRetentionInDays": {
"type": "integer",
"format": "int32",
"description": "softDelete data retention days. It accepts >=7 and <=90."
"description": "Property to specify whether the 'soft delete' functionality is enabled for this key vault. If omitted, assume true as default value. Once set to true, cannot be reverted to false."
},
"createMode": {
"type": "string",
Expand Down