Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEED ARM SIGN-OFF] Adding new API version for ComputeInstance preview #8452

Merged
merged 7 commits into from
Mar 24, 2020
Merged

[NEED ARM SIGN-OFF] Adding new API version for ComputeInstance preview #8452

merged 7 commits into from
Mar 24, 2020

Conversation

ramagott
Copy link
Member

@ramagott ramagott commented Feb 20, 2020 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

Spec changes in this PR were already approved by ARM reviewers in the below PR. We are moving the changes to preview from stable.
#7323

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 20, 2020 •
edited
Loading

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 20, 2020 •
edited
Loading

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 20, 2020 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 20, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 7127da8 with merge commit 1aba830. SDK Automation 13.0.17.20200320.2
  • ️✔️Microsoft.Azure.Management.MachineLearningServices [Logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Feb 20, 2020 •
    edited
    Loading

    azure-sdk-for-python - Release

    - Breaking Change detected in SDK

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 7127da8 with merge commit 1aba830. SDK Automation 13.0.17.20200320.2
    • ⚠️azure-mgmt-machinelearningservices [Logs]  [Release SDK Changes] Breaking Change Detected
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 34.835% size of original (original: 50288 chars, delta: 17518 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog] - Model ComputeResource has a new parameter sku
[ChangeLog] - Model VirtualMachineSize has a new parameter gpus
[ChangeLog] - Model AmlComputeProperties has a new parameter remote_login_port_public_access
[ChangeLog] - Model WorkspaceUpdateParameters has a new parameter sku
[ChangeLog] - Model Resource has a new parameter sku
[ChangeLog] - Model Workspace has a new parameter hbi_workspace
[ChangeLog] - Model Workspace has a new parameter private_endpoint_connections
[ChangeLog] - Model Workspace has a new parameter image_build_compute
[ChangeLog] - Model Workspace has a new parameter service_provisioned_resource_group
[ChangeLog] - Model Workspace has a new parameter private_link_count
[ChangeLog] - Model Workspace has a new parameter sku
[ChangeLog] - Model Workspace has a new parameter shared_private_link_resources
[ChangeLog] - Model Workspace has a new parameter allow_public_access_when_behind_vnet
[ChangeLog] - Model Workspace has a new parameter encryption
[ChangeLog] - Added operation group WorkspaceFeaturesOperations
[ChangeLog] - Added operation group QuotasOperations
[ChangeLog] - Added operation group PrivateEndpointConnectionsOperations
[ChangeLog] - Added operation group AzureMachineLearningWorkspacesOperationsMixin
[ChangeLog] - Added operation group PrivateLinkResourcesOperations
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog] - Model AmlComputeNodeInformation has a new signature

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    This was referenced Feb 20, 2020
    Closed
    Closed
    Closed
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ramagott ramagott changed the title Adding new API version for ComputeInstance preview [NEED ARM SIGN-OFF] Adding new API version for ComputeInstance preview Feb 21, 2020
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ramagott ramagott requested a review from yungezz February 21, 2020 02:00
    @yungezz yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 21, 2020
    leizhaoPS
    leizhaoPS approved these changes Feb 21, 2020
    View reviewed changes
    Copy link
    Contributor

    @leizhaoPS leizhaoPS left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Approved since this is the code migrate from stable folder to preview version and no new design changes, just file copies

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @yungezz
    Copy link
    Member

    yungezz commented Feb 21, 2020

    there're new changes in this PR comparing with PR #7323 , such as new paths and new definitions, below are some. So need ARM review again.
    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/features"
    /subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/workspaces/skus.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ramagott
    Copy link
    Member Author

    ramagott commented Feb 21, 2020 •
    edited
    Loading

    there're new changes in this PR comparing with PR #7323 , such as new paths and new definitions, below are some. So need ARM review again.
    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/features"
    /subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/workspaces/skus.

    Above mentioned changes were already published in version 2020-01-01. You can compare with https://github.com/Azure/azure-rest-api-specs/tree/master/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2020-01-01 to find the real changes.

    @ravbhatnagar
    Copy link
    Contributor

    part of the changes here have already been signed off here - #7323.
    New APis to start and stop computes resource type has been added. SIgning off from ARM side.

    @ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 25, 2020
    @yungezz
    Copy link
    Member

    yungezz commented Feb 26, 2020

    hi @ramagott is this PR ready to merge? thanks.

    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @ramagott
    Copy link
    Member Author

    hi @ramagott is this PR ready to merge? thanks.

    We need to upload ARM manifest to support this version. I will let you know once we are ready. Please add the DoNotMerge label.

    @yungezz yungezz added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Feb 27, 2020
    @yungezz yungezz removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Mar 24, 2020
    @yungezz yungezz merged commit 1aba830 into Azure:master Mar 24, 2020
    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Mar 24, 2020 •
    edited
    Loading

    azure-cli-extensions - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    @ramagott @00Kai0
    [NEED ARM SIGN-OFF] Adding new API version for ComputeInstance preview (
    b2da7db 
    Azure#8452)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @yungezz yungezz yungezz approved these changes

    @leizhaoPS leizhaoPS leizhaoPS approved these changes

    @guanyu-240 guanyu-240 Awaiting requested review from guanyu-240

    @DeMale DeMale Awaiting requested review from DeMale

    Assignees

    @yungezz yungezz

    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @ramagott @yungezz @ravbhatnagar @azuresdkci @leizhaoPS