Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new api version of apimanagement for go SDK #8291

Merged

Conversation

ArcturusZhang
Copy link
Member

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 4, 2020

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 9d74b2c with merge commit 6daf2ac. SDK Automation 13.0.17.20191226.1
  • ️✔️azure-mgmt-apimanagement [Logs]  [Release SDK Changes]
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 4, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 9d74b2c with merge commit 6daf2ac. SDK Automation 13.0.17.20191226.1
  • ️✔️@azure/arm-apimanagement [Logs]  [Release SDK Changes]
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/apiManagementClient.js → ./dist/arm-apimanagement.js...
    [npmPack] created ./dist/arm-apimanagement.js in 1.4s

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 4, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 4, 2020

azure-sdk-for-net - Release

failed [Logs] [Expand Details]
  • Generate from 9d74b2c with merge commit 6daf2ac. SDK Automation 13.0.17.20191226.1
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • Microsoft.Azure.Management.ApiManagement [Logs]  [Release SDK Changes]
      Failed to create the package Microsoft.Azure.Management.ApiManagement.
      Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=apimanagement /v:n /p:SkipTests=true , {} 

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Feb 4, 2020

    azure-sdk-for-java - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    Copy link
    Member

    @solankisamir solankisamir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    looks good

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 3 pipeline(s).

    1 similar comment
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 3 pipeline(s).

    @yungezz
    Copy link
    Member

    yungezz commented Feb 6, 2020

    hi @NullMDR @isra-fel could you pls help to the SDK Net task failure? Thanks.

    @yungezz
    Copy link
    Member

    yungezz commented Feb 6, 2020

    hi @ArcturusZhang is this PR ready to merge?

    @ArcturusZhang
    Copy link
    Member Author

    hi @ArcturusZhang is this PR ready to merge?

    Yes, this is ready to merge.

    @solankisamir
    Copy link
    Member

    hi @NullMDR @isra-fel could you pls help to the SDK Net task failure? Thanks.

    SDK failures are expected in the new api-version @vfedonkin is working on fixing the sdk, as there are breaking changes

    @ArcturusZhang
    Copy link
    Member Author

    Well, this PR is totally irrelevant with the dot-net SDK, if the failure on dot-net sdk is expected, we can just merge this. Thanks @yungezz

    @yungezz yungezz merged commit 6daf2ac into Azure:master Feb 8, 2020
    @ArcturusZhang ArcturusZhang deleted the add-api-version-for-apimanagement branch February 10, 2020 04:44
    ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants