[SRP] Add default response status code #8065

zfchen95 · 2020-01-03T19:17:54Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-01-03T19:18:12Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-01-03T19:20:13Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 40703e6 with merge commit f7475a7. SDK Automation 13.0.17.20191226.1
️✔️preview/storage/mgmt/2015-05-01-preview [Logs] [Release SDK Changes]
- preview.storage.mgmt.2015-05-01-preview.zip
️✔️preview/storage/mgmt/2018-03-01-preview [Logs] [Release SDK Changes]
- preview.storage.mgmt.2018-03-01-preview.zip
️✔️storage/mgmt/2015-06-15 [Logs] [Release SDK Changes]
- storage.mgmt.2015-06-15.zip
️✔️storage/mgmt/2016-01-01 [Logs] [Release SDK Changes]
- storage.mgmt.2016-01-01.zip
️✔️storage/mgmt/2016-05-01 [Logs] [Release SDK Changes]
- storage.mgmt.2016-05-01.zip
️✔️storage/mgmt/2016-12-01 [Logs] [Release SDK Changes]
- storage.mgmt.2016-12-01.zip
️✔️storage/mgmt/2017-06-01 [Logs] [Release SDK Changes]
- storage.mgmt.2017-06-01.zip
️✔️storage/mgmt/2017-10-01 [Logs] [Release SDK Changes]
- storage.mgmt.2017-10-01.zip
️✔️storage/mgmt/2018-02-01 [Logs] [Release SDK Changes]
- storage.mgmt.2018-02-01.zip
️✔️storage/mgmt/2018-07-01 [Logs] [Release SDK Changes]
- storage.mgmt.2018-07-01.zip
️✔️storage/mgmt/2018-11-01 [Logs] [Release SDK Changes]
- storage.mgmt.2018-11-01.zip
️✔️storage/mgmt/2019-04-01 [Logs] [Release SDK Changes]
- storage.mgmt.2019-04-01.zip
️✔️storage/mgmt/2019-06-01 [Logs] [Release SDK Changes]
- storage.mgmt.2019-06-01.zip

openapi-sdkautomation · 2020-01-03T19:20:13Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 40703e6 with merge commit f7475a7. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-storage [Logs] [Release SDK Changes]

[after_scripts|python] WARNING:__main__:Found too much API version: {'2018-03-01-preview', '2018-07-01'} in label v2018_07_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

openapi-sdkautomation · 2020-01-03T19:20:15Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 40703e6 with merge commit f7475a7. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-storage [Logs] [Release SDK Changes]

azure-arm-storage-12.0.0.tgz

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/storageManagementClient.js → ./dist/arm-storage.js...
[npmPack] created ./dist/arm-storage.js in 498ms

openapi-sdkautomation · 2020-01-03T19:20:16Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 40703e6 with merge commit f7475a7. SDK Automation 13.0.17.20191226.1
️✔️sdk/storage/mgmt-v2016_01_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2017_10_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2018_02_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2018_03_01_preview [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2018_07_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2019_04_01 [Logs] [Release SDK Changes]

⚠️sdk/storage/mgmt-v2019_06_01 [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/BlobServiceProperties.java:[63,5] cannot find symbol
[mvn]   symbol:   class SkuInner
[mvn]   location: interface com.microsoft.azure.management.storage.v2019_06_01.BlobServiceProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/FileServiceProperties.java:[49,5] cannot find symbol
[mvn]   symbol:   class SkuInner
[mvn]   location: interface com.microsoft.azure.management.storage.v2019_06_01.FileServiceProperties
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-storage: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/BlobServiceProperties.java:[63,5] cannot find symbol
[mvn] [ERROR]   symbol:   class SkuInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_06_01.BlobServiceProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/FileServiceProperties.java:[49,5] cannot find symbol
[mvn] [ERROR]   symbol:   class SkuInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_06_01.FileServiceProperties
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2020-01-03T19:20:19Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 40703e6 with merge commit f7475a7. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Storage [Logs] [Release SDK Changes]

azure-pipelines · 2020-01-03T19:27:59Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-03T19:28:25Z

Azure Pipelines successfully started running 1 pipeline(s).

weidongxu-microsoft · 2020-01-04T01:13:00Z

@zfchen95 This should be low risk, but still please add code owner to review.

zfchen95 · 2020-01-06T22:20:37Z

@zfchen95 This should be low risk, but still please add code owner to review.

@weidongxu-microsoft Hi, I am from the Storage RP team. This PR is to solve the problem that error code is not defined in the response.

zfchen95 · 2020-01-06T22:21:21Z

@zfchen95 This should be low risk, but still please add code owner to review.

@weidongxu-microsoft Hi, I am from the Storage RP team. This PR is to solve the problem that error code is not defined in the response.

You could add ARM team for review if you feel it is needed.

weidongxu-microsoft · 2020-01-07T01:41:44Z

@zfchen95

It is good enough.

Some of the SDK generator would actually add a default CloudError when there is none,

This reverts commit f7475a7.

[SRP] Add response status code 404

212e6ea

openapi-assignment-bot bot assigned weidongxu-microsoft Jan 3, 2020

Add default response

40703e6

zfchen95 changed the title ~~[SRP] Add response status code 404~~ [SRP] Add default response status code Jan 3, 2020

openapi-sdkautomation bot mentioned this pull request Jan 3, 2020

[AutoPR Microsoft.Azure.Management.Storage] [SRP] Add default response status code AzureSDKAutomation/azure-sdk-for-net#277

Closed

weidongxu-microsoft approved these changes Jan 7, 2020

View reviewed changes

weidongxu-microsoft merged commit f7475a7 into Azure:master Jan 7, 2020

blueww added a commit that referenced this pull request Jan 7, 2020

Revert "[SRP] Add default response status code (#8065)"

c24cd81

This reverts commit f7475a7.

blueww mentioned this pull request Jan 7, 2020

Revert "[SRP] Add default response status code" #8074

Merged

weidongxu-microsoft pushed a commit that referenced this pull request Jan 7, 2020

Revert "[SRP] Add default response status code (#8065)" (#8074)

68831c6

This reverts commit f7475a7.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SRP] Add default response status code #8065

[SRP] Add default response status code #8065

zfchen95 commented Jan 3, 2020

azure-pipelines bot commented Jan 3, 2020

openapi-sdkautomation bot commented Jan 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 3, 2020 •

edited

Loading

azure-pipelines bot commented Jan 3, 2020

azure-pipelines bot commented Jan 3, 2020

weidongxu-microsoft commented Jan 4, 2020

zfchen95 commented Jan 6, 2020

zfchen95 commented Jan 6, 2020

weidongxu-microsoft commented Jan 7, 2020

[SRP] Add default response status code #8065

[SRP] Add default response status code #8065

Conversation

zfchen95 commented Jan 3, 2020

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Jan 3, 2020

openapi-sdkautomation bot commented Jan 3, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Jan 3, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Jan 3, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Jan 3, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Jan 3, 2020 • edited Loading

azure-sdk-for-net - Release

azure-pipelines bot commented Jan 3, 2020

azure-pipelines bot commented Jan 3, 2020

weidongxu-microsoft commented Jan 4, 2020

zfchen95 commented Jan 6, 2020

zfchen95 commented Jan 6, 2020

weidongxu-microsoft commented Jan 7, 2020

openapi-sdkautomation bot commented Jan 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 3, 2020 •

edited

Loading