Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SecurityInsights: Added IoTDevice entity #7934

Merged
merged 2 commits into from
Jan 2, 2020
Merged

SecurityInsights: Added IoTDevice entity #7934

merged 2 commits into from
Jan 2, 2020

Conversation

dosegal
Copy link
Contributor

@dosegal dosegal commented Dec 10, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

3 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci azuresdkci requested a review from lirenhe December 10, 2019 19:51
@dosegal dosegal changed the title Added IoTDevice entity SecurityInsights: Added IoTDevice entity Dec 10, 2019
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 10, 2019 •
edited
Loading

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from ed3a086 with merge commit 4676d91. SDK Automation 13.0.17.20191226.1 
    Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/_security_insights.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_security_insights_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_actions_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_alert_rule_templates_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_alert_rules_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_bookmark_relations_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_bookmarks_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_case_comments_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_case_relations_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_cases_aggregations_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_cases_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_comments_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_data_connectors_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_entities_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_entity_queries_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_office_consents_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_product_settings_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/version.py

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 10, 2019 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 10, 2019 •
edited
Loading

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from ed3a086 with merge commit 4676d91. SDK Automation 13.0.17.20191226.1 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 10, 2019 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 10, 2019 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from ed3a086 with merge commit 4676d91. SDK Automation 13.0.17.20191226.1 
    [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.SecurityInsights [Logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Dec 10, 2019
    Closed
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @lirenhe lirenhe added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 11, 2019
    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @pilor pilor added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed ARMReviewInProgress labels Dec 19, 2019
    @pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 23, 2019
    @dosegal
    Copy link
    Contributor Author

    dosegal commented Dec 29, 2019

    @lirenhe Can you please review this PR?
    Thanks

    @lirenhe lirenhe merged commit 4676d91 into Azure:master Jan 2, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @lirenhe lirenhe lirenhe approved these changes

    @pilor pilor pilor approved these changes

    Assignees

    @lirenhe lirenhe

    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @dosegal @azuresdkci @pilor @lirenhe