[Hub Generated] Review request for Microsoft.WindowsESU to add version preview/2019-09-16-preview #7888

mbialecka · 2019-12-04T01:24:39Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

… type

AutorestCI · 2019-12-04T01:25:53Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#8974

AutorestCI · 2019-12-04T01:26:18Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpzbe6m3kq/rest/specification/windowsesu/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpzbe6m3kq/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '[email protected]/autorest.go@~2.1.137', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest

There is a new version of AutoRest available (2.0.4407).
 > You can install the newer version with with npm install -g autorest@latest

   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4407)
   Including configuration file 'file:///tmp/tmpzbe6m3kq/rest/specification/windowsesu/resource-manager/readme.go.md'
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.137->2.1.137)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
FATAL: System.InvalidOperationException: codegen for preview swagger Microsoft.WindowsESU/preview/2019-09-16-preview/windowsesu.json must be under a preview subdirectory
   at AutoRest.Go.CodeGeneratorGo.<Generate>d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 56
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.Program.<ProcessInternal>d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NewPlugin.<Process>d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Process() cancelled due to exception : Plugin go reported failure.
  Error: Plugin go reported failure.

mbialecka · 2019-12-04T01:28:35Z

The spec was already approved in the private repo:
https://github.com/Azure/azure-rest-api-specs-pr/pull/948
https://github.com/Azure/azure-rest-api-specs-pr/pull/956

azure-pipelines · 2019-12-04T18:26:46Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2019-12-04T18:28:42Z

azure-sdk-for-python - Release

⌛ Pending...

openapi-sdkautomation · 2019-12-04T18:28:42Z

azure-sdk-for-java - Release

⌛ Pending...

openapi-sdkautomation · 2019-12-04T18:28:44Z

azure-sdk-for-go - Release

⌛ Pending...

openapi-sdkautomation · 2019-12-04T18:28:46Z

azure-sdk-for-js - Release

⌛ Pending...

openapi-sdkautomation · 2019-12-04T18:28:47Z

azure-sdk-for-net - Release

⌛ Pending...

azure-pipelines · 2019-12-04T18:41:22Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-04T18:41:22Z

Azure Pipelines successfully started running 1 pipeline(s).

fengzhou-msft · 2019-12-06T01:56:51Z

@NullMDR can you take a look at the Go SDK automation failure?

PhoenixHe-NV · 2019-12-06T02:15:38Z

@ArcturusZhang Could you please take a look at the go generation failure? Seems like the autorest.go has some problem.

specification/windowsesu/resource-manager/readme.go.md

azure-pipelines · 2019-12-06T22:02:11Z

Azure Pipelines successfully started running 1 pipeline(s).

KrisBash

Signing off with a few comments

KrisBash · 2019-12-07T06:08:22Z

.../windowsesu/resource-manager/Microsoft.WindowsESU/preview/2019-09-16-preview/windowsesu.json

+        "location"
+      ],
+      "properties": {
+        "id": {


It's best to carve the common resource properties into a shared definition. Better yet, use an allOf reference to link the common definition from common-types.

azure-rest-api-specs/specification/common-types/resource-management/v1/types.json

Line 45 in a6f41b5

"TrackedResource": {

I've added references to common types

KrisBash · 2019-12-07T06:09:04Z

.../windowsesu/resource-manager/Microsoft.WindowsESU/preview/2019-09-16-preview/windowsesu.json

+            },
+            "installedServerNumber": {
+              "description": "Number of activations/servers using the MAK key.",
+              "type": "integer",


This is user set or read-only?

Set by user on creation, immutable, as most of other properties.

ArcturusZhang

LGTM for the go SDK part

azure-pipelines · 2019-12-09T19:13:29Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2019-12-11T16:13:52Z

Can one of the admins verify this patch?

mbialecka added 9 commits December 3, 2019 16:48

New Readme Config File

9e07159

New Go Language Readme Config File

6c7e04b

New Typescript Language Readme Config File

e144b87

New Python Language Readme Config File

a345db9

New C# Language Readme Config File

ec62f3c

New Ruby Language Readme Config File

c571b32

New Swagger Spec File

2521d83

New Swagger Example Spec File

2bc233a

Add Microsoft.WindowsESU provider and multipleActivationKeys resource…

e2a72c0

… type

azuresdkci assigned fengzhou-msft Dec 4, 2019

AutorestCI mentioned this pull request Dec 4, 2019

[AutoPR windowsesu/resource-manager] [Hub Generated] Review request for Microsoft.WindowsESU to add version preview/2019-09-16-preview Azure/azure-sdk-for-python#8974

Closed

azuresdkci requested a review from fengzhou-msft December 4, 2019 01:25

Add windowsesu to custom-words.txt

af06d40

fengzhou-msft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 6, 2019

ArcturusZhang requested changes Dec 6, 2019

View reviewed changes

specification/windowsesu/resource-manager/readme.go.md Outdated Show resolved Hide resolved

specification/windowsesu/resource-manager/readme.go.md Outdated Show resolved Hide resolved

Fix go sdk configuration; Fix typo

531cf6d

KrisBash approved these changes Dec 7, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 7, 2019

ArcturusZhang approved these changes Dec 9, 2019

View reviewed changes

Use common types

6ce648d

fengzhou-msft merged commit 9ead903 into Azure:master Dec 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.WindowsESU to add version preview/2019-09-16-preview #7888

[Hub Generated] Review request for Microsoft.WindowsESU to add version preview/2019-09-16-preview #7888

mbialecka commented Dec 4, 2019 •

edited

Loading

AutorestCI commented Dec 4, 2019 •

edited

Loading

AutorestCI commented Dec 4, 2019 •

edited

Loading

mbialecka commented Dec 4, 2019

azure-pipelines bot commented Dec 4, 2019

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

azure-pipelines bot commented Dec 4, 2019

azure-pipelines bot commented Dec 4, 2019

fengzhou-msft commented Dec 6, 2019

PhoenixHe-NV commented Dec 6, 2019

azure-pipelines bot commented Dec 6, 2019

KrisBash left a comment

KrisBash Dec 7, 2019

mbialecka Dec 9, 2019

KrisBash Dec 7, 2019

mbialecka Dec 9, 2019

ArcturusZhang left a comment

azure-pipelines bot commented Dec 9, 2019

azuresdkci commented Dec 11, 2019

[Hub Generated] Review request for Microsoft.WindowsESU to add version preview/2019-09-16-preview #7888

[Hub Generated] Review request for Microsoft.WindowsESU to add version preview/2019-09-16-preview #7888

Conversation

mbialecka commented Dec 4, 2019 • edited Loading

Contribution checklist:

AutorestCI commented Dec 4, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Dec 4, 2019 • edited Loading

Automation for azure-sdk-for-go

mbialecka commented Dec 4, 2019

azure-pipelines bot commented Dec 4, 2019

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading

azure-sdk-for-net - Release

azure-pipelines bot commented Dec 4, 2019

azure-pipelines bot commented Dec 4, 2019

fengzhou-msft commented Dec 6, 2019

PhoenixHe-NV commented Dec 6, 2019

azure-pipelines bot commented Dec 6, 2019

KrisBash left a comment

Choose a reason for hiding this comment

KrisBash Dec 7, 2019

Choose a reason for hiding this comment

mbialecka Dec 9, 2019

Choose a reason for hiding this comment

KrisBash Dec 7, 2019

Choose a reason for hiding this comment

mbialecka Dec 9, 2019

Choose a reason for hiding this comment

ArcturusZhang left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented Dec 9, 2019

azuresdkci commented Dec 11, 2019

mbialecka commented Dec 4, 2019 •

edited

Loading

AutorestCI commented Dec 4, 2019 •

edited

Loading

AutorestCI commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading