[Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2019-12-01-preview #7883

jikuma · 2019-12-03T21:49:29Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…e/2019-05-01 to version 2019-12-01-preview

AutorestCI · 2019-12-03T21:51:25Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#8995

AutorestCI · 2019-12-03T22:42:39Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

raych1 · 2019-12-04T00:55:19Z

specification/containerregistry/resource-manager/readme.md

 These are the global settings for the ContainerRegistry API.

 ``` yaml
 openapi-type: arm
-tag: package-2019-06-preview
+tag: package-preview-2019-12


How about follow the yyyy-MM-preview pattern for the tag?

I do not remember changing this file, this file was changed by "OpenApi Hub" on behalf of me.

Thanks for the info. We will log a bug for OpenApi Hub.

raych1 · 2019-12-04T01:38:43Z

@qiaozha , can you please take a look at the JS SDK failures?

qiaozha · 2019-12-04T03:06:35Z

@jikuma This problem occurs because in your readme.md you've already set your default tag package-preview-2019-12. the input file for this tag is Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json. Then in your readme.typescript.md file. you add
`input-file:

Microsoft.ContainerRegistry/stable/2019-05-01/containerregistry.json
Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json
Microsoft.ContainerRegistry/preview/2019-05-01-preview/containerregistry_scopemap.jsonHowever, bothMicrosoft.ContainerRegistry/stable/2019-05-01/containerregistry.jsonandMicrosoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json` have the same operation but the api-version parameter is different. the SDK generator don't know which one to choose. Any particular reason why you put this extra three files in readme.typescript.md?

KrisBash

Please see comments

KrisBash · 2019-12-04T05:27:37Z

...source-manager/Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json

+            }
+          }
+        ],
+        "responses": {


For all API responses in this spec, please add a "default" response to capture error cases. It should have a schema consistent with the common error contract. Here is an example:

azure-rest-api-specs/specification/batch/resource-manager/Microsoft.Batch/stable/2019-08-01/BatchManagement.json

Line 105 in 0cf7026

"default": {

Even if this did not exist in prior versions, let's get it added going forward

The swagger file is auto-generated. I do not think we should edit this file. I think we are missing some decorator on the controller for this. Can you point me to an example?

Secondly, I do not want to make changes to the old controller/api as part of this PR. I will open WI to track these changes.

KrisBash · 2019-12-04T05:30:43Z

...source-manager/Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json

+        }
+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/listUsages": {


Why is this "listUsages" and not /usages? It should follow the contract.

I do not want to make changes to the old controller/api as part of this PR. I will open WI to track these changes.

Can you help me understand why a new version (a preview too) is not a good opportunity to correct issues? I'm not sure what you mean by "old controller/api"

changes the api and made it usages from listUsages

@KrisBash I see that there is a contract to return the resource usages across Azure. But this API is not exactly the contract implementation as the payload is different and back then we didn't have this contract. Also, it loses its ability to call from ARM template if we remove list prefix. We need to evaluate our API usage and then introduce this change. Can we please take this change as a separate item and scope this version to customer managed key scenarios.

KrisBash · 2019-12-04T05:32:00Z

...source-manager/Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json

@@ -0,0 +1,1291 @@
+{


There are a number of nested resource types from the prior version not carried forward. Is that intentional? It's a suboptimal experience for the customer to produce a template to configure a resource if they have to use different API versions to configure different element/sub-resources.

Added the deleted controllers back due to consistency.

PhoenixHe-NV · 2019-12-04T07:51:51Z

/openapi sdkautomation

openapi-sdkautomation · 2019-12-04T07:53:53Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 5c7e7c4 with merge commit e535f7d. SDK Automation 13.0.17.20191213.4
⚠️containerregistry/mgmt/2017-03-01 [Logs]
```
No file is changed.
```
⚠️containerregistry/mgmt/2017-10-01 [Logs]
```
No file is changed.
```
⚠️containerregistry/mgmt/2018-09-01 [Logs]
```
No file is changed.
```
⚠️containerregistry/mgmt/2019-04-01 [Logs]
```
No file is changed.
```
⚠️containerregistry/mgmt/2019-05-01-preview [Logs]
```
No file is changed.
```
⚠️containerregistry/mgmt/2019-05-01 [Logs]
```
No file is changed.
```
⚠️containerregistry/mgmt/2019-06-01-preview [Logs]
```
No file is changed.
```
⚠️preview/containerregistry/mgmt/2016-06-27-preview [Logs]
```
No file is changed.
```
⚠️preview/containerregistry/mgmt/2017-06-01-preview [Logs]
```
No file is changed.
```
⚠️preview/containerregistry/mgmt/2018-02-01 [Logs]
```
No file is changed.
```
️✔️preview/containerregistry/mgmt/2019-12-01-preview [Logs] [Release SDK Changes]
- preview.containerregistry.mgmt.2019-12-01-preview.zip

openapi-sdkautomation · 2019-12-04T07:53:57Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5c7e7c4 with merge commit e535f7d. SDK Automation 13.0.17.20191213.4

Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/256: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 17 Dec 2019 02:36:51 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07EC:2979:A7DFA:1B037C:5DF83F3F","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4746","x-ratelimit-reset":"1576552051","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_containerregistry_mgmt-v2017_06_01_preview@7883","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/261: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 17 Dec 2019 02:36:51 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07E6:4D9A:F7847:254826:5DF83F3F","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4745","x-ratelimit-reset":"1576552051","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_containerregistry_mgmt-v2019_06_01_preview@7883","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/111: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 17 Dec 2019 02:36:52 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07EF:7C52:6ED85:11DF2E:5DF83F3F","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4743","x-ratelimit-reset":"1576552051","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_containerregistry_mgmt-v2016_06_27_preview@7883","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/117: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 17 Dec 2019 02:36:54 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07F0:27B2:B54DA:1BE3C1:5DF83F40","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4735","x-ratelimit-reset":"1576552051","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_containerregistry_mgmt-v2019_04_01@7883","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/257: HttpError, {"name":"HttpError","status":500,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-length":"0","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 17 Dec 2019 02:36:55 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"500 Internal Server Error","strict-transport-security":"max-age=31536000; includeSubdomains; preload","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07E4:307E:B2E92:1CE933:5DF83F3F","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4734","x-ratelimit-reset":"1576552052","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_containerregistry_mgmt-v2017_10_01@7883","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}}}
Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/116: HttpError, {"name":"HttpError","status":500,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-length":"0","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 17 Dec 2019 02:36:55 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"500 Internal Server Error","strict-transport-security":"max-age=31536000; includeSubdomains; preload","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07E8:0BB7:1122CE:288503:5DF83F3F","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4733","x-ratelimit-reset":"1576552052","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_containerregistry_mgmt-v2018_09_01@7883","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}}}
Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/112: HttpError, {"name":"HttpError","status":500,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-length":"0","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 17 Dec 2019 02:36:55 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"500 Internal Server Error","strict-transport-security":"max-age=31536000; includeSubdomains; preload","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07EB:12C0:1051EB:2743B3:5DF83F3F","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4732","x-ratelimit-reset":"1576552052","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_containerregistry_mgmt-v2017_03_01@7883","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}}}
Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/115: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 17 Dec 2019 02:36:55 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07E9:0BB7:1122CE:288505:5DF83F3F","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4731","x-ratelimit-reset":"1576552052","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_containerregistry_mgmt-v2018_02_01_preview@7883","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}

️✔️sdk/containerregistry/mgmt-v2016_06_27_preview [Logs] [Release SDK Changes]
️✔️sdk/containerregistry/mgmt-v2017_03_01 [Logs] [Release SDK Changes]
️✔️sdk/containerregistry/mgmt-v2017_06_01_preview [Logs] [Release SDK Changes]
️✔️sdk/containerregistry/mgmt-v2017_10_01 [Logs] [Release SDK Changes]
️✔️sdk/containerregistry/mgmt-v2018_02_01_preview [Logs] [Release SDK Changes]
️✔️sdk/containerregistry/mgmt-v2018_09_01 [Logs] [Release SDK Changes]
️✔️sdk/containerregistry/mgmt-v2019_04_01 [Logs] [Release SDK Changes]
️✔️sdk/containerregistry/mgmt-v2019_06_01_preview [Logs] [Release SDK Changes]
️✔️sdk/containerregistry/mgmt-v2019_12_01_preview [Logs] [Release SDK Changes]

openapi-sdkautomation · 2019-12-04T07:53:58Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5c7e7c4 with merge commit e535f7d. SDK Automation 13.0.17.20191213.4

Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-net/pull/155: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 17 Dec 2019 02:36:44 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07C0:12C0:1051BC:2742F9:5DF83F3B","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4784","x-ratelimit-reset":"1576552051","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-net/git/refs/heads/sdkAutomation/Microsoft.Azure.Management.ContainerRegistry@7883","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.ContainerRegistry [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.ContainerRegistry.4.0.0.nupkg
- Microsoft.Azure.Management.ContainerRegistry.4.0.0.snupkg

openapi-sdkautomation · 2019-12-04T07:53:59Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5c7e7c4 with merge commit e535f7d. SDK Automation 13.0.17.20191213.4

Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/56: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 17 Dec 2019 02:36:43 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07D1:1F1E:83C82:116939:5DF83F3A","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4795","x-ratelimit-reset":"1576552051","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/azure-mgmt-containerregistry@7883","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}

️✔️azure-mgmt-containerregistry [Logs] [Release SDK Changes]

[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-02-01-preview'} in label v2018_02_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2018-02-01-preview based on label v2018_02_01_preview
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-09-01'} in label v2018_09_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-09-01 based on label v2018_09_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-04-01'} in label v2019_04_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-04-01 based on label v2019_04_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2019-05-01'} in label v2019_05_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01 based on label v2019_05_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-05-01-preview'} in label v2019_05_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01-preview based on label v2019_05_01_preview
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01-preview', '2019-05-01-preview', '2019-05-01'} in label v2019_06_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2019-06-01-preview based on label v2019_06_01_preview
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

openapi-sdkautomation · 2019-12-04T07:54:04Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5c7e7c4 with merge commit e535f7d. SDK Automation 13.0.17.20191213.4

️✔️@azure/arm-containerregistry [Logs] [Release SDK Changes]

azure-arm-containerregistry-7.0.0.tgz

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/containerRegistryManagementClient.js → ./dist/arm-containerregistry.js...
[npmPack] created ./dist/arm-containerregistry.js in 741ms

azure-pipelines · 2019-12-10T23:42:50Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2019-12-11T16:14:01Z

Can one of the admins verify this patch?

KrisBash

Discussed offline. Two issues must be fixed in a future update:

"default" response for all APIs
listUsages normalization to standard /usages contract

raych1 · 2019-12-12T00:58:37Z

@ArcturusZhang , can you have a look at the SDK Go failures and suggest on the fix? Here's the error:

System.InvalidOperationException: codegen for preview swagger Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json must be under a preview subdirectory'

specification/containerregistry/resource-manager/readme.go.md

azure-pipelines · 2019-12-16T21:57:48Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-16T21:57:59Z

Azure Pipelines successfully started running 1 pipeline(s).

jikuma · 2019-12-16T22:17:35Z

Now that all the checks are passing, can we merge this PR?

jikuma added 3 commits December 3, 2019 13:40

Adds base for updating Microsoft.ContainerRegistry from version stabl…

1048592

…e/2019-05-01 to version 2019-12-01-preview

Updates readme

6db6df8

Updates API version in new specs and examples

287e280

azuresdkci assigned raych1 Dec 3, 2019

azuresdkci requested a review from raych1 December 3, 2019 21:50

jikuma added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 3, 2019

AutorestCI mentioned this pull request Dec 3, 2019

[AutoPR containerregistry/resource-manager] [Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2019-12-01-preview Azure/azure-sdk-for-python#8958

Closed

raych1 reviewed Dec 4, 2019

View reviewed changes

KrisBash suggested changes Dec 4, 2019

View reviewed changes

KrisBash added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Dec 4, 2019

reverting changes made to listusages api

2b9d6e6

KrisBash approved these changes Dec 11, 2019

View reviewed changes

KrisBash mentioned this pull request Dec 11, 2019

Microsoft.ContainerRegistry - spec issues to fix #7950

Open

ArcturusZhang requested changes Dec 12, 2019

View reviewed changes

specification/containerregistry/resource-manager/readme.go.md Outdated Show resolved Hide resolved

fixing build failure for go sdk

5c7e7c4

jikuma changed the title ~~[Hub Generated] [Do not merge] Review request for Microsoft.ContainerRegistry to add version preview/2019-12-01-preview~~ [Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2019-12-01-preview Dec 16, 2019

jikuma requested a review from ArcturusZhang December 16, 2019 22:16

raych1 approved these changes Dec 17, 2019

View reviewed changes

ArcturusZhang approved these changes Dec 17, 2019

View reviewed changes

raych1 merged commit e535f7d into Azure:master Dec 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2019-12-01-preview #7883

[Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2019-12-01-preview #7883

jikuma commented Dec 3, 2019

AutorestCI commented Dec 3, 2019 •

edited

Loading

AutorestCI commented Dec 3, 2019 •

edited

Loading

raych1 Dec 4, 2019

jikuma Dec 4, 2019

raych1 Dec 5, 2019

raych1 commented Dec 4, 2019

qiaozha commented Dec 4, 2019

KrisBash left a comment

KrisBash Dec 4, 2019

jikuma Dec 4, 2019 •

edited

Loading

KrisBash Dec 4, 2019

jikuma Dec 4, 2019 •

edited

Loading

KrisBash Dec 5, 2019

jikuma Dec 10, 2019

mnltejaswini Dec 10, 2019

KrisBash Dec 4, 2019

jikuma Dec 4, 2019

PhoenixHe-NV commented Dec 4, 2019

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

azure-pipelines bot commented Dec 10, 2019

azuresdkci commented Dec 11, 2019

KrisBash left a comment

raych1 commented Dec 12, 2019

azure-pipelines bot commented Dec 16, 2019

azure-pipelines bot commented Dec 16, 2019

jikuma commented Dec 16, 2019

[Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2019-12-01-preview #7883

[Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2019-12-01-preview #7883

Conversation

jikuma commented Dec 3, 2019

Contribution checklist:

AutorestCI commented Dec 3, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Dec 3, 2019 • edited Loading

Automation for azure-sdk-for-go

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

raych1 commented Dec 4, 2019

qiaozha commented Dec 4, 2019

KrisBash left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jikuma Dec 4, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jikuma Dec 4, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PhoenixHe-NV commented Dec 4, 2019

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading

azure-sdk-for-js - Release

azure-pipelines bot commented Dec 10, 2019

azuresdkci commented Dec 11, 2019

KrisBash left a comment

Choose a reason for hiding this comment

raych1 commented Dec 12, 2019

azure-pipelines bot commented Dec 16, 2019

azure-pipelines bot commented Dec 16, 2019

jikuma commented Dec 16, 2019

AutorestCI commented Dec 3, 2019 •

edited

Loading

AutorestCI commented Dec 3, 2019 •

edited

Loading

jikuma Dec 4, 2019 •

edited

Loading

jikuma Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading