Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the subscription diagnostic settings API #7873

Merged
merged 7 commits into from
Dec 5, 2019
Merged

Add the subscription diagnostic settings API #7873

merged 7 commits into from
Dec 5, 2019

Conversation

jagadisk
Copy link
Contributor

@jagadisk jagadisk commented Dec 3, 2019 •
edited
Loading

Initial checkin

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Dec 3, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Dec 3, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@fengzhou-msft fengzhou-msft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 3, 2019
KrisBash
KrisBash approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off with comments

...nager/Microsoft.Insights/preview/2017-05-01-preview/subscriptionDiagnosticsSettings_API.json Show resolved Hide resolved
...nager/Microsoft.Insights/preview/2017-05-01-preview/subscriptionDiagnosticsSettings_API.json
}
},
"definitions": {
"SubscriptionProxyOnlyResource": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's redundant to add common definitions here. It can be referenced from another swagger spec, or better yet - the common definitions swagger.

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 4, 2019
@fengzhou-msft
Copy link
Member

@jagadisk let me know if no further changes is needed and I can merge it.

@jagadisk
Copy link
Contributor Author

jagadisk commented Dec 5, 2019 via email

@fengzhou-msft
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 5, 2019 •
edited
Loading

azure-sdk-for-java - Release

⌛ Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 5, 2019 •
edited
Loading

azure-sdk-for-python - Release

⌛ Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 5, 2019 •
edited
Loading

azure-sdk-for-go - Release

⌛ Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 5, 2019 •
edited
Loading

azure-sdk-for-js - Release

⌛ Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 5, 2019 •
edited
Loading

azure-sdk-for-net - Release

⌛ Pending...

This was referenced Dec 5, 2019
Open
Closed
@fengzhou-msft fengzhou-msft merged commit dd08d84 into Azure:master Dec 5, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
@jagadisk @AnuTalluri
Add the subscription diagnostic settings API (Azure#7873)
036d81d
@VeryEarly
Copy link
Contributor

Hi @jagadisk ,

I don't see any differences between this new swagger and
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/monitor/resource-manager/Microsoft.Insights/preview/2017-05-01-preview/diagnosticsSettings_API.json

It looks like you defined two swaggers for one API, can you help understand why is this needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengzhou-msft fengzhou-msft fengzhou-msft approved these changes

@KrisBash KrisBash KrisBash approved these changes

Assignees

@fengzhou-msft fengzhou-msft

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jagadisk @AutorestCI @fengzhou-msft @VeryEarly @KrisBash