Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Salesforce LinkedService Add ApiVersion #7865

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Update Salesforce LinkedService Add ApiVersion #7865

merged 1 commit into from
Dec 3, 2019

Conversation

Jingshu923
Copy link
Contributor

@Jingshu923 Jingshu923 commented Nov 29, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci azuresdkci requested a review from lirenhe November 29, 2019 04:30
@AutorestCI AutorestCI mentioned this pull request Nov 29, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 29, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#8442

@AutorestCI AutorestCI mentioned this pull request Nov 29, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 29, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6468

@lirenhe lirenhe added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 30, 2019
KrisBash
KrisBash approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 2, 2019
@lirenhe lirenhe merged commit 3b49471 into Azure:master Dec 3, 2019
This was referenced Dec 3, 2019
Merged
Merged
lirenhe pushed a commit that referenced this pull request Dec 3, 2019
@Jingshu923 @lirenhe
Revert "Update Salesforce LinkedService Add ApiVersion (#7865)" (#7878)
23e6e54 
This reverts commit 3b49471.
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
@Jingshu923 @AnuTalluri
Update Salesforce LinkedService Add ApiVersion (Azure#7865)
c1983ef
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
@Jingshu923 @AnuTalluri
Revert "Update Salesforce LinkedService Add ApiVersion (Azure#7865)" (A…
fa6bfc5 
…zure#7878)

This reverts commit 3b49471.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lirenhe lirenhe lirenhe approved these changes

@KrisBash KrisBash KrisBash approved these changes

Assignees

@lirenhe lirenhe

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jingshu923 @AutorestCI @KrisBash @lirenhe @Jingshu918