[Hub Generated] Review request for Microsoft.Resources to add version stable/2019-11-01 #7839

ezgambac · 2019-11-25T22:21:55Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…6-01 to version 2019-11-01

AutorestCI · 2019-11-25T22:24:36Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

AutorestCI · 2019-11-25T22:25:10Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

yungezz · 2019-11-28T08:46:40Z

...fication/resources/resource-manager/Microsoft.Resources/stable/2019-11-01/subscriptions.json

+          "type": "string",
+          "description": "The physical location of the Azure location."
+        },
+        "pairedRegion": {


Well, this data shouldn't be modified.

yungezz · 2019-11-28T08:48:08Z

...fication/resources/resource-manager/Microsoft.Resources/stable/2019-11-01/subscriptions.json

+          ],
+          "x-ms-enum": {
+            "name": "SubscriptionState",
+            "modelAsString": false


why modelAsString false? it will cause breaking change in SDK for future updating

That is how it was from the api-version I copied, I think it hasn't been updated since (2019-06-01)

KrisBash

LGTM thanks.

yungezz · 2019-12-04T02:08:37Z

hi @ezgambac is this PR ready to merge? could you pls fix prettiercheck by following instruction at https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#prettier-check?

azure-pipelines · 2019-12-05T23:40:36Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2019-12-05T23:44:40Z

azure-sdk-for-go - Release

⌛ Pending...

openapi-sdkautomation · 2019-12-05T23:44:51Z

azure-sdk-for-java - Release

⌛ Pending...

openapi-sdkautomation · 2019-12-05T23:45:14Z

azure-sdk-for-js - Release

⌛ Pending...

openapi-sdkautomation · 2019-12-05T23:45:48Z

azure-sdk-for-net - Release

⌛ Pending...

ezgambac · 2019-12-05T23:46:04Z

@yungezz Fixed the prettier error, this is good to go.

openapi-sdkautomation · 2019-12-05T23:46:22Z

azure-sdk-for-python - Release

⌛ Pending...

… stable/2019-11-01 (Azure#7839)

jiasli · 2020-02-25T07:01:45Z

specification/resources/resource-manager/readme.md

+```yaml $(tag) == 'package-2019-11'
+input-file:
+  - Microsoft.Resources/stable/2019-11-01/subscriptions.json


Isn't this against the convention? Shouldn't it be package-subscriptions-2019-11?

jiasli · 2020-02-25T08:30:35Z

specification/resources/resource-manager/readme.md

 ``` yaml $(package-deploymentscripts)
-tag: package-deploymentscripts-2019-10-preview
+tag: package-2019-11


Shouldn't these two lines match? In this case, it is package-deploymentscripts -> package-2019-11 -> Microsoft.Resources/stable/2019-11-01/subscriptions.json which isn't a correct mapping.

Randomly removed in Azure#7839 Adjusted paths for Azure/autorest repo reorg

Randomly removed in #7839 Adjusted paths for Azure/autorest repo reorg

Randomly removed in Azure#7839 Adjusted paths for Azure/autorest repo reorg

ezgambac and others added 8 commits November 25, 2019 13:22

Adds base for updating Microsoft.Resources from version stable/2019-0…

4362846

…6-01 to version 2019-11-01

Updates readme

dc40dbc

Updates API version in new specs and examples

37e0751

Updated definition for locations

38349a5

Changed type to enums instead of just strings

ebce335

Added new examples for locations api

8968784

Added missing descriptions

ab86268

Removed .vscode folder

3a9ddf6

ezgambac requested a review from Tiano2017 as a code owner November 25, 2019 22:21

azuresdkci assigned yungezz Nov 25, 2019

azuresdkci requested a review from yungezz November 25, 2019 22:23

Fixed spelling issue

f32d130

ezgambac requested a review from sanjaiganesh November 26, 2019 00:10

yungezz reviewed Nov 28, 2019

View reviewed changes

yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 28, 2019

KrisBash approved these changes Dec 3, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 3, 2019

yungezz approved these changes Dec 4, 2019

View reviewed changes

Fixed GetLocations with prettier tool

8668e09

yungezz merged commit 26bef52 into Azure:master Dec 10, 2019

TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019

[Hub Generated] Review request for Microsoft.Resources to add version…

5b1118e

… stable/2019-11-01 (Azure#7839)

jiasli reviewed Feb 25, 2020

View reviewed changes

jiasli mentioned this pull request Feb 25, 2020

Add package-subscriptions-2019-11 #8503

Merged

nschonni added a commit to nschonni/azure-rest-api-specs that referenced this pull request Jan 26, 2021

chore: Restore .vscode config files

ad15e40

Randomly removed in Azure#7839 Adjusted paths for Azure/autorest repo reorg

PhoenixHe-NV pushed a commit that referenced this pull request Feb 22, 2021

chore: Restore .vscode config files (#12605)

7beaa93

Randomly removed in #7839 Adjusted paths for Azure/autorest repo reorg

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

chore: Restore .vscode config files (Azure#12605)

10c8f61

Randomly removed in Azure#7839 Adjusted paths for Azure/autorest repo reorg

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Resources to add version stable/2019-11-01 #7839

[Hub Generated] Review request for Microsoft.Resources to add version stable/2019-11-01 #7839

ezgambac commented Nov 25, 2019 •

edited

Loading

AutorestCI commented Nov 25, 2019 •

edited

Loading

AutorestCI commented Nov 25, 2019 •

edited

Loading

yungezz Nov 28, 2019

ezgambac Nov 28, 2019

yungezz Nov 28, 2019

ezgambac Nov 28, 2019

KrisBash left a comment

yungezz commented Dec 4, 2019

azure-pipelines bot commented Dec 5, 2019

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

ezgambac commented Dec 5, 2019

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

jiasli Feb 25, 2020

jiasli Feb 25, 2020 •

edited

Loading

[Hub Generated] Review request for Microsoft.Resources to add version stable/2019-11-01 #7839

[Hub Generated] Review request for Microsoft.Resources to add version stable/2019-11-01 #7839

Conversation

ezgambac commented Nov 25, 2019 • edited Loading

Contribution checklist:

AutorestCI commented Nov 25, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Nov 25, 2019 • edited Loading

Automation for azure-sdk-for-go

yungezz Nov 28, 2019

Choose a reason for hiding this comment

ezgambac Nov 28, 2019

Choose a reason for hiding this comment

yungezz Nov 28, 2019

Choose a reason for hiding this comment

ezgambac Nov 28, 2019

Choose a reason for hiding this comment

KrisBash left a comment

Choose a reason for hiding this comment

yungezz commented Dec 4, 2019

azure-pipelines bot commented Dec 5, 2019

openapi-sdkautomation bot commented Dec 5, 2019 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Dec 5, 2019 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Dec 5, 2019 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Dec 5, 2019 • edited Loading

azure-sdk-for-net - Release

ezgambac commented Dec 5, 2019

openapi-sdkautomation bot commented Dec 5, 2019 • edited Loading

azure-sdk-for-python - Release

jiasli Feb 25, 2020

Choose a reason for hiding this comment

jiasli Feb 25, 2020 • edited Loading

Choose a reason for hiding this comment

ezgambac commented Nov 25, 2019 •

edited

Loading

AutorestCI commented Nov 25, 2019 •

edited

Loading

AutorestCI commented Nov 25, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

jiasli Feb 25, 2020 •

edited

Loading