-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing properties for Application and ApplicationDefinition #7803
Conversation
Can one of the admins verify this patch? |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-goA PR has been created for you: |
...on/resources/resource-manager/Microsoft.Solutions/stable/2019-07-01/managedapplications.json
Outdated
Show resolved
Hide resolved
@dandanwang0320 can you please fix the error from PrettierCheck validation? Thanks. |
It says "Igonre" on the PrettierCheck, and it only has the file names, not the actual errors. |
@dandanwang0320 please follow the link within the log to fix it. The link is attached after the file names. Thanks |
|
@dandanwang0320 |
Again, please ignore this and start review the actual changes. |
@NullMDR can you please advise on this? You might need to update the instruction. |
Could you also start the review in the mean time? "Prettier check" shouldn't interfere with your review. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
azure-sdk-for-java - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
...on/resources/resource-manager/Microsoft.Solutions/stable/2019-07-01/managedapplications.json
Show resolved
Hide resolved
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
...on/resources/resource-manager/Microsoft.Solutions/stable/2019-07-01/managedapplications.json
Outdated
Show resolved
Hide resolved
Azure Pipelines successfully started running 1 pipeline(s). |
@xccc-msft Hi, ARM review is done. |
Azure Pipelines successfully started running 1 pipeline(s). |
@NullMDR Some of the model validations are canceled, seems I can't rerun it without making a push. |
/azp run automation - sdk |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks @NullMDR . |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.