Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Provider Share Subscription DTO to include ProviderEmail #7768

Merged
merged 4 commits into from
Nov 21, 2019
Merged

Add Provider Share Subscription DTO to include ProviderEmail #7768

merged 4 commits into from
Nov 21, 2019

Conversation

prchadal
Copy link
Contributor

@prchadal prchadal commented Nov 12, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI AutorestCI mentioned this pull request Nov 12, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Nov 12, 2019 •
edited
Loading

Automation for azure-sdk-for-python

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • search/data-plane/Microsoft.Azure.Search.Service
  • resources/resource-manager
  • search/data-plane/Microsoft.Azure.Search.Service/track1
  • datashare/resource-manager

@AutorestCI AutorestCI mentioned this pull request Nov 12, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Nov 12, 2019 •
edited
Loading

Automation for azure-sdk-for-go

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • search/data-plane/Microsoft.Azure.Search.Service/track1
  • resources/resource-manager
  • datashare/resource-manager
  • search/data-plane/Microsoft.Azure.Search.Service

@azuresdkci azuresdkci requested a review from ChenTanyi November 12, 2019 22:24
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@ChenTanyi ChenTanyi added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 13, 2019
ArcturusZhang
ArcturusZhang requested changes Nov 13, 2019
View reviewed changes
Copy link
Member

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the error in go package output-folder path

ravbhatnagar
ravbhatnagar approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@ravbhatnagar ravbhatnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. signing off.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 13, 2019
@AutorestCI AutorestCI mentioned this pull request Nov 14, 2019
Closed
@ArcturusZhang
Copy link
Member

LGTM on go config files

@ChenTanyi
Copy link
Contributor

@prchadal please fix the CI error. Thanks.

brjohnstmsft
brjohnstmsft reviewed Nov 14, 2019
View reviewed changes
Copy link
Member

@brjohnstmsft brjohnstmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search changes are fine, since they're just whitespace.

@ChenTanyi
Copy link
Contributor

@prchadal I think the "x-ms-discriminator-value" field doesn't need "required" in CI output, maybe I'll need to let ARM review again for the required field. @brjohnstmsft could you review again about these required field?

@brjohnstmsft
Copy link
Member

@ChenTanyi I only reviewed this for the files that are part of my service (Azure Cognitive Search). I have no context on the rest of the changes.

@sarajang
Copy link
Member

@ChenTanyi I only reviewed this for the files that are part of my service (Azure Cognitive Search). I have no context on the rest of the changes.

@ChenTanyi @brjohnstmsft The required part for discriminator is coming from auto rest valdiation. the oav module before 0.20.0 didnt enforce this condition. looks like the CI for PRs got updated with the latest version of oav. Can you please review this PR with that in perspective?

ChenTanyi
ChenTanyi reviewed Nov 19, 2019
View reviewed changes
Copy link
Contributor

@ChenTanyi ChenTanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarajang yeah, I saw the "discriminator" field should be required in CI output, but the field with "x-ms-discriminator-value" doesn't show in it. Therefore, I am wondering whether this field should also be required?
@ravbhatnagar could you review again for the change of required field? Thanks!

...ion/datashare/resource-manager/Microsoft.DataShare/preview/2018-11-01-preview/DataShare.json Show resolved Hide resolved
@ChenTanyi ChenTanyi removed the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 19, 2019
@ChenTanyi ChenTanyi added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 19, 2019
@prchadal prchadal changed the title ARM review ARM review for modifying Provider Share Subscription DTO to include ProviderEmail field Nov 19, 2019
@prchadal prchadal changed the title ARM review for modifying Provider Share Subscription DTO to include ProviderEmail field Add Provider Share Subscription DTO to include ProviderEmail Nov 19, 2019
ryansbenson
ryansbenson approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from ARMs side

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 20, 2019
@prchadal
Copy link
Contributor Author

@ChenTanyi Received ARM sign off, please review for the final merge off.

@ChenTanyi ChenTanyi merged commit f6fcabd into Azure:master Nov 21, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
@prchadal @AnuTalluri
Add Provider Share Subscription DTO to include ProviderEmail (Azure#7768
e0816b4 
)

* ARM review

* modified readme.go.md

* fixing semantic errors

* fixed semantic errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarajang sarajang sarajang left review comments

@ChenTanyi ChenTanyi ChenTanyi approved these changes

@brjohnstmsft brjohnstmsft brjohnstmsft left review comments

@ryansbenson ryansbenson ryansbenson approved these changes

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

@ravbhatnagar ravbhatnagar ravbhatnagar approved these changes

@Tiano2017 Tiano2017 Awaiting requested review from Tiano2017

Assignees

@ChenTanyi ChenTanyi

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@prchadal @AutorestCI @azuresdkci @ArcturusZhang @ChenTanyi @brjohnstmsft @sarajang @ravbhatnagar @ryansbenson