Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Cache to add version preview/2019-07-01-preview #7761

Merged

Conversation

MECHANDR
Copy link
Contributor

@MECHANDR MECHANDR commented Nov 12, 2019

  • Added ReplicasPerMaster property to cache create and update request
  • Added ReplicasPerMaster, instances property to cache create, update and get response
  • Updated API version from 2018-03-01 to 2019-07-01

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@AutorestCI
Copy link

AutorestCI commented Nov 12, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#8797

@AutorestCI
Copy link

AutorestCI commented Nov 12, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Member

@TimLovellSmith TimLovellSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, just a couple clarifications that i think its useful to add.

@zikalino zikalino added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 13, 2019
@TimLovellSmith
Copy link
Member

TimLovellSmith commented Nov 14, 2019

LGTM. Thanks for making these changes!

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 18, 2019
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from ARMs side

@zikalino zikalino merged commit 75738f6 into Azure:master Nov 22, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
…view/2019-07-01-preview (Azure#7761)

* Adds base for updating Microsoft.Cache from version stable/2018-03-01 to version 2019-07-01-preview

* Updates readme

* Updates API version in new specs and examples

* Adding RedisInstanceDetails and ReplicasPerMaster property

* Prettier fixes

* Addressing PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants