-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Cache to add version preview/2019-07-01-preview #7761
[Hub Generated] Review request for Microsoft.Cache to add version preview/2019-07-01-preview #7761
Conversation
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far, just a couple clarifications that i think its useful to add.
specification/redis/resource-manager/Microsoft.Cache/preview/2019-07-01-preview/redis.json
Outdated
Show resolved
Hide resolved
specification/redis/resource-manager/Microsoft.Cache/preview/2019-07-01-preview/redis.json
Outdated
Show resolved
Hide resolved
LGTM. Thanks for making these changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved from ARMs side
…view/2019-07-01-preview (Azure#7761) * Adds base for updating Microsoft.Cache from version stable/2018-03-01 to version 2019-07-01-preview * Updates readme * Updates API version in new specs and examples * Adding RedisInstanceDetails and ReplicasPerMaster property * Prettier fixes * Addressing PR comments
If you are a MSFT employee you can view your work branch via this link.
Contribution checklist: