Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update compute code owner #7476

Merged
merged 2 commits into from
Oct 14, 2019
Merged

update compute code owner #7476

merged 2 commits into from
Oct 14, 2019

Conversation

yungezz
Copy link
Member

@yungezz yungezz commented Oct 14, 2019

Per compute team ask.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Oct 14, 2019

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Oct 14, 2019

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 14, 2019

In Testing, Please Ignore

[Logs] (Generated from e00d605, Iteration 2)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

CODEOWNERS Outdated Show resolved Hide resolved
@huangpf huangpf requested a review from hyonholee October 14, 2019 01:46
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yungezz yungezz requested a review from huangpf October 14, 2019 03:36
@yungezz yungezz merged commit b5c5da5 into master Oct 14, 2019
@yungezz yungezz deleted the yungez-cc branch October 14, 2019 04:09
yungezz added a commit that referenced this pull request Oct 14, 2019
(cherry picked from commit b5c5da5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants