Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes in the examples #7467

Merged
merged 2 commits into from
Oct 12, 2019
Merged

Minor changes in the examples #7467

merged 2 commits into from
Oct 12, 2019

Conversation

chiragg4u
Copy link
Contributor

@chiragg4u chiragg4u commented Oct 11, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Oct 11, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Oct 11, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 11, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from a517830, Iteration 1)

Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Warning Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Succeeded Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • Warning preview/resourcegraph/mgmt/2018-09-01 [Logs]
  • Warning resourcegraph/mgmt/2019-04-01 [Logs]
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • No packages generated.

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Oct 11, 2019
Merged
@azuresdkci azuresdkci requested a review from anuchandy October 11, 2019 17:02
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

yangmsft
yangmsft approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@yangmsft yangmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chiragg4u !

@zikalino zikalino merged commit d2e6ca4 into Azure:master Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangmsft yangmsft yangmsft approved these changes

@zikalino zikalino zikalino approved these changes

@anuchandy anuchandy Awaiting requested review from anuchandy

Assignees

@anuchandy anuchandy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chiragg4u @AutorestCI @azuresdkci @zikalino @yangmsft @anuchandy