Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Backup Version 2019-05-13 addition #7345

Merged
merged 37 commits into from
Oct 10, 2019
Merged

Azure Backup Version 2019-05-13 addition #7345

merged 37 commits into from
Oct 10, 2019

Conversation

SanjayHukumRana
Copy link
Contributor

New api version 2019-05-13 for ProtectedItems_Get,ProtectedItems_CreateOrUpdate,RecoveryPoints_List,RecoveryPoints_Get,Restores_Trigger, BackupJobs_List, BackupProtectedItems_List and version 2017-07-01 for ProtectionPolicies_CreateOrUpdate

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@SanjayHukumRana
Azure Backup Version 2019-05-13 addition
23a8fd7 
New api version 2019-05-13 for ProtectedItems_Get,ProtectedItems_CreateOrUpdate,RecoveryPoints_List,RecoveryPoints_Get,Restores_Trigger, BackupJobs_List, BackupProtectedItems_List and version 2017-07-01 for ProtectionPolicies_CreateOrUpdate
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 27, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 94fc988, Iteration 31)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • Package generation in progress.
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Sep 27, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5992

@AutorestCI
Copy link

AutorestCI commented Sep 27, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7690

@azuresdkci azuresdkci requested a review from lirenhe September 27, 2019 12:51
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Sep 27, 2019
Closed
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@lirenhe
Copy link
Member

lirenhe commented Sep 29, 2019

@SanjayHukumRana , could you take a look at those errors from the checks?

@lirenhe lirenhe added Changes Required WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 29, 2019
@SanjayHukumRana
Update bms.json
6fb5b16 
Fixing inconsistent description for recoverytype across workloads
@SanjayHukumRana
Fixing description for recoveryType enum
aec1a4d
@SanjayHukumRana
Copy link
Contributor Author

SanjayHukumRana commented Sep 29, 2019 via email

@SanjayHukumRana
Copy link
Contributor Author

Hi Renhe Li,

I have updated the PR multiple times but unable to understand this failure in lintdiff.
Can you please thrown some light on this like where it this picking incompatible values and how to fix it?

($.paths[\"/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig\"].patch.operationId)"\n}\nProcess() cancelled due to exception : '$.definitions.AzureFileShareRestoreRequest.properties.recoveryType.enum' has incompatible values (---\n- Invalid\n- OriginalLocation\n- AlternateLocation\n- RestoreDisks\n- Offline\n, ---\n- Invalid\n- OriginalLocation\n- AlternateLocation\n- RestoreDisks\n).\n{\n "Channel": "fatal",\n "Text": "swagger-document/compose - FAILED"\n},\n{\n "Channel": "fatal",\n "Text": "Error: '$.definitions.AzureFileShareRestoreRequest.properties.recoveryType.enum' has incompatible values (---\n- Invalid\n- OriginalLocation\n- AlternateLocation\n- RestoreDisks\n- Offline\n, ---\n- Invalid\n- OriginalLocation\n- AlternateLocation\n- RestoreDisks\n)."\n}\n(node:5399) UnhandledPromiseRejectionWarning: Error: '$.definitions.AzureFileShareRestoreRequest.properties.recoveryType.enum' has incompatible values (---\n- Invalid\n- OriginalLocation\n- AlternateLocation\n- RestoreDisks\n- Offline\n, ---\n- Invalid\n- OriginalLocation\n- AlternateLocation\n- RestoreDisks\n).\n at Merge (/home/vsts/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/lib/source-map/merging.js:58:11)\n at Merge (/home/vsts/.autorest/@microsoft.azure_autorest-co

Thanks.

This was referenced Sep 30, 2019
Closed
Merged
@ryansbenson
Copy link
Contributor

I added ARMReviewMeetingRequired to track the conversation with John Gossman and Mark Simms. Once direction is resolved with them, I'll review the changes as the PR could change drastically.

@ryansbenson
Copy link
Contributor

John Gossman approved the full deprecation of the api version.

ryansbenson
ryansbenson reviewed Oct 2, 2019
View reviewed changes
...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2016-12-01/bms.json Outdated Show resolved Hide resolved
...t.RecoveryServices/stable/2016-12-01/examples/AzureIaasVm/ProtectedItemOperationResults.json Show resolved Hide resolved
...-manager/Microsoft.RecoveryServices/stable/2017-07-01/examples/Common/TriggerExportJobs.json Show resolved Hide resolved
...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2019-05-13/bms.json Show resolved Hide resolved
...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2019-05-13/bms.json Show resolved Hide resolved
...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2019-05-13/bms.json Show resolved Hide resolved
...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2019-05-13/bms.json Outdated Show resolved Hide resolved
...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2019-05-13/bms.json Outdated Show resolved Hide resolved
...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2019-05-13/bms.json Show resolved Hide resolved
...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2019-05-13/bms.json Outdated Show resolved Hide resolved
@ryansbenson ryansbenson added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed ARMReviewInProgress labels Oct 2, 2019
@AutorestCI AutorestCI mentioned this pull request Oct 8, 2019
Merged
ryansbenson
ryansbenson reviewed Oct 8, 2019
View reviewed changes
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is one last change that was missed.

...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2016-12-01/bms.json Show resolved Hide resolved
ryansbenson
ryansbenson reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from ARMs side

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 9, 2019
@lirenhe lirenhe merged commit e133429 into Azure:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryansbenson ryansbenson ryansbenson left review comments

@anubhms anubhms anubhms left review comments

@adit-t adit-t adit-t left review comments

@lirenhe lirenhe lirenhe approved these changes

Assignees

@lirenhe lirenhe

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SanjayHukumRana @AutorestCI @azuresdkci @lirenhe @ryansbenson @adit-t @anubhms @AditTulasi