Databox stable/2019-09-01 API Version #7317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Testing, Please Ignore[Logs] (Generated from b08d7b9, Iteration 5)
|
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
|
Can one of the admins verify this patch? |
nschonni
reviewed
Sep 26, 2019
| "values": [ | ||
| { | ||
| "value": "NotStarted", | ||
| "description": "Data copy hasnt started yet." |
There was a problem hiding this comment.
Suggested change
| "description": "Data copy hasnt started yet." | |
| "description": "Data copy hasn't started yet." |
| "properties": { | ||
| "expectedDataSizeInTeraBytes": { | ||
| "format": "int32", | ||
| "description": "The expected size of the data, which needs to be transfered in this job, in tera bytes.", |
There was a problem hiding this comment.
Suggested change
| "description": "The expected size of the data, which needs to be transfered in this job, in tera bytes.", | |
| "description": "The expected size of the data, which needs to be transferred in this job, in terabytes.", |
| } | ||
| ], | ||
| "properties": { | ||
| "expectedDataSizeInTeraBytes": { |
There was a problem hiding this comment.
Suggested change
| "expectedDataSizeInTeraBytes": { | |
| "expectedDataSizeInTerabytes": { |
| "properties": { | ||
| "expectedDataSizeInTeraBytes": { | ||
| "format": "int32", | ||
| "description": "The expected size of the data, which needs to be transfered in this job, in tera bytes.", |
There was a problem hiding this comment.
Suggested change
| "description": "The expected size of the data, which needs to be transfered in this job, in tera bytes.", | |
| "description": "The expected size of the data, which needs to be transferred in this job, in terabytes.", |
| ], | ||
| "type": "object", | ||
| "properties": { | ||
| "expectedDataSizeInTeraBytes": { |
There was a problem hiding this comment.
Suggested change
| "expectedDataSizeInTeraBytes": { | |
| "expectedDataSizeInTerabytes": { |
| "DiskScheduleAvailabilityRequest": { | ||
| "description": "Request body to get the availability for scheduling disk orders.", | ||
| "required": [ | ||
| "expectedDataSizeInTeraBytes", |
There was a problem hiding this comment.
Suggested change
| "expectedDataSizeInTeraBytes", | |
| "expectedDataSizeInTerabytes", |
| "readOnly": true | ||
| }, | ||
| "returnPackage": { | ||
| "$ref": "#/def |
There was a problem hiding this comment.
Suggested change
| "$ref": "#/def | |
| "description": "Identify request and response of active job limit for SKU availability." |
michaeljqzq
added
the
WaitForARMFeedback
|
Signing off from ARM side. |
ravbhatnagar
added
ARMSignedOff
|
HI @sashanm is this PR ready to merge? |
|
@yungezz Yes. It is ready to merge |
yungezz
approved these changes
Sep 27, 2019
This was referenced Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.