Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFactory] Changing arguments to object to support oneOf - this will allow param… #7295

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

hvermis
Copy link
Contributor

@hvermis hvermis commented Sep 23, 2019

…eterization

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 23, 2019

In Testing, Please Ignore

[Logs] (Generated from 4b2da94, Iteration 1)

Succeeded .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Failed datafactory/resource-manager/v2017_09_01_preview [Logs] [Generation PR]
  • Failed datafactory/resource-manager/v2018_06_01 [Logs]
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • In-Progress datafactory/mgmt/2018-06-01 [Logs]
  • In-Progress preview/datafactory/mgmt/2017-09-01-preview [Logs]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • No packages generated.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 23, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7705

@AutorestCI
Copy link

AutorestCI commented Sep 23, 2019

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5918

@anuchandy
Copy link
Member

@hvermis this seems a SDK breaking change, marked with "Breaking Change Tag". Since over the wire service returns new types (not just arrays), I've requested "ARM Review".

@hvermis
Copy link
Contributor Author

hvermis commented Sep 24, 2019

It's not breaking since the type is being changed to object, which means anything can get assigned to it.

@ravbhatnagar
Copy link
Contributor

@hvermis it seemed like earlier you allowed an array of these objects but now only allow single object. If I am reading the change correctly. Can you confirm?

@ravbhatnagar ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 28, 2019
@hvermis
Copy link
Contributor Author

hvermis commented Oct 1, 2019

@ravbhatnagar Anything can be assigned to object, that also includes array of objects. So now both an Expression and array can be assign to it, while before only array could be assigned.

@hvermis
Copy link
Contributor Author

hvermis commented Oct 3, 2019

@ravbhatnagar Can you please take a look at my response?

@ravbhatnagar
Copy link
Contributor

Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants