-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataFactory] Changing arguments to object to support oneOf - this will allow param… #7295
Conversation
In Testing, Please Ignore[Logs] (Generated from 4b2da94, Iteration 1).NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
@hvermis this seems a SDK breaking change, marked with "Breaking Change Tag". Since over the wire service returns new types (not just arrays), I've requested "ARM Review". |
It's not breaking since the type is being changed to object, which means anything can get assigned to it. |
@hvermis it seemed like earlier you allowed an array of these objects but now only allow single object. If I am reading the change correctly. Can you confirm? |
@ravbhatnagar Anything can be assigned to object, that also includes array of objects. So now both an Expression and array can be assign to it, while before only array could be assigned. |
@ravbhatnagar Can you please take a look at my response? |
Signing off from ARM side. |
…eterization
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.