Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the description for VM redeploy operation #7294

Merged
merged 3 commits into from
Sep 30, 2019

Conversation

dochung4
Copy link
Contributor

@dochung4 dochung4 commented Sep 23, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 23, 2019

In Testing, Please Ignore

[Logs] (Generated from 5ab320c, Iteration 8)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Failed compute/resource-manager/v2017_03_30 [Logs]
  • Failed compute/resource-manager/v2017_09_01 [Logs]
  • Failed compute/resource-manager/v2017_12_01 [Logs]
  • Failed compute/resource-manager/v2018_04_01 [Logs]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • In-Progress compute/mgmt/2015-06-15 [Logs]
  • In-Progress compute/mgmt/2016-03-30 [Logs]
  • In-Progress compute/mgmt/2017-03-30 [Logs]
  • In-Progress compute/mgmt/2017-09-01 [Logs]
  • In-Progress compute/mgmt/2017-12-01 [Logs]
  • In-Progress compute/mgmt/2018-04-01 [Logs]
  • In-Progress compute/mgmt/2018-06-01 [Logs]
  • In-Progress compute/mgmt/2018-10-01 [Logs]
  • In-Progress compute/mgmt/2019-03-01 [Logs]
  • In-Progress compute/mgmt/2019-07-01 [Logs]
  • In-Progress containerservice/mgmt/2016-03-30 [Logs]
  • In-Progress containerservice/mgmt/2016-09-30 [Logs]
  • In-Progress containerservice/mgmt/2017-01-31 [Logs]
  • In-Progress preview/compute/mgmt/2016-04-30-preview [Logs]
  • In-Progress preview/containerservice/mgmt/2015-11-01-preview [Logs]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@dochung4 dochung4 changed the title Redeploy Improve the description for VM redeploy operation Sep 23, 2019
@azuresdkci azuresdkci requested a review from Juliehzl September 23, 2019 20:19
@AutorestCI
Copy link

AutorestCI commented Sep 23, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7485

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 23, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5922

Copy link
Contributor

@Juliehzl Juliehzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make CI check pass first?

@dochung4
Copy link
Contributor Author

Can you make CI check pass first?

Hi Julie, by CI check, are you referring to public.rest-api-specs check that failed?

It failed because of the following error:

Following response status codes "200" for operation "Images_CreateOrUpdate"
were present in the swagger spec, however they were not present in
x-ms-examples. Please provide them.

We have a separate bug filed to add an example for Images_CreateOrUpdate, and someone else in my team will work on it soon. Meanwhile, since this PR only updates the description, in my opinion, the missing example for Images_CreateOrUpdate should not be a blocker for this PR. But please let me know if you think otherwise.

@dochung4 dochung4 requested a review from Juliehzl September 24, 2019 03:50
@Juliehzl
Copy link
Contributor

Hi @dochung4, I have approved from swagger specification side. It will be better for your team member to contribute to this PR and make CI agree. If you have very urgent deadline to make this PR merged, you need to create an issue and assign yourself or your team member to track this problem.

@dochung4
Copy link
Contributor Author

Hi @dochung4, I have approved from swagger specification side. It will be better for your team member to contribute to this PR and make CI agree. If you have very urgent deadline to make this PR merged, you need to create an issue and assign yourself or your team member to track this problem.

Hi @Juliehzl, I added examples, and I believe all checks are passing now. Can you please help merging the PR, if you don't have further comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants