-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the description for VM redeploy operation #7294
Conversation
In Testing, Please Ignore[Logs] (Generated from 5ab320c, Iteration 8).NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
|
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make CI check pass first?
Hi Julie, by CI check, are you referring to public.rest-api-specs check that failed? It failed because of the following error: Following response status codes "200" for operation "Images_CreateOrUpdate" We have a separate bug filed to add an example for Images_CreateOrUpdate, and someone else in my team will work on it soon. Meanwhile, since this PR only updates the description, in my opinion, the missing example for Images_CreateOrUpdate should not be a blocker for this PR. But please let me know if you think otherwise. |
Hi @dochung4, I have approved from swagger specification side. It will be better for your team member to contribute to this PR and make CI agree. If you have very urgent deadline to make this PR merged, you need to create an issue and assign yourself or your team member to track this problem. |
Hi @Juliehzl, I added examples, and I believe all checks are passing now. Can you please help merging the PR, if you don't have further comments? |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.