Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos DB Private Link Resources Swagger #7249

Merged
merged 5 commits into from
Oct 7, 2019

Conversation

ayanMSFT
Copy link
Contributor

@ayanMSFT ayanMSFT commented Sep 18, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 18, 2019

@AutorestCI
Copy link

AutorestCI commented Sep 18, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7552

@AutorestCI
Copy link

AutorestCI commented Sep 18, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@ravbhatnagar
Copy link
Contributor

Looks good. signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 25, 2019
@raych1
Copy link
Member

raych1 commented Sep 25, 2019

@ayanMSFT , please ping me when it's ready to merge.

@yungezz yungezz added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 26, 2019
@shurd shurd mentioned this pull request Sep 26, 2019
5 tasks
@ayanMSFT
Copy link
Contributor Author

@raych1 This change is ready to merge

@ayanMSFT ayanMSFT changed the title [DO NOT MERGE] Cosmos DB Private Link Resources Swagger Cosmos DB Private Link Resources Swagger Oct 1, 2019
@raych1 raych1 removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants