VMSS: exposing the `requireGuestProvisionSignal` field for `2019-03-01` #7246

tombuildsstuff · 2019-09-18T11:18:20Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Noticed this field was being sent across the wire but isn't in the Swagger:

{
	"name": "tom-dev3",
	"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/tom-vmss-linux-dev/providers/Microsoft.Compute/virtualMachineScaleSets/tom-dev3",
	"type": "Microsoft.Compute/virtualMachineScaleSets",
	"location": "westeurope",
	"tags": {},
	"sku": {
		"name": "Standard_F2",
		"tier": "Standard",
		"capacity": 3
	},
	"properties": {
		"singlePlacementGroup": false,
		"upgradePolicy": {
			"mode": "Manual"
		},
		"virtualMachineProfile": {
			"osProfile": {
				"computerNamePrefix": "tomdev",
				"adminUsername": "tharvey",
				"linuxConfiguration": {
					"disablePasswordAuthentication": true,
					"ssh": {
						"publicKeys": [{
							"path": "/home/tharvey/.ssh/authorized_keys",
							"keyData": "XXXXX"
						}]
					},
					"provisionVMAgent": true
				},
				"secrets": [],
				"allowExtensionOperations": true,
				"requireGuestProvisionSignal": true
			},
			"storageProfile": {
				"osDisk": {
					"createOption": "FromImage",
					"caching": "ReadWrite",
					"writeAcceleratorEnabled": false,
					"managedDisk": {
						"storageAccountType": "Standard_LRS"
					}
				},
				"imageReference": {
					"publisher": "Canonical",
					"offer": "UbuntuServer",
					"sku": "16.04-LTS",
					"version": "latest"
				}
			},
			"networkProfile": {
				"networkInterfaceConfigurations": [{
					"name": "example",
					"properties": {
						"primary": true,
						"enableAcceleratedNetworking": false,
						"dnsSettings": {
							"dnsServers": []
						},
						"enableIPForwarding": false,
						"ipConfigurations": [{
							"name": "internal",
							"properties": {
								"primary": true,
								"subnet": {
									"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/tom-vmss-linux-dev/providers/Microsoft.Network/virtualNetworks/tom-vmss-linux-vnet/subnets/internal"
								},
								"privateIPAddressVersion": "IPv4"
							}
						}]
					}
				}]
			},
			"priority": "Regular"
		},
		"provisioningState": "Failed",
		"overprovision": false,
		"doNotRunExtensionsOnOverprovisionedVMs": false,
		"uniqueId": "24e91467-72b2-4cd8-94b9-c225e363692a",
		"platformFaultDomainCount": 0
	}
}

openapi-sdkautomation · 2019-09-18T11:18:23Z

In Testing, Please Ignore

[Logs] (Generated from 69cac3e, Iteration 4)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

Microsoft.Azure.Management.Compute [Logs] [Instructions] [Generation PR] [Integration PR]
- Microsoft.Azure.Management.Compute.29.1.0.nupkg
- Microsoft.Azure.Management.Compute.29.1.0.snupkg

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-compute [Logs] [Instructions] [Generation PR]
- azure-mgmt-compute-8.0.0.zip
- azure_mgmt_compute-8.0.0-py2.py3-none-any.whl

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

compute/resource-manager/v2017_03_30 [Logs]
compute/resource-manager/v2017_09_01 [Logs]
compute/resource-manager/v2017_12_01 [Logs]
compute/resource-manager/v2018_04_01 [Logs]

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-compute [Logs] [Instructions] [Generation PR]
- azure-arm-compute-11.0.0.tgz

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

compute/mgmt/2015-06-15 [Logs] [Instructions] [Generation PR]
- compute.mgmt.2015-06-15.zip
compute/mgmt/2016-03-30 [Logs] [Instructions] [Generation PR]
- compute.mgmt.2016-03-30.zip
compute/mgmt/2017-03-30 [Logs] [Instructions] [Generation PR]
- compute.mgmt.2017-03-30.zip
compute/mgmt/2017-09-01 [Logs] [Instructions] [Generation PR]
- compute.mgmt.2017-09-01.zip
compute/mgmt/2017-12-01 [Logs] [Instructions] [Generation PR]
- compute.mgmt.2017-12-01.zip
compute/mgmt/2018-04-01 [Logs] [Instructions] [Generation PR]
- compute.mgmt.2018-04-01.zip
compute/mgmt/2018-06-01 [Logs] [Instructions] [Generation PR]
- compute.mgmt.2018-06-01.zip
compute/mgmt/2018-10-01 [Logs] [Instructions] [Generation PR]
- compute.mgmt.2018-10-01.zip
compute/mgmt/2019-03-01 [Logs] [Instructions] [Generation PR]
- compute.mgmt.2019-03-01.zip
compute/mgmt/2019-07-01 [Logs]
containerservice/mgmt/2016-03-30 [Logs]
containerservice/mgmt/2016-09-30 [Logs]
containerservice/mgmt/2017-01-31 [Logs]
preview/compute/mgmt/2016-04-30-preview [Logs]
preview/containerservice/mgmt/2015-11-01-preview [Logs]

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

azure_sdk [Logs] [Instructions]
- azure_sdk-0.19.7.gem

azuresdkci · 2019-09-18T11:20:22Z

Can one of the admins verify this patch?

AutorestCI · 2019-09-18T11:21:16Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7859

AutorestCI · 2019-09-18T11:24:04Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6019

specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json

ravbhatnagar · 2019-09-24T06:43:46Z

Signing off frm ARM side. Since this property has existed on the service side in this api-version.

yungezz · 2019-09-25T01:28:29Z

hi @tombuildsstuff could you pls fix CI failure then the PR could be merged?
Here is error reference for Semantic and ModelValidation: https://github.com/Azure/adx-documentation-pr/wiki/Semantic-and-Model-Violations-Reference

tombuildsstuff · 2019-09-25T08:04:05Z

@yungezz unfortunately that link returns a 404:

yungezz · 2019-09-25T09:23:06Z

@tombuildsstuff don't worry, we're trying to find a public place for the doc.

tombuildsstuff · 2019-09-25T09:32:04Z

@yungezz all good - I've opened #7315 to see if that can be OSS'd

In the meantime, what's the best path to proceed with this?

yungezz · 2019-09-25T09:39:11Z

offline version for reference.
Semantic and Model Violations Reference.zip

yungezz · 2019-10-08T03:05:04Z

hi @tombuildsstuff any update on the PR?

yungezz · 2019-10-11T06:17:43Z

HI @tombuildsstuff could you pls fix CI failure?

raych1 · 2019-10-14T08:10:11Z

@tombuildsstuff , compute.json is not a valid JSON which failed the CI checks. Please fix JSON then re-run the checks.


error: 

code: JSON_PARSE

message: The file is not a valid JSON file.

error:

  kind: structure

  code: unexpected token

  position:

    line: 6950

    column: 7

  token: '}'

  message: 'unexpected token, token: }, line: 6950, column: 7'

  url: >-


    /home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json

level: Error

VMSS: exposing the requireGuestProvisionSignal field for 2019-03-01

bb5d0ed

tombuildsstuff requested review from huangpf and hyonholee as code owners September 18, 2019 11:18

azuresdkci assigned yungezz Sep 18, 2019

azuresdkci requested a review from yungezz September 18, 2019 11:19

openapi-sdkautomation bot mentioned this pull request Sep 18, 2019

[AutoPR compute/resource-manager/v2017_03_30] VMSS: exposing the requireGuestProvisionSignal field for 2019-03-01 test-repo-billy/azure-sdk-for-java#409

Closed

yungezz reviewed Sep 19, 2019

View reviewed changes

specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json Show resolved Hide resolved

yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 19, 2019

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 24, 2019

tombuildsstuff mentioned this pull request Sep 25, 2019

Open Source the Wiki required for contributing to API Specifications #7315

Closed

yungezz closed this Oct 14, 2019

yungezz reopened this Oct 14, 2019

openapi-sdkautomation bot mentioned this pull request Oct 14, 2019

[AutoPR compute/resource-manager/v2017_03_30] VMSS: exposing the requireGuestProvisionSignal field for 2019-03-01 test-repo-billy/azure-sdk-for-java#536

Closed

fixing the build

69cac3e

tombuildsstuff force-pushed the f/vmss-signal branch from 0e60fa1 to 69cac3e Compare October 14, 2019 08:09

openapi-sdkautomation bot mentioned this pull request Oct 14, 2019

[AutoPR Microsoft.Azure.Management.Compute] VMSS: exposing the requireGuestProvisionSignal field for 2019-03-01 test-repo-billy/azure-sdk-for-net#308

Merged

removing the example

23177e6

yungezz approved these changes Oct 14, 2019

View reviewed changes

yungezz merged commit c88d4cc into Azure:master Oct 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VMSS: exposing the `requireGuestProvisionSignal` field for `2019-03-01` #7246

VMSS: exposing the `requireGuestProvisionSignal` field for `2019-03-01` #7246

tombuildsstuff commented Sep 18, 2019

openapi-sdkautomation bot commented Sep 18, 2019 •

edited

Loading

azuresdkci commented Sep 18, 2019

AutorestCI commented Sep 18, 2019 •

edited

Loading

AutorestCI commented Sep 18, 2019 •

edited

Loading

ravbhatnagar commented Sep 24, 2019

yungezz commented Sep 25, 2019

tombuildsstuff commented Sep 25, 2019

yungezz commented Sep 25, 2019

tombuildsstuff commented Sep 25, 2019

yungezz commented Sep 25, 2019

yungezz commented Oct 8, 2019

yungezz commented Oct 11, 2019

raych1 commented Oct 14, 2019

VMSS: exposing the requireGuestProvisionSignal field for 2019-03-01 #7246

VMSS: exposing the requireGuestProvisionSignal field for 2019-03-01 #7246

Conversation

tombuildsstuff commented Sep 18, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Sep 18, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from 69cac3e, Iteration 4)

azuresdkci commented Sep 18, 2019

AutorestCI commented Sep 18, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Sep 18, 2019 • edited Loading

Automation for azure-sdk-for-go

ravbhatnagar commented Sep 24, 2019

yungezz commented Sep 25, 2019

tombuildsstuff commented Sep 25, 2019

yungezz commented Sep 25, 2019

tombuildsstuff commented Sep 25, 2019

yungezz commented Sep 25, 2019

yungezz commented Oct 8, 2019

yungezz commented Oct 11, 2019

raych1 commented Oct 14, 2019

VMSS: exposing the `requireGuestProvisionSignal` field for `2019-03-01` #7246

VMSS: exposing the `requireGuestProvisionSignal` field for `2019-03-01` #7246

openapi-sdkautomation bot commented Sep 18, 2019 •

edited

Loading

AutorestCI commented Sep 18, 2019 •

edited

Loading

AutorestCI commented Sep 18, 2019 •

edited

Loading