Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACR] Scope map updates #7223

Merged
merged 2 commits into from
Sep 18, 2019
Merged

[ACR] Scope map updates #7223

merged 2 commits into from
Sep 18, 2019

Conversation

ankurkhemani
Copy link
Contributor

Fix ambiguous Status enum. This was a typo, changed to TokenStatus

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 16, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 604a599, Iteration 2)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI AutorestCI mentioned this pull request Sep 16, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 16, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6915

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Sep 17, 2019
Merged
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Sep 17, 2019
Closed
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@ankurkhemani
Copy link
Contributor Author

ankurkhemani commented Sep 17, 2019 •
edited
Loading

@zikalino @michaeljqzq Can you please help merge? Thanks!

@AutorestCI AutorestCI mentioned this pull request Sep 17, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 17, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5809

@michaeljqzq michaeljqzq merged commit 7685f61 into Azure:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljqzq michaeljqzq michaeljqzq approved these changes

Assignees

@michaeljqzq michaeljqzq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ankurkhemani @AutorestCI @azuresdkci @michaeljqzq