Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove http scheme from Datalake storage #7213

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

sarangan12
Copy link
Contributor

In DataLake Storage Swagger, two schemes are mentioned: http and https. Because of this Autorest(V2) ignores the https and uses only http. The default auth mechanism used in our SDK is the Token Credentials which uses only https scheme. So, the requests are failing in our SDKs(irrespective of the language). So, this PR has been created to remove the http scheme

@sarangan12 sarangan12 requested a review from junhuagu September 13, 2019 23:03
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 13, 2019

In Testing, Please Ignore

[Logs] (Generated from 71ac8de, Iteration 1)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

@AutorestCI
Copy link

AutorestCI commented Sep 13, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 13, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@mmyyrroonn
Copy link
Contributor

@sarangan12 Hello. Does Autorest(v2) depend on the order to choose the https or http? @junhuagu I don't know the context for this. Could you please review this PR?

Copy link
Contributor

@junhuagu junhuagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sarangan12 sarangan12 merged commit df2d7c7 into Azure:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants