Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Microsoft.VMwareCloudSimple provider schema #7209

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Update Microsoft.VMwareCloudSimple provider schema #7209

merged 1 commit into from
Oct 1, 2019

Conversation

mpoliako
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 13, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 5a3ab7c, Iteration 10)

Warning Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.

@msftclas
Copy link

msftclas commented Sep 13, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@AutorestCI AutorestCI mentioned this pull request Sep 13, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 13, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7529

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Sep 13, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 13, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Sep 13, 2019
Merged
@mpoliako mpoliako force-pushed the feature/update_clodusimple_swagger branch from 034f5ef to 6306ffb Compare September 13, 2019 15:12
@jhendrixMSFT jhendrixMSFT added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required Breaking Change Review labels Sep 13, 2019
@jhendrixMSFT
Copy link
Member

Note that this PR introduces several breaking changes in an API version marked as stable and will require approval from ARM.

@mpoliako mpoliako force-pushed the feature/update_clodusimple_swagger branch 5 times, most recently from 82f7832 to 1a47e15 Compare September 16, 2019 09:15
@mpoliako
Copy link
Contributor Author

Note that this PR introduces several breaking changes in an API version marked as stable and will require approval from ARM.

I fixed code, could you please check if it still have breaking changes

@jhendrixMSFT
Copy link
Member

Changing operation IDs is a breaking change for SDKs as it changes the client type names and their methods.
Also changing regionId parameter location from client to method is an SDK breaking change.
We won't prevent you from making these changes however we track breaking changes and report them in fundamentals. Please let me know how you want to proceed.

@mpoliako
Copy link
Contributor Author

Changing operation IDs is a breaking change for SDKs as it changes the client type names and their methods.
Also changing regionId parameter location from client to method is an SDK breaking change.
We won't prevent you from making these changes however we track breaking changes and report them in fundamentals. Please let me know how you want to proceed.

I would like to proceed.
These changes are done on request of Microsoft Team that generates cli client for Cloudsimple API.
No one other uses clients for today

Thank you

@tenmozes tenmozes changed the title Update Microsoft.VMwareCloudSimple provider schema [DO NOT MERGE] Update Microsoft.VMwareCloudSimple provider schema Sep 16, 2019
majastrz
majastrz approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RP owners confirmed that scope of breaking changes is limited in scope and manageable. Signing off from ARM side.

@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 17, 2019
@jhendrixMSFT
Copy link
Member

Please let me know when this is safe to merge.

@mpoliako mpoliako force-pushed the feature/update_clodusimple_swagger branch from 1a47e15 to 5a3ab7c Compare September 20, 2019 11:20
@yungezz yungezz added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 26, 2019
@mpoliako mpoliako changed the title [DO NOT MERGE] Update Microsoft.VMwareCloudSimple provider schema Update Microsoft.VMwareCloudSimple provider schema Sep 27, 2019
@tenmozes tenmozes removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 27, 2019
@mpoliako
Copy link
Contributor Author

mpoliako commented Oct 1, 2019

@jhendrixMSFT could you please merge this pull request.
As of now new version of Cloudsimple is already in production

@jhendrixMSFT jhendrixMSFT merged commit fd35ab4 into Azure:master Oct 1, 2019
@AutorestCI AutorestCI mentioned this pull request Oct 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@majastrz majastrz majastrz approved these changes

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@ravbhatnagar ravbhatnagar Awaiting requested review from ravbhatnagar

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mpoliako @msftclas @AutorestCI @azuresdkci @jhendrixMSFT @nschonni @majastrz @tenmozes @yungezz