Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Capacity to add version preview/2019-04-01 #7206

Merged
merged 6 commits into from
Sep 19, 2019
Merged

[Hub Generated] Review request for Microsoft.Capacity to add version preview/2019-04-01 #7206

merged 6 commits into from
Sep 19, 2019

Conversation

Shads
Copy link
Contributor

@Shads Shads commented Sep 12, 2019 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 12, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from cac9783, Iteration 6)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • In-Progress preview/reservations/mgmt/2018-06-01 [Logs]
  • In-Progress preview/reservations/mgmt/2019-04-01 [Logs]
  • In-Progress reservations/mgmt/2017-11-01 [Logs]
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • Package generation in progress.

@AutorestCI
Copy link

AutorestCI commented Sep 12, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7362

@AutorestCI
Copy link

AutorestCI commented Sep 12, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5823

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

This was referenced Sep 12, 2019
Merged
Merged
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Sep 13, 2019
Merged
@ArcturusZhang ArcturusZhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 14, 2019
ArcturusZhang
ArcturusZhang requested changes Sep 14, 2019
View reviewed changes
Copy link
Member

@ArcturusZhang ArcturusZhang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments I left, and please wait for ARM team's feedback

@Shads
Copy link
Contributor Author

Shads commented Sep 17, 2019

Please see the comments I left, and please wait for ARM team's feedback

I have removed the change flagged as breaking, is ARM review still required?

majastrz
majastrz reviewed Sep 18, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some questions. Can you take a look?

majastrz
majastrz approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 18, 2019
@Shads Shads requested a review from ArcturusZhang September 18, 2019 20:43
@ArcturusZhang ArcturusZhang merged commit 0581ab6 into Azure:master Sep 19, 2019
@Only2125 Only2125 mentioned this pull request Oct 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majastrz majastrz majastrz approved these changes

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

Assignees

@ArcturusZhang ArcturusZhang

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Shads @AutorestCI @azuresdkci @ArcturusZhang @majastrz