-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define "relations" API as a sub-resource of cases and bookmarks. Allows users to define and maintain relationships between cases and bookmarks across various user scenarios #7191
Conversation
In Testing, Please Ignore[Logs] (Generated from 5621d33, Iteration 8).NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
|
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
https://github.com/Azure/azure-rest-api-specs/pull/7187/files marking APIs under cases as deprecated
...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json
Outdated
Show resolved
Hide resolved
...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json
Show resolved
Hide resolved
...nsights/preview/2019-01-01-preview/examples/bookmarks/relations/GetAllBookmarkRelations.json
Outdated
Show resolved
Hide resolved
...Insights/preview/2019-01-01-preview/examples/bookmarks/relations/CreateBookmarkRelation.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments - please take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The biggest issue was the PUT vs GET. Given that the API is in PROD already and we're fairly late in the process, I will approve on the condition that we address this later. The easiest option I think is to return the target and source node properties in the PUT response and in the GETs. That should comply with the existing rules and also be a simple fix (hopefully).
@ctoma73 , please resolve the conflicts of the PR otherwise I am unable to merge it. |
I merged and resolved all conflicts on branch. Please allow check in #Resolved |
I’ve resolved all conflicts and merged the master branch. Please merge my PR! Thanks !
Claudiu
Sent from my iPhone
On Sep 17, 2019, at 8:03 PM, Renhe Li ***@***.***> wrote:
@ctoma73 , please resolve the conflicts of the PR otherwise I am unable to merge it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
#Resolved
|
Asking please unblock merging and help merge this PR ? All comments and merge conflicts are resolved, please unblock merge! Thanks ! Any help appreciated! #Closed |
The assignee from the SDK team (on this PR, it's @lirenhe) has permissions to merge the PR. #Closed |
@lirenhe, I resolved the comments in CodeFlow, but we shouldn't require that. Once ARM team puts the |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.