Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define "relations" API as a sub-resource of cases and bookmarks. Allows users to define and maintain relationships between cases and bookmarks across various user scenarios #7191

Merged
merged 9 commits into from
Sep 20, 2019

Conversation

ctoma73
Copy link
Contributor

@ctoma73 ctoma73 commented Sep 11, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 11, 2019

In Testing, Please Ignore

[Logs] (Generated from 5621d33, Iteration 8)

Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Warning Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • No packages generated.

@AutorestCI
Copy link

AutorestCI commented Sep 11, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7275

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 12, 2019

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5803

@lirenhe lirenhe added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 12, 2019
@majastrz majastrz added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 17, 2019
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments - please take a look.

@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 17, 2019
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The biggest issue was the PUT vs GET. Given that the API is in PROD already and we're fairly late in the process, I will approve on the condition that we address this later. The easiest option I think is to return the target and source node properties in the PUT response and in the GETs. That should comply with the existing rules and also be a simple fix (hopefully).

@lirenhe
Copy link
Member

lirenhe commented Sep 18, 2019

@ctoma73 , please resolve the conflicts of the PR otherwise I am unable to merge it.

@ctoma73
Copy link
Contributor Author

ctoma73 commented Sep 18, 2019

I merged and resolved all conflicts on branch. Please allow check in #Resolved

@ctoma73
Copy link
Contributor Author

ctoma73 commented Sep 18, 2019 via email

@ctoma73
Copy link
Contributor Author

ctoma73 commented Sep 19, 2019

Asking please unblock merging and help merge this PR ? All comments and merge conflicts are resolved, please unblock merge! Thanks ! Any help appreciated! #Closed

@majastrz
Copy link
Member

majastrz commented Sep 19, 2019

Asking please unblock merging and help merge this PR ? All comments and merge conflicts are resolved, please unblock merge! Thanks ! Any help appreciated! #Resolved

The assignee from the SDK team (on this PR, it's @lirenhe) has permissions to merge the PR. #Closed

@majastrz
Copy link
Member

@lirenhe, I resolved the comments in CodeFlow, but we shouldn't require that. Once ARM team puts the ARMSignedOff label on a PR, it's good to go from our side.

@lirenhe lirenhe merged commit b6bc9c4 into Azure:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants