Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing readmes in resources #7163

Merged
merged 10 commits into from
Sep 11, 2019
Merged

fixing readmes in resources #7163

merged 10 commits into from
Sep 11, 2019

Conversation

zikalino
Copy link

No description provided.

@zikalino zikalino requested a review from Tiano2017 as a code owner September 10, 2019 02:35
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 10, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 3e6ec14, Iteration 9)

Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Failed Python: test-repo-billy/azure-sdk-for-python [Logs]
  • No packages generated.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • In-Progress preview/resources/mgmt/2015-10-01-preview [Logs]
  • In-Progress preview/resources/mgmt/2016-09-01-preview [Logs]
  • In-Progress preview/resources/mgmt/2017-06-01-preview [Logs]
  • In-Progress resources/mgmt/2015-01-01 [Logs]
  • In-Progress resources/mgmt/2015-11-01 [Logs]
  • In-Progress resources/mgmt/2015-12-01 [Logs]
  • In-Progress resources/mgmt/2016-02-01 [Logs]
  • In-Progress resources/mgmt/2016-04-01 [Logs]
  • In-Progress resources/mgmt/2016-06-01 [Logs]
  • In-Progress resources/mgmt/2016-07-01 [Logs]
  • In-Progress resources/mgmt/2016-09-01 [Logs]
  • In-Progress resources/mgmt/2016-12-01 [Logs]
  • In-Progress resources/mgmt/2017-05-10 [Logs]
  • In-Progress resources/mgmt/2017-09-01 [Logs]
  • In-Progress resources/mgmt/2018-02-01 [Logs]
  • In-Progress resources/mgmt/2018-03-01 [Logs]
  • In-Progress resources/mgmt/2018-05-01 [Logs]
  • In-Progress resources/mgmt/2018-06-01 [Logs]
  • In-Progress resources/mgmt/2019-01-01 [Logs]
  • In-Progress resources/mgmt/2019-03-01 [Logs]
  • In-Progress resources/mgmt/2019-05-01 [Logs]
  • In-Progress resources/mgmt/2019-06-01 [Logs]
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • Package generation in progress.

@AutorestCI
Copy link

AutorestCI commented Sep 10, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#7191

@yungezz yungezz added bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed bug This issue requires a change to an existing behavior in the product in order to be resolved. labels Sep 10, 2019
@AutorestCI AutorestCI mentioned this pull request Sep 10, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 10, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#5731

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@zikalino
Copy link
Author

@lmazuel
one of the things I am fixing here is multiapi for managed applications.
apparently 2 versions were included in a batch, but only one api was generated, so it makes me wonder if it was for some reason intentional.

yungezz
yungezz reviewed Sep 10, 2019
View reviewed changes
specification/resources/resource-manager/readme.java.md
@@ -18,7 +18,6 @@ Generate all API versions currently shipped for this package

``` yaml $(java) && $(multiapi)
batch:
- tag: package-2019-06
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there sdk released for this already? what's the impact of removing this line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added package-subscriptions-2019-06 below, so result is the same

specification/resources/resource-manager/readme.md
@@ -40,24 +40,20 @@ tag: package-locks-2016-09
tag: package-policy-2019-06
```

``` yaml $(package-policy)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Author

@zikalino zikalino Sep 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was duplicated, and second has overwritten first resulting in wrong version included in some sdks

yungezz
yungezz reviewed Sep 10, 2019
View reviewed changes
specification/resources/resource-manager/readme.md
``` yaml $(package-resources)
tag: package-resources-2019-08
```

``` yaml $(package-subscriptions)
tag: package-subscriptions-2018-06
tag: package-subscriptions-2019-06
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the sorting order? it's a mess now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean, there's only one tag in here?

yungezz
yungezz reviewed Sep 11, 2019
View reviewed changes
specification/resources/resource-manager/readme.python.md
@@ -25,7 +25,6 @@ batch:
- tag: package-locks-2016-09
- tag: package-locks-2015-01
- tag: package-managedapplications-2018-06
- tag: package-managedapplications-2017-09
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this tag is removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because managedapplications was intentionally generated as single-api, and the second tag was put by mistake here by service team.
basically, in current configuration package-managedapplications-2017-09 will overwrite package-managedapplications-2018-06 meaning that old package was released instead of new one.
so after discussing with @lmazuel I decided to leave it as single api and fix the problem introduced by the service team.

@yungezz yungezz merged commit 1213672 into master Sep 11, 2019
@AutorestCI AutorestCI mentioned this pull request Sep 11, 2019
Merged
@JackTn JackTn deleted the fixing-resources-readmes branch August 9, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yungezz yungezz yungezz left review comments

@mmyyrroonn mmyyrroonn mmyyrroonn approved these changes

@yaohaizh yaohaizh yaohaizh approved these changes

@Tiano2017 Tiano2017 Awaiting requested review from Tiano2017

@xseeseesee xseeseesee Awaiting requested review from xseeseesee

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees

@lmazuel lmazuel

@yaohaizh yaohaizh

@mmyyrroonn mmyyrroonn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zikalino @AutorestCI @azuresdkci @yaohaizh @yungezz @mmyyrroonn @lmazuel