-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eventhub: Added Namespace properties for BYOK #7149
Conversation
In Testing, Please Ignore[Logs] (Generated from 2128273, Iteration 3).NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
|
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment about api version
}, | ||
"description": "Properties to configure Identity for Bring your Own Keys" | ||
}, | ||
"Encryption": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding mutable properties in an API version is a concern with GET->PUT patterns, and is considered a breaking change. If a downlevel client does a GET, after these properties have been set, and then does a PUT - what happens to the resource configuration? PUT semantics would mandate that the properties are removed from the resource. This is a preview api, but it would still be better in a new API version.
@dsouzaarun, can you please take a look? |
Discussed this with Arun during office hours. The team agrees that this change will not be carried forward in the GA apiversion. And will be done in the recommended way by incrementing the api-version. However, to unblock this case and enable team to get partner feedback, approving this. |
@KrisBash could you please unblock this? |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.