Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventhub: Added Namespace properties for BYOK #7149

Merged
merged 3 commits into from
Oct 11, 2019

Conversation

v-Ajnava
Copy link
Member

@v-Ajnava v-Ajnava commented Sep 9, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 9, 2019

@AutorestCI
Copy link

AutorestCI commented Sep 9, 2019

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#6008

@azuresdkci azuresdkci requested a review from zikalino September 9, 2019 00:43
@AutorestCI
Copy link

AutorestCI commented Sep 9, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7821

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about api version

},
"description": "Properties to configure Identity for Bring your Own Keys"
},
"Encryption": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding mutable properties in an API version is a concern with GET->PUT patterns, and is considered a breaking change. If a downlevel client does a GET, after these properties have been set, and then does a PUT - what happens to the resource configuration? PUT semantics would mandate that the properties are removed from the resource. This is a preview api, but it would still be better in a new API version.

@KrisBash KrisBash added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 13, 2019
@v-Ajnava
Copy link
Member Author

@dsouzaarun, can you please take a look?

@ravbhatnagar
Copy link
Contributor

Discussed this with Arun during office hours. The team agrees that this change will not be carried forward in the GA apiversion. And will be done in the recommended way by incrementing the api-version. However, to unblock this case and enable team to get partner feedback, approving this.
We do need to have more concrete guideline on preview api-versions.
Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 27, 2019
@zikalino
Copy link

zikalino commented Oct 8, 2019

@KrisBash could you please unblock this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants