Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom vision 3 1 #7074

Merged
merged 7 commits into from
Sep 23, 2019
Merged

Custom vision 3 1 #7074

merged 7 commits into from
Sep 23, 2019

Conversation

areddish
Copy link
Contributor

Latest improvements:

Adding v3.1 of Custom Vision Training API

  • Introduces a Suggestion API surface that allows for users to get suggested tags and regions in their untagged images. Also supporting query functions for finding image counts and images that were suggested.
  • Added TensorFlowLite export support

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 29, 2019

In Testing, Please Ignore

[Logs] (Generated from c8628d2, Iteration 5)

In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
  • Package generation in progress.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.
In-Progress Ruby: test-repo-billy/azure-sdk-for-ruby [Logs]
  • Package generation in progress.

@AutorestCI
Copy link

AutorestCI commented Aug 29, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7395

@AutorestCI
Copy link

AutorestCI commented Aug 29, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

"parameters": [
{
"name": "projectId",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"/projects/{projectId}/tagsAndRegions/suggestions": {

"DomainsApi"
],
"summary": "Get a list of the available domains.",
"operationId": "GetDomains",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normally operationId is like Resource_Action

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've not been using that style of naming in cognitive serivces. Renaming the operations isn't something we'd want to do in this change as we're trying not to break existing clients.

@yungezz yungezz added the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Sep 2, 2019
@yungezz
Copy link
Member

yungezz commented Sep 5, 2019

@yungezz
Copy link
Member

yungezz commented Sep 5, 2019

hi @ruowan could you pls help to look at the avocado error? thanks.

@ruowan
Copy link
Member

ruowan commented Sep 5, 2019

Hi, @areddish
The avocado error report is Traning.json is not a valid json(JS standard library can't parse it), because Traning.json format is utf-8 with Bom which causes adding extra BOM marker such as 0xfeff at the beginning of the file. To solve this issue, you need to use notepad or other editor open Traning.json and save as utf-8 format instead of utf-8 with BOM.

@yungezz
Copy link
Member

yungezz commented Sep 9, 2019

The PR is ready to merge after CI fixed. PR is reviewed by ARM team in private repo already.

@yungezz
Copy link
Member

yungezz commented Sep 10, 2019

@areddish pls fix CI per @ruowan 's comments. then the PR is ready to go.

@areddish
Copy link
Contributor Author

@yungezz - I've updated the encoding and it appears all is well with the checks.

@yungezz
Copy link
Member

yungezz commented Sep 17, 2019

hi @areddish , there're still 2 errors in CI validation. could you pls do below fixing:

I'll merge it after those issues fixed and CI passed.

Fix example
@yungezz yungezz merged commit ecfb10d into Azure:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants