Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ManagedNetwork Swagger #7035

Merged
merged 5 commits into from
Aug 28, 2019
Merged

Update ManagedNetwork Swagger #7035

merged 5 commits into from
Aug 28, 2019

Conversation

yanfa317
Copy link
Contributor

1, Update tags from obj to array
2, rename peeringPolicyType to type

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 23, 2019

In Testing, Please Ignore

[Logs] (Generated from 79eb876, Iteration 3)

Failed Python: test-repo-billy/azure-sdk-for-python [Logs]
  • No packages generated.
Failed Java: test-repo-billy/azure-sdk-for-java [Logs]
  • No packages generated.
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • No packages generated.
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • No packages generated.
Warning Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@AutorestCI
Copy link

AutorestCI commented Aug 23, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Aug 23, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5630

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yanfa317
Copy link
Contributor Author

@azuresdkci We make this change to update swagger for managedNetwork, please let me know who should review and approve it. Thanks

@lirenhe lirenhe added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 27, 2019
@yungezz
Copy link
Member

yungezz commented Aug 27, 2019

Hi @fearthecowboy could you pls review this PR since there's change in readme fille autorest v3 config?

"create",
"update"
],
"type": "array",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a breaking change, is the APIs for 2019-06-01-preview already released?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lirenhe, we are still doing internal test. Currently I am the only user for this api.

@fearthecowboy
Copy link
Member

I've restored the deleted section manually.

it would have been autogenerated and inserted again, anyway.

Please don't delete sections in the configuration file, this may impact some generation scenarios.

@lirenhe lirenhe removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 28, 2019
@lirenhe lirenhe merged commit 961312c into Azure:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants