-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ManagedNetwork Swagger #7035
Conversation
Pull from Base Master
In Testing, Please Ignore[Logs] (Generated from 79eb876, Iteration 3)Python: test-repo-billy/azure-sdk-for-python [Logs]
Java: test-repo-billy/azure-sdk-for-java [Logs]
Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
.NET: test-repo-billy/azure-sdk-for-net [Logs]
JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
|
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
@azuresdkci We make this change to update swagger for managedNetwork, please let me know who should review and approve it. Thanks |
Hi @fearthecowboy could you pls review this PR since there's change in readme fille autorest v3 config? |
"create", | ||
"update" | ||
], | ||
"type": "array", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a breaking change, is the APIs for 2019-06-01-preview already released?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lirenhe, we are still doing internal test. Currently I am the only user for this api.
I've restored the deleted section manually. it would have been autogenerated and inserted again, anyway. Please don't delete sections in the configuration file, this may impact some generation scenarios. |
1, Update tags from obj to array
2, rename peeringPolicyType to type
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.