Add new ANF API version 2019-07-01 #7012

leonardbf · 2019-08-21T14:45:28Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-08-21T14:45:31Z

In Testing, Please Ignore

[Logs] (Generated from d8f06fd, Iteration 2)

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-netapp [Logs] [Instructions] [Generation PR]
- azure-mgmt-netapp-0.5.0.zip
- azure_mgmt_netapp-0.5.0-py2.py3-none-any.whl

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

Microsoft.Azure.Management.NetApp [Logs] [Instructions]

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-netapp [Logs] [Instructions]
- azure-arm-netapp-4.0.0.tgz

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

netapp/mgmt/2019-05-01 [Logs] [Instructions] [Generation PR]
- netapp.mgmt.2019-05-01.zip
netapp/mgmt/2019-06-01 [Logs]
netapp/mgmt/2019-07-01 [Logs] [Instructions] [Generation PR]
- netapp.mgmt.2019-07-01.zip
preview/netapp/mgmt/2017-08-15 [Logs]

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

netapp/resource-manager/v2017_08_15 [Logs] [Instructions]
netapp/resource-manager/v2019_05_01 [Logs] [Instructions]
netapp/resource-manager/v2019_06_01 [Logs] [Instructions]
netapp/resource-manager/v2019_07_01 [Logs] [Instructions]

AutorestCI · 2019-08-21T14:46:56Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout dbb5a154a36835b48d4c1ff857fe5d591b59e6a7
  stderr: 'fatal: reference is not a tree: dbb5a154a36835b48d4c1ff857fe5d591b59e6a7'

AutorestCI · 2019-08-21T14:50:37Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout dbb5a154a36835b48d4c1ff857fe5d591b59e6a7
  stderr: 'fatal: reference is not a tree: dbb5a154a36835b48d4c1ff857fe5d591b59e6a7'

leonardbf · 2019-08-21T15:08:46Z

The breaking changes step has failed. We have seen this intermittently before even though there has been no change to the identified area. We recall that last time perhaps some other job was not running?

azuresdkci · 2019-08-21T15:20:49Z

Can one of the admins verify this patch?

nschonni · 2019-08-21T19:59:49Z

specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-07-01/netapp.json

+      "description": "The name of the mount target",
+      "x-ms-parameter-location": "method"
+    },
+    "SnapshotName


Suggested change

"SnapshotName

"default": "2019-07-01"

ok, updated on new PR #7020

yaohaizh · 2019-08-22T03:17:43Z

@leonardbf, could you make your pull review with several commits: One commit with copy of previous swagger spec. Then, make commits with diff from previous version. This will make the review focusing on the change part. Otherwise, it is hard to review which part. Thanks.

Initial checkin is with the base 2019-06-01 swagger.

ANF-169 add 2019-07-01 swagger

leonardbf · 2019-08-22T10:54:39Z

PR closed and replaced with #7020 in order to show the changes from the previous API

* [AutoSync] f068b71 adjust enum type name * [AutoSync] e556ace sync back readme files

azuresdkci assigned yaohaizh Aug 21, 2019

azuresdkci requested a review from yaohaizh August 21, 2019 14:46

AutorestCI mentioned this pull request Aug 21, 2019

[AutoPR netapp/resource-manager] Add new ANF API version 2019-07-01 Azure/azure-sdk-for-python#6881

Closed

AutorestCI mentioned this pull request Aug 21, 2019

[AutoPR netapp/resource-manager] Add new ANF API version 2019-07-01 Azure/azure-sdk-for-go#5578

Closed

nschonni reviewed Aug 21, 2019

View reviewed changes

leonardbf and others added 4 commits August 22, 2019 10:06

ANF-169 add 2019-07-01 swagger

aa325ab

Initial checkin is with the base 2019-06-01 swagger.

Merge pull request #30 from leonardbf/ANF-169-add-v07-swagger

cb0db0f

ANF-169 add 2019-07-01 swagger

ANF-169 add 2019-07-01 swagger

5e9e18e

Merge pull request #31 from leonardbf/ANF-169-add-v07-swagger

d8f06fd

ANF-169 add 2019-07-01 swagger

leonardbf force-pushed the master branch from 39453a1 to fb8f078 Compare August 22, 2019 10:19

leonardbf closed this Aug 22, 2019

leonardbf mentioned this pull request Aug 22, 2019

New API version 2019-07-01 for ANF #7020

Merged

5 tasks

leni-msft pushed a commit to leni-msft/azure-rest-api-specs that referenced this pull request May 13, 2022

[AutoSync] Swagger updates for servicelinker/swagger-enum (Azure#7012)

ce6af73

* [AutoSync] f068b71 adjust enum type name * [AutoSync] e556ace sync back readme files

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new ANF API version 2019-07-01 #7012

Add new ANF API version 2019-07-01 #7012

leonardbf commented Aug 21, 2019

openapi-sdkautomation bot commented Aug 21, 2019 •

edited

Loading

AutorestCI commented Aug 21, 2019 •

edited

Loading

AutorestCI commented Aug 21, 2019 •

edited

Loading

leonardbf commented Aug 21, 2019

azuresdkci commented Aug 21, 2019

nschonni Aug 21, 2019

leonardbf Aug 22, 2019

yaohaizh commented Aug 22, 2019

leonardbf commented Aug 22, 2019

Add new ANF API version 2019-07-01 #7012

Add new ANF API version 2019-07-01 #7012

Conversation

leonardbf commented Aug 21, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Aug 21, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from d8f06fd, Iteration 2)

AutorestCI commented Aug 21, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Aug 21, 2019 • edited Loading

Automation for azure-sdk-for-go

leonardbf commented Aug 21, 2019

azuresdkci commented Aug 21, 2019

nschonni Aug 21, 2019

Choose a reason for hiding this comment

leonardbf Aug 22, 2019

Choose a reason for hiding this comment

yaohaizh commented Aug 22, 2019

leonardbf commented Aug 22, 2019

openapi-sdkautomation bot commented Aug 21, 2019 •

edited

Loading

AutorestCI commented Aug 21, 2019 •

edited

Loading

AutorestCI commented Aug 21, 2019 •

edited

Loading