Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to stable version #6997

Merged
merged 7 commits into from
Aug 30, 2019
Merged

Move to stable version #6997

merged 7 commits into from
Aug 30, 2019

Conversation

LTA-Thinking
Copy link
Contributor

@LTA-Thinking LTA-Thinking commented Aug 19, 2019 •
edited
Loading

Moved from a preview version to a stable version. Added a new example, cleaned up some existing examples, and modified some descriptions text.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • [ x ] I have reviewed the documentation for the workflow.
  • [ x ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • [ x ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • [ x ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

Pooja Adhikari and others added 2 commits August 19, 2019 10:56
Following changes are related to updating the arm api version number …
ee89df1 
…to GA version. Current version number is 2018-08-20-preview. GA version number is 2019-09-16
Add new example, change example names, and update kind.
8a0c399
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 19, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from bde45d9, Iteration 9)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Failed healthcareapis/resource-manager/v2018_08_20_preview [Logs]
  • Failed healthcareapis/resource-manager/v2019-09-16 [Logs]
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Aug 19, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5657

@AutorestCI
Copy link

AutorestCI commented Aug 19, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7013

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from michaeljqzq August 19, 2019 23:06
nschonni
nschonni reviewed Aug 20, 2019
View reviewed changes
specification/healthcareapis/resource-manager/readme.md Outdated
azure-arm: true
```

### Tag: package-2018-08-preview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Tag: package-2018-08-preview
### Tag: package-2019-09-16

@michaeljqzq michaeljqzq added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 20, 2019
michaeljqzq
michaeljqzq reviewed Aug 20, 2019
View reviewed changes
specification/healthcareapis/resource-manager/readme.md
@@ -128,6 +150,7 @@ require: $(this-folder)/../../../profiles/readme.md

# all the input files across all versions
input-file:
- $(this-folder)/Microsoft.HealthcareApis/stable/2019-09-16/healthcare-apis.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format error

This was referenced Aug 20, 2019
Merged
Merged
@poadhika
Copy link
Contributor

@nschonni @michaeljqzq I saw the label WaitForArmFeedback. Is there any action that we need to take from our side? We have a GA deadline on 9-16. We need to complete this work before that timeframe. Any help would be mush appreciated.

@michaeljqzq
Copy link
Contributor

@poadhika ARM team will review the PR, normally need no more than a week

@michaeljqzq
Copy link
Contributor

@OpenAPIBot sdkautomation rebuild

@poadhika
Copy link
Contributor

@michaeljqzq Thank you for your response. We have a GA deadline of September 16. How can we expedite this process?

This was referenced Aug 23, 2019
Merged
Merged
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Aug 27, 2019
Closed
@anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 27, 2019
@yungezz
Copy link
Member

yungezz commented Aug 28, 2019

hi @anthony-c-martin could you pls change review state from "request change" to "approve" so we can go ahead to merge?

@poadhika
Copy link
Contributor

@michaeljqzq, @nschonni : Can you please merge the PR?

@michaeljqzq michaeljqzq merged commit 2fbb511 into Azure:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

@michaeljqzq michaeljqzq michaeljqzq approved these changes

Assignees

@michaeljqzq michaeljqzq

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@LTA-Thinking @AutorestCI @azuresdkci @poadhika @michaeljqzq @yungezz @nschonni @anthony-c-martin