Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to the LogicApps Workflow Run Delete operation (New). #6994

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

aalevato
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 19, 2019

@AutorestCI
Copy link

AutorestCI commented Aug 19, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6856

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 19, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5628

@aalevato
Copy link
Contributor Author

Related to #5755 - as suggested, I will abandon the other PR once this once gets merged. Thanks.

@aalevato
Copy link
Contributor Author

None of the "check errors" pointed above are on parts of the code that I touched. The code in master already has the "model validation issues" being raised.

@ArcturusZhang ArcturusZhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 20, 2019
@ArcturusZhang
Copy link
Member

Hi @aalevato , has the ARM team viewed this api change?

@aalevato
Copy link
Contributor Author

aalevato commented Aug 20, 2019

Hi @ArcturusZhang , they haven't. This API was implemented (and has been in production) since the beginning of the year. The first PR I sent for it was back on May. We're changing our processes as for future API changes to go through the ARM team review, but this one was made before it. Like I said, however, we're referring to an API which is already in production for almost 6 months now.

@ArcturusZhang
Copy link
Member

Hi @ArcturusZhang , they haven't. This API was implemented (and has been in production) since the beginning of the year. The first PR I sent for it was back on May. We're changing our processes as for future API changes to go through the ARM team review, but this one was made before it. Like I said, however, we're referring to an API which is already in production for almost 6 months now.

If the ARM team hasn't reviewed these changes, we should wait for them to respond. I will write an email to them if they do not show up till tomorrow

@yungezz
Copy link
Member

yungezz commented Aug 21, 2019

hi @aalevato could you pls fix model validation error? the error message is self explains. Pls ping us if you have difficult on meanings of error. Those errors will be every of your future PRs if not fixed.

@aalevato
Copy link
Contributor Author

@yungezz I said before - the errors appearing on the check are for different files. They were already there before my changes (can you run a check on the current master to see it?). It's not the intention of this PR to fix the other files. Can we please move on already? I don't want us dropping in the same infinite bucket as before and wait for months.

@yungezz
Copy link
Member

yungezz commented Aug 22, 2019

@aalevato yes the modelvalidation is from existing codes in the swagger file. While it will be there in every future PR on this swagger file? Do your team have any plan to fix it? Besides this, this PR is pending on ARM review. After ARM signed off, feel free to ping us for PR merging.

@aalevato
Copy link
Contributor Author

@ArcturusZhang we still didn't hear back from ARM. Can we please move forward with it? This process had been going already for several months, and the users are eager to use the API (which is already in production) but can't do so because they want to see it on the swagger first.

@anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 26, 2019
@aalevato
Copy link
Contributor Author

Thanks @anthony-c-martin - @yungezz @ArcturusZhang can we merge it now? Thanks!

@aalevato
Copy link
Contributor Author

@yungezz @ArcturusZhang It says I'm not authorized to merge. Can someone please merge the PR? Thanks!

@yungezz yungezz merged commit c1bf282 into Azure:master Aug 28, 2019
@aalevato aalevato deleted the andre/flowdeleterun branch August 30, 2019 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants