-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support to the LogicApps Workflow Run Delete operation (New). #6994
Conversation
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Related to #5755 - as suggested, I will abandon the other PR once this once gets merged. Thanks. |
None of the "check errors" pointed above are on parts of the code that I touched. The code in master already has the "model validation issues" being raised. |
Hi @aalevato , has the ARM team viewed this api change? |
Hi @ArcturusZhang , they haven't. This API was implemented (and has been in production) since the beginning of the year. The first PR I sent for it was back on May. We're changing our processes as for future API changes to go through the ARM team review, but this one was made before it. Like I said, however, we're referring to an API which is already in production for almost 6 months now. |
If the ARM team hasn't reviewed these changes, we should wait for them to respond. I will write an email to them if they do not show up till tomorrow |
hi @aalevato could you pls fix model validation error? the error message is self explains. Pls ping us if you have difficult on meanings of error. Those errors will be every of your future PRs if not fixed. |
@yungezz I said before - the errors appearing on the check are for different files. They were already there before my changes (can you run a check on the current master to see it?). It's not the intention of this PR to fix the other files. Can we please move on already? I don't want us dropping in the same infinite bucket as before and wait for months. |
@aalevato yes the modelvalidation is from existing codes in the swagger file. While it will be there in every future PR on this swagger file? Do your team have any plan to fix it? Besides this, this PR is pending on ARM review. After ARM signed off, feel free to ping us for PR merging. |
@ArcturusZhang we still didn't hear back from ARM. Can we please move forward with it? This process had been going already for several months, and the users are eager to use the API (which is already in production) but can't do so because they want to see it on the swagger first. |
Thanks @anthony-c-martin - @yungezz @ArcturusZhang can we merge it now? Thanks! |
@yungezz @ArcturusZhang It says I'm not authorized to merge. Can someone please merge the PR? Thanks! |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.