Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.Insights Log Analytics Query Pack Resource #6992

Merged
merged 26 commits into from
Sep 5, 2019
Merged

Microsoft.Insights Log Analytics Query Pack Resource #6992

merged 26 commits into from
Sep 5, 2019

Conversation

arolshan
Copy link
Contributor

@arolshan arolshan commented Aug 19, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 19, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 0382c54, Iteration 14)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Failed applicationinsights/resource-manager/v2015_05_01 [Logs]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • Warning appinsights/mgmt/2015-05-01 [Logs]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 19, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from f57d6c7, Iteration 2)

In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • Package generation in progress.
In-Progress Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
  • Package generation in progress.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • In-Progress appinsights/mgmt/2015-05-01 [Logs]
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from anuchandy August 19, 2019 15:01
@AutorestCI
Copy link

AutorestCI commented Aug 19, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Aug 19, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

This was referenced Aug 19, 2019
Merged
Closed
nschonni
nschonni reviewed Aug 19, 2019
View reviewed changes
Copy link
Contributor

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analaytics -> Analytics

...hts/resource-manager/Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json Outdated Show resolved Hide resolved
...ninsights/resource-manager/Microsoft.Insights/preview/2019-09-01-preview/QueryPacks_API.json Outdated Show resolved Hide resolved
...ninsights/resource-manager/Microsoft.Insights/preview/2019-09-01-preview/QueryPacks_API.json Outdated Show resolved Hide resolved
anuchandy
anuchandy requested changes Aug 19, 2019
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at model validation errors https://dev.azure.com/azure-sdk/public/_build/results?buildId=91363

@anuchandy anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 19, 2019
@KrisBash KrisBash added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 4, 2019
@arolshan arolshan requested a review from KrisBash September 4, 2019 06:56
@arolshan arolshan requested a review from pilor September 5, 2019 08:02
@arolshan arolshan requested a review from pilor September 5, 2019 18:48
@pilor
Copy link
Contributor

pilor commented Sep 5, 2019

LGTM

@pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 5, 2019
@anuchandy anuchandy merged commit 35c2154 into Azure:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@anuchandy anuchandy anuchandy approved these changes

@pilor pilor pilor approved these changes

@KrisBash KrisBash Awaiting requested review from KrisBash

Assignees

@anuchandy anuchandy

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@arolshan @azuresdkci @AutorestCI @anuchandy @pilor @nschonni @KrisBash