Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding low priority and variable pricing feature for standalone VMs. Added priority, eviction policy and billing profile to VirtualMachineProperties. Also, adding optional billing profile to VMSS Create and Update APIs. #6961

Merged
merged 6 commits into from
Aug 22, 2019
Merged

Adding low priority and variable pricing feature for standalone VMs. Added priority, eviction policy and billing profile to VirtualMachineProperties. Also, adding optional billing profile to VMSS Create and Update APIs. #6961

merged 6 commits into from
Aug 22, 2019

Conversation

rakeshakkera
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 14, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 10d72ee, Iteration 6)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Warning Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Warning compute/resource-manager/v2017_03_30 [Logs]
  • Warning compute/resource-manager/v2017_09_01 [Logs]
  • Warning compute/resource-manager/v2017_12_01 [Logs]
  • Warning compute/resource-manager/v2018_04_01 [Logs]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Warning Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@azuresdkci azuresdkci requested a review from yungezz August 14, 2019 19:23
@AutorestCI AutorestCI mentioned this pull request Aug 14, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Aug 14, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#6896

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Aug 14, 2019
Closed
@rakeshakkera
Added priority, eviction policy and billing profile to VirtualMachine…
efda95a 
…Properties as well as low priority will now be supported in standalone VMs as well.
@rakeshakkera
merged from Azure/master. And added priority, eviction policy and bil…
26a468a 
…ling profile to VirtualMachineProperties as well as low priority will now be supported in standalone VMs as well.
@rakeshakkera
fixed typo
10d72ee
@rakeshakkera rakeshakkera changed the title Adding optional billing profile to VMSS Create and Update APIs for Api Version 2019-03-01 Adding low priority and variable pricing feature for standalone VMs. Also, adding optional billing profile to VMSS Create and Update APIs for Api Version 2019-03-01. Aug 14, 2019
@rakeshakkera rakeshakkera changed the title Adding low priority and variable pricing feature for standalone VMs. Also, adding optional billing profile to VMSS Create and Update APIs for Api Version 2019-03-01. Adding low priority and variable pricing feature for standalone VMs. Added priority, eviction policy and billing profile to VirtualMachineProperties. Also, adding optional billing profile to VMSS Create and Update APIs. Aug 14, 2019
@AutorestCI AutorestCI mentioned this pull request Aug 14, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 14, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5579

@yungezz yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 15, 2019
@PhoenixHe-NV PhoenixHe-NV mentioned this pull request Aug 16, 2019
Closed
@hyonholee
Copy link
Contributor

LGTM

@yungezz
Copy link
Member

yungezz commented Aug 21, 2019

@rakeshakkera waiting for ARM feedback. Will ping ARM team.

@ravbhatnagar
Copy link
Contributor

This change should ideally go in a new API-version as per the Microsoft REST API guidelines. But since CRP PUT is not compliant, I guess ARM can approve this sub-optimal modeling. @johngossman FYI and in case you have any input on this.

@ravbhatnagar
Copy link
Contributor

Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 21, 2019
@hyonholee hyonholee self-assigned this Aug 21, 2019
@rakeshakkera
Copy link
Contributor Author

rakeshakkera commented Aug 21, 2019 •
edited
Loading

@rakeshakkera waiting for ARM feedback. Will ping ARM team.

@yungezz I have approval from ARM. Could you help merge the pull request? Looks like I don't have permission.

huangpf
huangpf approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@huangpf huangpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve on behalf of the team, since Hyonho has approved.

P.S.
OneSDK team -- please help put me as an option review, if you see this. Thanks.

@yungezz yungezz merged commit fb8f078 into Azure:master Aug 22, 2019
@AutorestCI AutorestCI mentioned this pull request Aug 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yungezz yungezz yungezz left review comments

@hyonholee hyonholee hyonholee approved these changes

@huangpf huangpf huangpf approved these changes

Assignees

@hyonholee hyonholee

@yungezz yungezz

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rakeshakkera @AutorestCI @azuresdkci @hyonholee @yungezz @ravbhatnagar @huangpf