Update vmssNetworkInterface.json #6916

RajarajeshwariHS · 2019-08-09T08:42:16Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-08-09T08:44:23Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout d81f4f43fb6f3f1f5b9e5fd01c22cc6d2e4be704
  stderr: 'fatal: reference is not a tree: d81f4f43fb6f3f1f5b9e5fd01c22cc6d2e4be704'

AutorestCI · 2019-08-09T09:20:13Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout d81f4f43fb6f3f1f5b9e5fd01c22cc6d2e4be704
  stderr: 'fatal: reference is not a tree: d81f4f43fb6f3f1f5b9e5fd01c22cc6d2e4be704'

azuresdkci · 2019-08-09T09:23:35Z

Can one of the admins verify this patch?

tjprescott · 2019-08-09T15:47:04Z

...ation/network/resource-manager/Microsoft.Network/stable/2019-06-01/vmssNetworkInterface.json

@@ -3,7 +3,7 @@
  "info": {
    "title": "NetworkManagementClient",
    "description": "The Microsoft Azure Network management API provides a RESTful set of web services that interact with Microsoft Azure Networks service to manage your network resources. The API has entities that capture the relationship between an end user and the Microsoft Azure Networks service.",
-    "version": "2017-03-30"


What is the reason for this change?

Ping @RajarajeshwariHS

This was suggested by @number213 as it was required for this PR : #6692

Yes, if we're updating API version in vmssPublicIpAddress, we should also update it in vmssNetworkInterface. I guess the question is what's the reason for changing API version in VMSS specs? Just to use the latest one?

We use latest Microsoft.Azure.Management.Network nuget which is of version “19.12.0-preview”. I searched in the source repository of this repo and found out the required API : ListVirtualMachineScaleSetPublicIPAddressesWithHttpMessagesAsync
https://github.com/Azure/azure-sdk-for-net/blob/dc23a39caf37d07f02512540d20c29866ff83759/sdk/network/Microsoft.Azure.Management.Network/src/Generated/PublicIpAddressesOperations.cs

Here the apiVersion is set as “2017-03-30”. We require it to be “2018-10-01”.
So, here #6692 I have made the required changes to vmssPublicIPAddress and as we have to also update vmssNetworkInterface, I have made the changes here.

@RajarajeshwariHS makes sense.
If you need updated Network SDK asap, we can work on getting you a signed nupkg, because the next NuGet release will be in a month

tjprescott · 2019-08-19T15:53:06Z

/azurepipelines run

azure-pipelines · 2019-08-19T15:53:22Z

Azure Pipelines successfully started running 2 pipeline(s).

anton-evseev · 2019-08-19T19:41:42Z

@tjprescott SDK java times out regularly, I guess this is due to the size of Network's specs

tjprescott · 2019-08-20T15:20:27Z

I don't have the ability to merge this while the CI is failing. @sergey-shandar can you take a look?

anton-evseev · 2019-08-21T03:51:37Z

Opened PR with this change into Network release branch: #7008

openapi-sdkautomation · 2019-08-21T03:51:41Z

In Testing, Please Ignore

[Logs] (Generated from a9a33fd, Iteration 1)

Update vmssNetworkInterface.json

a9a33fd

RajarajeshwariHS requested a review from MikhailTryakhov as a code owner August 9, 2019 08:42

azuresdkci assigned tjprescott Aug 9, 2019

azuresdkci requested a review from tjprescott August 9, 2019 08:43

AutorestCI mentioned this pull request Aug 9, 2019

[AutoPR network/resource-manager] Update vmssNetworkInterface.json Azure/azure-sdk-for-go#5481

Closed

RajarajeshwariHS mentioned this pull request Aug 9, 2019

Update vmssPublicIpAddress.json #6692

Closed

5 tasks

tjprescott reviewed Aug 9, 2019

View reviewed changes

PhoenixHe-NV mentioned this pull request Aug 16, 2019

[Mirror] Update vmssNetworkInterface.json test-repo-tih/azure-rest-api-specs#118

Closed

anton-evseev approved these changes Aug 16, 2019

View reviewed changes

tjprescott approved these changes Aug 19, 2019

View reviewed changes

anton-evseev mentioned this pull request Aug 21, 2019

Update API version in VMSS' specs #7008

Merged

5 tasks

anton-evseev closed this Aug 21, 2019

leni-msft pushed a commit to leni-msft/azure-rest-api-specs that referenced this pull request May 13, 2022

[AutoSync] 7b49650 update swagger for java sdk (Azure#6916)

f1578bd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update vmssNetworkInterface.json #6916

Update vmssNetworkInterface.json #6916

RajarajeshwariHS commented Aug 9, 2019

AutorestCI commented Aug 9, 2019 •

edited

Loading

AutorestCI commented Aug 9, 2019 •

edited

Loading

azuresdkci commented Aug 9, 2019

tjprescott Aug 9, 2019

anton-evseev Aug 14, 2019

RajarajeshwariHS Aug 15, 2019 •

edited

Loading

anton-evseev Aug 15, 2019

RajarajeshwariHS Aug 16, 2019 •

edited

Loading

anton-evseev Aug 16, 2019

tjprescott commented Aug 19, 2019

azure-pipelines bot commented Aug 19, 2019

anton-evseev commented Aug 19, 2019

tjprescott commented Aug 20, 2019

anton-evseev commented Aug 21, 2019

openapi-sdkautomation bot commented Aug 21, 2019 •

edited

Loading

Update vmssNetworkInterface.json #6916

Update vmssNetworkInterface.json #6916

Conversation

RajarajeshwariHS commented Aug 9, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Aug 9, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Aug 9, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Aug 9, 2019

tjprescott Aug 9, 2019

Choose a reason for hiding this comment

anton-evseev Aug 14, 2019

Choose a reason for hiding this comment

RajarajeshwariHS Aug 15, 2019 • edited Loading

Choose a reason for hiding this comment

anton-evseev Aug 15, 2019

Choose a reason for hiding this comment

RajarajeshwariHS Aug 16, 2019 • edited Loading

Choose a reason for hiding this comment

anton-evseev Aug 16, 2019

Choose a reason for hiding this comment

tjprescott commented Aug 19, 2019

azure-pipelines bot commented Aug 19, 2019

anton-evseev commented Aug 19, 2019

tjprescott commented Aug 20, 2019

anton-evseev commented Aug 21, 2019

openapi-sdkautomation bot commented Aug 21, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from a9a33fd, Iteration 1)

AutorestCI commented Aug 9, 2019 •

edited

Loading

AutorestCI commented Aug 9, 2019 •

edited

Loading

RajarajeshwariHS Aug 15, 2019 •

edited

Loading

RajarajeshwariHS Aug 16, 2019 •

edited

Loading

openapi-sdkautomation bot commented Aug 21, 2019 •

edited

Loading